fix: add JSON parse safety checks - I would be glad to become your contributor#5
Open
MatrixNeoKozak wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses potential runtime exceptions caused by unsafe
JSON.parse()operations.Changes
1998.jsanddtpk.js.JSON.parseoperations in safety checks to handle scenarios where the input body or nested data fields might be malformed ornull/undefined.Rationale
In the current implementation,
JSON.parse(body)and nested property access (e.g.,obj.data.mainInfoList) could throw exceptions if the API response unexpectedly returns invalid JSON, empty content, or unexpected structures. This can crash the script and cause it to fail silently.Technical Impact