Skip to content

Small performance enhancements for the content analysis - #20925

Merged
Jordi-PV merged 1 commit into
trunkfrom
fix/performance
Mar 12, 2024
Merged

Jordi-PV merged 1 commit into
trunkfrom
fix/performance

Conversation

@mhkuu

@mhkuu mhkuu commented Dec 8, 2023 •

Copy link
Copy Markdown
Contributor

Context

  • We profiled our analysis and saw two obvious possibilities for performance enhancements:
    • Use a global replace instead of split and join to replace HTML entities (reference).
    • Use a Set to remove duplicates from lists (reference), instead of uniq from lodash.

Summary

This PR can be summarized in the following changelog entry:

  • Improves the performance of the content analysis.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Block/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • The affected code is used in a lot of places in the plugin -- but we have good test coverage to ensure nothing breaks -- so that's why a general smoke test suffices.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/lingo-other-tasks/issues/363

@mhkuu mhkuu added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Dec 8, 2023
@mhkuu mhkuu changed the title Small performance enhancements for packages/yoatseo Small performance enhancements for the content analysis Dec 8, 2023
@mhkuu
mhkuu marked this pull request as ready for review December 8, 2023 09:55
@Jordi-PV Jordi-PV modified the milestones: 22.3, 22.4 Mar 12, 2024
@Jordi-PV
Jordi-PV merged commit 5d28f93 into trunk Mar 12, 2024
@Jordi-PV
Jordi-PV deleted the fix/performance branch March 12, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants