Repository navigation
chore(sync): merge pingdotgg/t3code main - #373
Merged
Merged
Conversation
pingdotgg#25493) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pingdotgg#25468) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#25461) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#25461) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ger throws (pingdotgg#25503) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pingdotgg#25462) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pingdotgg#25515) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gg#25516) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…er title (pingdotgg#25521) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…6-1509 # Conflicts: # apps/mobile/src/features/threads/ThreadComposer.tsx # apps/web/src/hooks/useEnvironmentTheme.ts # apps/web/src/routes/__root.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
Fork Sync run 40346250614 stopped on merge conflicts in 3 files. The batch has 10 upstream commits:
appInit.tsx, no longer from components in__root.tsx. The published theme palettes move fromuseEnvironmentTheme.tsinto an atom inthemePalette.ts.Conflicts and resolution
useEnvironmentTheme.ts: upstream's file. The forkuseActiveThemeFontshook stays.themePalette.ts(no conflict, but the fork style fields were lost): upstream'senvironmentThemeDefinitionnow builds the definitions. One fork line addsstyle: publishedThemeStyle(theme)to it.__root.tsx: upstream dropsSlowRpcRequestToastCoordinatorandBrowserChromeThemeSync. The forkForkAccessChangeNoticesstays. The fork machine paused and client pending screens no longer mount their own chrome sync, because the app now syncs it on every route render.ThreadComposer.tsx: upstream'suseDerivedValueborder radius. The fork theme radius and raised style stay as its input.Fork fixes
applyThemeStyle, active theme fonts and icons, user CSS,publishedThemeStyle) moves fromthemePalette.tsinto the new fork fileapps/web/src/forkThemeStyle.ts.themePalette.tskeeps one import and two calls.appInit.tsx,AppIcon.tsxanduseEnvironmentTheme.tsimport from the fork file.themeStyle.browser.test.ts: upstream removedsetEnvironmentThemes. The test now publishes themes through the server themes atom, as upstream'suseEnvironmentTheme.test.tsdoes.Upstream merge
Merges pingdotgg/t3code main at 3f94487 "fix(web): switching back to a thread no longer restores its tab's older title (pingdotgg#25521)".
Adopted upstream pull requests
All 7 entries are unchanged at their listed heads. No new merges.
Upstream changes in fork areas
16 files changed on both sides. Apart from the conflicts above, none affects a fork feature:
ThreadQueueControl.tsx,use-thread-composer-state.ts): upstream changes the drag state and the end of queued edits. The fork usage limit guard on Resume and Send merged without a change.appInit.tsx: upstream adds the theme repaint and chrome sync next to the fork theme font sync.entities.ts: upstream removes the active environment id atom. No fork code uses it.Checks
checks.py: typecheck, migration check, adopted pull request check, format and lint pass. Knip passes when run alone.fork_tests.py: 179 fork test files pass locally (117 root and 62 web). Theapps/serverfork test files are left to Fork CI.useEnvironmentTheme.test.tsandthemePalette.test.tspass.Fork repair skill changes
None.