Repository navigation
feat: reusable Chromium desktop status integration for Homepage - #3
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8e364575b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| except (OSError, ValueError, KeyError): | ||
| pass |
There was a problem hiding this comment.
If the CDP endpoint closes a response before its declared Content-Length is received, json.load(response) raises http.client.IncompleteRead, which is not covered by this exception handler. Reproducing this with a local HTTP server causes summary() to raise instead of returning the documented Offline/null state; consequently, /summary closes without an HTTP response and Homepage loses the entire status widget. Catch upstream HTTP protocol errors as well so a partial CDP response degrades to the existing unavailable state.
Useful? React with 👍 / 👎.
Publish a configurable, privacy-safe Python read model and Homepage Custom API example for Chromium page targets, optional MCP readiness and a named process. Includes tests and Compose example. Generic logic is owned by Resources; deployment-specific settings stay in infrastructure.