Repository navigation
Conversation
`sizeof` was incorrectly used to get the length of an string in an array of char pointers (array of strings), which always returns the system's pointer size (8 on 64bit) instead of the actual string length. Was fixed by using `strlen` instead. Additionally the final step that appended the returning array of strings with another array of strings, also used an incorrect `memcpy` function to copy the elements. Was fixed by using an explicit for loop. And I also replaced the 'length' variables' type's with the proper `size_t` type instead of `int`, where possible. Issue and patch from: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=299077 Signed-off-by: b-aaz <b-aazbsd@proton.me>
|
|
||
| ret = tmp; | ||
| memcpy(ret + oldlen, subret, sublen); | ||
| for (size_t i = 0; i < sublen; i++) { |
Contributor
There was a problem hiding this comment.
woudn't be same, if used
memcpy(&ret[oldlen], subret,sublen);
``` ?
Contributor
|
LGTM I assume in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=299077 tested it. |
cepelinas9000
self-requested a review
November 12, 2026 10:15
cepelinas9000
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sizeofwas incorrectly used to get the length of an string in an array of char pointers (array of strings), which always returns the system's pointer size (8 on 64bit) instead of the actual string length. Was fixed by usingstrleninstead.Additionally the final step that appended the returning array of strings with another array of strings, also used an incorrect
memcpyfunction to copy the elements.Was fixed by using an explicit for loop.
And I also replaced the 'length' variables' type's with the proper
size_ttype instead ofint, where possible.Issue and patch from:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=299077