Repository navigation
[Website] Keep database tools in the app browser partition - #4479
Merged
Merged
Conversation
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 9
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 21, 2026
Base automatically changed from
codex/frame-review-03-frame-messages
to
trunk
October 21, 2026 17:31
adamziel
added a commit
that referenced
this pull request
Oct 21, 2026
Part 3/10. Builds on #4477 · Next: #4479. WordPress reports its current URL to the parent frame. Reply to late subscriptions, report History API changes, and relay outside clicks so the app can dismiss its menus without reading the WordPress document. Check the sending window and origin. Send app relay and WebMCP messages to the configured WordPress origin. The WordPress plugin accepts its parent origin from the PHP runtime; ordinary same-origin behavior stays unchanged. This prepares the frame messages for the origin switch later in the stack. It does not enable that switch. ## Testing The existing website and remote tests still run. Follow dashboard links, change the address bar, dismiss a menu by clicking WordPress, and use a WebMCP tool. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> <!-- coderabbit-ai-generated:v1 --> ## Summary by CodeRabbit - **New Features** - Improved synchronization between embedded WordPress pages and the browser address bar, including History API navigation. - Added reliable URL retrieval for embedded pages. - Added pointer-event relaying across nested frames. - **Bug Fixes** - Prevented relayed pointer events from being handled more than once. - Improved compatibility with plain HTML pages and nested editor frames. - Strengthened iframe message validation and handling when embedded content is unavailable. - Improved secure communication with embedded WordPress content. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
adamziel
force-pushed
the
codex/frame-review-04-database-popups
branch
from
October 21, 2026 17:39
c5f7f59 to
8a9458f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 4/10. Builds on #4478 · Next: #4480.
Keeps “Open Adminer” and “Open phpMyAdmin” connected to the running Playground after WordPress moves to a separate origin.
Why opening the tool directly can break
For example, the running Playground has this layout:
WordPress runs in the browser, not on our web server. Its HTTP requests must reach the service worker that connects them to the running PHP instance.
Opening Adminer directly would make the WordPress origin the top-level page:
WebKit can look up service workers using both the top-level origin and the WordPress origin. The new tab has changed the first value, so it can miss the worker serving the existing site. This is browser separation called partitioning. WebKit describes the rule here.
What this changes
Open a small page on the Playground origin and put the database tool inside its WordPress iframe:
Both origins now match the running Playground. The tool can use its existing service worker, PHP instance, and database. The wrapper is just a full-window iframe. It does not boot another Playground or copy the database.
/scope:…/path.Not every browser needs the wrapper: Chrome can share the service-worker partition for same-site origins. Keeping the frame layout also covers browsers that separate it by the full top-level origin. Chrome's partition rules.
Testing
With WordPress on a separate origin, open Adminer and phpMyAdmin from the database panel. In each tool, browse a table, save a change, and confirm it appears in the running WordPress site. Repeat with a same-origin setup to check the direct tabs still work.
Summary by CodeRabbit
New Features
Bug Fixes