Repository navigation
[PHP-WASM] Track PHP log replacement separately for each Playground - #4392
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughPHP log collection now tracks previous log contents separately for each collector. It emits only appended content when the new log retains the previous contents as a prefix, and emits the full log when the contents change. ChangesPHP log collection
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk remains; the change is ready for normal merge checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Track the last PHP log separately for each Playground and emit only the unread suffix.
An import can replace debug.log with a shorter file or a different file of the same length. A shared length counter missed those errors and also leaked read offsets between Playgrounds. Reuse a prefix only when the current log still starts with the text already read.
This is PR 8 extracted from #4373. Targets
trunkdirectly; no dependency on the other split PRs.Testing
Append to debug.log, replace it, then remove and recreate it. Check that each new record reaches Logs once. The tests also create two collectors with different log lengths.
Summary by CodeRabbit