Repository navigation
[Web] Cache offline assets only from the Playground origin - #4391
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthrough
ChangesOffline cache eligibility
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Offline caching now excludes assets from different ports or schemes, and the tests detect a regression to hostname-only matching. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Cache offline assets only from the Playground's own origin.
Two servers can share a hostname but run on different ports. Matching only the hostname let a live WordPress site's API response enter the Playground asset cache. Compare the full origin, including scheme and port.
This is PR 7 extracted from #4373. Targets
trunkdirectly; no dependency on the other split PRs.Testing
Review the same-origin, different-port, and different-scheme cases. Rely on CI for the remote package tests.
Summary by CodeRabbit