Repository navigation
Document ESM and CommonJS build check - #4361
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe Changesnx-extensions documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Other Merge Risk: ⚪ Minimal · up to The README accurately describes the available build, Vitest, and ESM/CJS-check commands. No actionable merge risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Lovely, thank you @fellyph ! |
Motivation for the change, related issues
Document the
test:esmcjstarget for contributors maintaining packages that publish both ESM and CommonJS builds.Closes #506.
Implementation details
assert-built-esm-and-cjschecks and the limits of that check.outputPath, the build dependency, aproject.jsonexample, and the command to run the target.Testing Instructions (or ideally a Blueprint)
Documentation only. Reviewed the example against the current executor and Playground Client target;
git diff --checkpassed.Summary by CodeRabbit