Repository navigation
Upgrade Emscripten version - #2116
brandonpayton wants to merge 4 commits into
Conversation
|
Quoting from this earlier comment:
I wrote a small node script to identify the insertion point and perform the insertion but forgot it needed to run within a Docker container if we patch in the same place we patch other Emscripten things. By default, node and npm are not installed there. And this approach deviates from the current approach with @bgrgicak, I am AFK for the rest of the week and do not plan to look at this again until next Monday. Please feel free to pick this up in the meantime if you want to fix this earlier. |
|
Good explorations here! I agree, the replace.sh approach is not readable at all. We could contribute some of these to the Emscripten repo but not all – e.g. I wouldn't expect the websocket decorator logic to make it past the review. What if we forked Emscripten, applied these changes, and then just kept our fork up to date with the upstream? |
This sounds like a good idea and definitely better than hand-patching various aspects of the build output. I don't know if this means we will need to build emscripten itself on the fly or produce our own builds for each release version, but we can see... Maybe we can keep a branch of customizations that is rebased and tagged whenever we upgrade, so our changes are always latest in the branch. |
|
Emscripten got updated in another PR in the meantime, let me close this one |
Motivation for the change, related issues
There are a couple of reasons for this upgrade:
Implementation details
This PR:
Testing Instructions (or ideally a Blueprint)