You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Move Playground-based applications to dedicated repositories #473
This issue exist to move the applications built with WordPress Playground to dedicated repositories to keep the WordPress Playground project focused on its long-term vision and to help applications built on the Playground to maintain their own faster iteration pace.
The Playground framework and projects built on the Playground have different needs, values, and philosophies. Separating applications from the main framework repository creates an environment that allows both apps and the framework to move at their natural paces, leading to more focused and efficient development.
Applications may prioritize attracting open-source contributions or they may be better-off prioritizing fast iterations by the core team. They may focus on extensibility or they may be better-off prioritizing features. They have varying needs in regard to coding standards, build tools, versioning schemes, CI processes, and project management principles.
Playground, however, have very specific priorities outlined in the vision. It aims to be approachable for new contributors, easy to maintain, and focused on foundational tools. It has specific coding standards, build tools, versioning scheme, CI processes, and project management principles. Every extra package in the Playground repo, no matter how great, makes the codebase a little bit more difficult to approach, adds a little extra time to the weekly maintenance, and makes the project a little bit less focused.
Therefore, it is for the best for WordPress Playground and the applications built using WordPress Playground to grow in a space that’s tailored specifically for their own unique needs.
Next steps
Discussion and comments on this issue are welcome.
Yes — it's a question of whether they share the same fundamentals or not.
@danielbachhuber Modes specifically are a tough one because that’s still an open discussion. However, there’s a few other angles here:
VS Code extension will need to be greatly adjusted to work with the in-browser version of VS Code, including removing the dependency on Node.js and any node imports (like fs).
VS Code extension is meant primarily for a different audience – folks who are not familiar or not comfortable with the CLI. Their needs may or may not shape the extension differently than the CLI tool.
VS Code extension can auto-update which means it has more freedom to bundle time-bound assets like specific WordPress releases.
I'd say let's separate them for now, see how that works for both, and pay attention to signs telling us to reconnect them.
What will happen to the WordPress Playground codebase when you go on sabbatical.
@dmsnell will tentatively shepherd WordPress Playground core while I'm away.
I'd say let's separate them for now, see how that works for both, and pay attention to signs telling us to reconnect them.
Sounds fine.
I think we should create entirely separate repositories for each codebase. Assuming the VS Code Extension gets a bit more traction, it will helpful to have a unique issue tracker.
@danielbachhuber Thinking about this more, https://github.com/WordPress/playground-tools is just the interactive code block at the moment. I expect some activity there but not much. Moving VS code extension to that same repo will still give it an almost unique issue tracker while reducing the overall fragmentation.
If that becomes hard to manage for any reason, it will be easy to move it to its very own repo. It won't experience any core downsides in that repo, too, and will have its own versioning scheme etc. So almost all of the upside while reducing chores over multiple repositories. WDYT?
As @danielbachhuber pointed out in another conversation, keeping WordPress Playground code under the WordPress organization seems like the most natural choice.
I think that they should either: 1) all be in the same repository, or 2) all be in separate repositories.
This concludes moving applications out of the main Playground repo. If you'd like to house these tools in a different repo than playground-tools we can still do that.
I also think we should persist git history when we move them.
I included the link to the previous wp-now package in the migration commit. The grafted commit mentioned by @dmsnell should allow the consumers of the repo to connect that commit with the playground tree. Otherwise, if you know of any technique that would preserve the history in the GitHub web UI, please share and let's do it.
Activity
danielbachhuber commentedon May 30, 2023
adamziel commentedon May 30, 2023
@danielbachhuber I remember you preferred to focus on the CLI tool and I'm happy to the VS Code extension in the https://github.com/WordPress/playground-tools repo for now.
No changes there:
wp-nowwould remain maintained by the same team as it nowdanielbachhuber commentedon May 30, 2023
A third question:
wp-now? https://github.com/WordPress/wordpress-playground/tree/trunk/packages/wp-now#automatic-modesFor clarity, who is this? It'd probably be good to have a
@wordpress/playground-committersor similar team: https://github.com/orgs/WordPress/teams?query=playgroundadamziel commentedon May 30, 2023
Is this relevant for the move? I'd like to keep this issue focused but we can discuss that separately in another one.
Communication around Playground governance will follow soon, this issue is about code organization. Is there anything specific you're concerned about?
Setting up a team sounds like a great idea 👍
danielbachhuber commentedon May 30, 2023
Yes — it's a question of whether they share the same fundamentals or not.
What will happen to the WordPress Playground codebase when you go on sabbatical.
adamziel commentedon May 30, 2023
@danielbachhuber Modes specifically are a tough one because that’s still an open discussion. However, there’s a few other angles here:
fs).I'd say let's separate them for now, see how that works for both, and pay attention to signs telling us to reconnect them.
@dmsnell will tentatively shepherd WordPress Playground core while I'm away.
Remove interactive-code-block from the main repository. See #473.
Remove VS Code extension from the repository. See #473.
Remove wp-now from the repository. See #473.
danielbachhuber commentedon May 30, 2023
Sounds fine.
I think we should create entirely separate repositories for each codebase. Assuming the VS Code Extension gets a bit more traction, it will helpful to have a unique issue tracker.
Remove interactive-code-block from the main repository so it can live…
adamziel commentedon May 31, 2023
@danielbachhuber Thinking about this more, https://github.com/WordPress/playground-tools is just the interactive code block at the moment. I expect some activity there but not much. Moving VS code extension to that same repo will still give it an almost unique issue tracker while reducing the overall fragmentation.
If that becomes hard to manage for any reason, it will be easy to move it to its very own repo. It won't experience any core downsides in that repo, too, and will have its own versioning scheme etc. So almost all of the upside while reducing chores over multiple repositories. WDYT?
6 remaining items
sejas commentedon May 31, 2023
Is it a good idea to push the changes to Automattics's repo https://github.com/Automattic/wordpress-playground and then rename it to
wp-now?Merge pull request #2 from WordPress/add-wp-now
Migrate wp-now from WordPress Playground repo
adamziel commentedon May 31, 2023
As @danielbachhuber pointed out in another conversation, keeping WordPress Playground code under the WordPress organization seems like the most natural choice.
Let's move forward with proposition 1) then. I just moved
wp-nowcode to the https://github.com/WordPress/playground-tools repository in WordPress/playground-tools@bb00e26 where it lives alongside the VS Code extension.This concludes moving applications out of the main Playground repo. If you'd like to house these tools in a different repo than
playground-toolswe can still do that.Remove wp-now from the main repository so it can live in a dedicated …
adamziel commentedon May 31, 2023
As for
I included the link to the previous
wp-nowpackage in the migration commit. The grafted commit mentioned by @dmsnell should allow the consumers of the repo to connect that commit with the playground tree. Otherwise, if you know of any technique that would preserve the history in the GitHub web UI, please share and let's do it.wojtekn commentedon May 31, 2023
Would it work to just copy the repository and remove whatever we don't need in the new one?
danielbachhuber commentedon May 31, 2023
Yes, this is what I was thinking and I think it would be preferable.
Reduce the working tree to applications, keep the framework in https:…
Migrate applications to playground-tools repository
adamziel commentedon May 31, 2023
That's a brilliant idea! The history is back @wojtekn @danielbachhuber : https://github.com/WordPress/playground-tools
danielbachhuber commentedon May 31, 2023
Measure twice, cut once 😊
danielbachhuber commentedon May 31, 2023
I moved all of the
Local EnvironmentandVS Codeissues to https://github.com/WordPress/playground-tools/@adamziel As remaining cleanup, it would be nice to update https://github.com/WordPress/playground-tools/blob/trunk/CONTRIBUTING.md and make sure publishing works. Otherwise, things seem fine on my end.
adamziel commentedon Jun 2, 2023
The CONTRIBUTING docs is now updated, let's close this issue and track anything else that might bubble up separately.