Skip to content

Problems when blogname is set to Chinese #1719

Closed

Description

@2551654928

{ "landingPage": "/wp-admin/", "siteOptions": { "blogname": "KEKC博客" }, "login": true }

Activity

  1. 2551654928 commented on Aug 30, 2024

    @2551654928
    Author
    20240830-114432.mp4
  2. adamziel commented on Aug 30, 2024

    @adamziel
    Collaborator

    Thank you for the report! The problem is likely here:

    It calls just btoa, when it should be calling a utf8-compatible function like this one:

    function bytesToBase64(bytes: Uint8Array) {
    	const binString = String.fromCodePoint(...bytes);
    	return btoa(binString);
    }

    The same goes for each btoa() and atob() call in the codebase. The earliest I'll be able to propose a fix is Thursday, but if you start a PR before then I'll be happy to review.

  3. adamziel commented on Sep 11, 2024

    @adamziel
    Collaborator

    #1731 will solve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions