Skip to content

Update the WordPress packages with Gutenberg 15.1.0 changes - #3914

Closed
youknowriad wants to merge 8 commits into
WordPress:trunkfrom
youknowriad:update/packages-6-2
Closed

youknowriad wants to merge 8 commits into
WordPress:trunkfrom
youknowriad:update/packages-6-2

Conversation

@youknowriad

@youknowriad youknowriad commented Jan 26, 2023 •

Copy link
Copy Markdown
Contributor

This PR updates the WordPress packages with the latest released ones from Gutenberg 15.1.0

While updating the packages, it was necessary to bring the following changes as well:

Trac ticket: https://core.trac.wordpress.org/ticket/57471

@Mamaduka

Mamaduka commented Feb 1, 2023

Copy link
Copy Markdown
Member

I noticed that we have a few methods with the gutenberg_ prefix in the block-library packages. I'm looking into this.

@youknowriad youknowriad changed the title Update the WordPress packages with Gutenberg 15.0.1 changes Update the WordPress packages with Gutenberg 15.1.0 changes Feb 2, 2023
felixarntz pushed a commit to felixarntz/wordpress-develop that referenced this pull request Feb 2, 2023

@felixarntz felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youknowriad Mostly looks good, just one nit-pick and the remaining gutenberg_ prefixes that need to be replaced. Is that something you can just update in this PR or does it require a fix on the Gutenberg side?

Other than that, I assume the intention is to commit this once #3920 has been committed?

Comment thread src/wp-includes/blocks/gallery.php Resolved
Comment thread src/wp-includes/blocks/calendar.php Resolved
Comment thread src/wp-includes/blocks/gallery.php Resolved
@Mamaduka

Mamaduka commented Feb 3, 2023

Copy link
Copy Markdown
Member

@felixarntz, I already fixed gutenberg_ prefix issue in Gutenberg repo. See WordPress/gutenberg#47649.

@ntsekouras and I will start working on package updates that include recent fixes.

@youknowriad

Copy link
Copy Markdown
Contributor Author

Mostly looks good, just one nit-pick and the remaining gutenberg_ prefixes that need to be replaced. Is that something you can just update in this PR or does it require a fix on the Gutenberg side?

Actually, I can't touch these files here, even the nitpicks suggested here because every time someone will do npm install it will revert these changes locally causing confusion. So I think we should instead make a PR to Gutenberg and wait for the next round of package release.

@youknowriad

Copy link
Copy Markdown
Contributor Author

I've just noticed that there's a blocks fixtures tests in Core right now. Anyone know why this test has been moved from Gutenberg to here? It's just going to add maintenance burden for us for a small value since all the code for blocks is coming through package. In other words, these tests are better by their code (in the Gutenberg repo).

@youknowriad

Copy link
Copy Markdown
Contributor Author

Ok I've managed to fix all the failing tests here. It's not perfect but It should be good to land to unblock the PRs that depend on it.

I've noticed a small style glitch on the empty post placeholder. Something to keep an eye on after all the backports.

@felixarntz felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youknowriad LGTM. Would still be nice to address https://github.com/WordPress/wordpress-develop/pull/3914/files#r1095179123, though that is not a blocker.

@youknowriad

Copy link
Copy Markdown
Contributor Author

@felixarntz It needs to be addressed on Gutenberg, that way it comes in the next package update. You can't make changes to these files in Core.

@felixarntz

Copy link
Copy Markdown
Member

@youknowriad Ah right, forgot about that, thanks!

@ntsekouras ntsekouras left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to land this. Thank you Riad!

@youknowriad

Copy link
Copy Markdown
Contributor Author

This has been committed

@youknowriad youknowriad closed this Feb 7, 2023
@youknowriad
youknowriad deleted the update/packages-6-2 branch February 7, 2023 07:03
@Mamaduka

Mamaduka commented Feb 7, 2023

Copy link
Copy Markdown
Member

Thank you, Riad!

The changeset - https://core.trac.wordpress.org/changeset/55246.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants