Skip to content

Require being in Recovery Mode for extensions to be paused. - #38

Closed
TimothyBJacobs wants to merge 1 commit into
WordPress:masterfrom
TimothyBJacobs:46130
Closed

TimothyBJacobs wants to merge 1 commit into
WordPress:masterfrom
TimothyBJacobs:46130

Conversation

@TimothyBJacobs

@TimothyBJacobs TimothyBJacobs commented Jan 29, 2019 •

Copy link
Copy Markdown
Member

@ocean90

ocean90 commented Mar 8, 2020

Copy link
Copy Markdown
Member

Closing as the ticket was fixed a few months ago.

@ocean90 ocean90 closed this Mar 8, 2020
enricocarraro added a commit to enricocarraro/wordpress-develop that referenced this pull request Oct 7, 2020
enricocarraro added a commit to enricocarraro/wordpress-develop that referenced this pull request Oct 15, 2020
ironprogrammer referenced this pull request in ironprogrammer/wordpress-develop Feb 4, 2022
Allows semi-colons in URLs, typically indicative of an HTML entity, such as `&` or `&`.
westonruter pushed a commit to westonruter/wordpress-develop that referenced this pull request Apr 27, 2023
Script Loading Strategy - ML2 WordPress#14 - Update `do_item` method.
HasnainAshfaq added a commit to HasnainAshfaq/wordpress-develop that referenced this pull request Jul 26, 2026
…e when content contains <

When a no-texturize tag (script, pre, code, etc.) contains a raw '<' character
— as in JavaScript like `if(a<b)` — wp_html_split() misidentifies the content
after that '<' as an HTML element delimiter. Previously, the texturize loop
would encode '&' characters in that false delimiter (e.g. '&&' became
'&WordPress#38;&WordPress#38;'), corrupting script content.

Fix: only run the '&' → '&WordPress#38;' substitution when we are not already inside a
no-texturize tag stack. Real HTML tag attributes (e.g. <a href="foo&bar">) are
only encountered at the top level, so the fix does not affect them.

This became more user-visible in WordPress 7.0, which introduced a dedicated
JavaScript panel in the Custom HTML block where users enter code that can
contain '<' comparisons.

Fixes #43785.
westonruter added a commit to westonruter/wordpress-develop that referenced this pull request Sep 27, 2026
`WP_Styles::_css_href()` and `WP_Styles::get_rtl_href()` return URLs
escaped for an HTML attribute, with `&` as `&WordPress#38;`, while
`WP_Scripts::get_src()` returns them unescaped. So the
`prefetch_admin_assets` filter received the two in different forms, and
a callback appending the plain form of a stylesheet URL with more than
one query argument was not collapsed with it, despite what the filter
documents. Decode the stylesheet URLs before building the list. The
printed links are unchanged, since each URL is escaped again when
printed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
westonruter added a commit to westonruter/wordpress-develop that referenced this pull request Oct 6, 2026
The test of stylesheet URLs reaching the `wp_prefetch_admin_assets` filter unescaped had its callback append the plain form of the URL it received, by replacing `&WordPress#38;` with `&`. That dated from when stylesheet URLs reached the filter escaped. They now arrive plain, as the test itself asserts, so the replacement did nothing and the callback appended an identical URL.

The callback now appends the URL escaped with `esc_url()`, as a callback building it that way would, which differs from the plain one in its `&WordPress#38;`. Duplicates are collapsed by the escaped URL, so the two still give one prefetch link, and the test checks that the appended URL really does differ.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
westonruter added a commit to Sukhendu2002/wordpress-develop that referenced this pull request Oct 11, 2026
HTML character references are not decoded in STYLE elements, so the
&WordPress#38; produced by esc_url() for a URL with multiple query parameters
would end up in the CSS literally. Escape with esc_url_raw() instead,
and wrap the URLs in double quotes: esc_url_raw() strips double quotes
but not single quotes or parentheses, so an unquoted url() token could
otherwise be terminated by the URL. Name the variables to make clear
they are already escaped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
robelsust added a commit to robelsust/wordpress-develop that referenced this pull request Oct 12, 2026
Addresses review feedback on PR WordPress#14187 by decoding search queries before entity-encoding them. This ensures queries containing decimal entities (e.g. 'Tour &WordPress#38; Travel') and hexadecimal entities (e.g. 'Tour &#x26; Travel') match term names stored in the database as HTML entities ('Tour &amp; Travel').

Adds dedicated unit tests for decimal and hex numeric entities.

See #66279.
rejaulalomkhan added a commit to rejaulalomkhan/wordpress-develop that referenced this pull request Oct 20, 2026
Keeps the `edit_bookmark_link()` expectations consistent with the
`get_edit_bookmark_link()` ones, with the escaped `&WordPress#38;` kept literal.

See #65819.
nickchomey added a commit to nickchomey/wordpress-develop that referenced this pull request Oct 26, 2026
Reworks the fix per review from westonruter and dmsnell.

get_html_split_regex() and _get_wptexturize_split_regex() now use an
=-aware element pattern. Quotes only become special after "=", so a >
inside a quoted attribute value no longer ends the tag, while
quote-named attributes such as <div "=noquote id="quote"> keep their
previous parse. Unquoted values use [^> \t\f\r\n]*+ as dmsnell
suggested. The trailing >? keeps the "if not found, match all input"
behavior for unclosed tags.

Reverted from the previous version of this PR:
- The &-preserving callback in wptexturize(). & in attribute values is
  encoded as before (browsers decode &WordPress#38; identically).
- Deriving the texturize pattern from get_html_split_regex() via
  substr(). Each function keeps its own pattern, so no CDATA handling
  leaks into wptexturize().
- Changes to existing test expectations for invalid HTML and the REST
  comment roundtrip.
- Type and docblock changes to existing tests, which move to their own
  PR.

#43785 (raw text inside <script>) is not addressed; it needs HTML API
based segmentation.

See #63997, #57381, #63426.
dknauss added a commit to dknauss/wordpress-develop that referenced this pull request Nov 18, 2026
Markup no longer goes through the legacy implementation. Only runs of text
reach it, and only text that changes is replaced, by splicing the changed
spans into the original string, so tags, comments, and character references
keep their bytes.

To match the legacy output, a bare & in a tag still becomes &WordPress#38;, including
in markup the HTML Processor skips without a token, and the contents of an
unprotected raw text element, such as TITLE or TEXTAREA, are texturized.

See #18549.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants