Skip to content

fetch sticky posts with published posts - #16033

Open
sawfly wants to merge 1 commit into
WordPress:trunkfrom
sawfly:55207-exclude-sticky-post-from-status-draft-query
Open

sawfly wants to merge 1 commit into
WordPress:trunkfrom
sawfly:55207-exclude-sticky-post-from-status-draft-query

Conversation

@sawfly

@sawfly sawfly commented Nov 16, 2026

Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/55207

Description

When a WP_Query is treated as the home query (is_home), sticky posts that aren't already in the results are fetched separately with a hard-coded 'post_status' => 'publish' and added to the top of the results. That step runs whatever post_status was requested. So a query such as:

new WP_Query( array( 'post_status' => 'draft' ) );

returns published sticky posts along with the drafts. This was originally reported in wp-cli/entity-command#278.

This PR takes option (a) from comment #8 on the ticket: a query should only return posts with the requested status.

Changes

  • WP_Query::get_posts(): published sticky posts are only fetched when published posts were requested. That means post_status is empty (the default), includes publish, or includes any. The check reuses the already-normalized $q_status, so arrays and comma-separated strings both work.
  • Sticky posts that already matched the query are still moved to the top, so a sticky draft still goes first in a draft query.
  • Nothing changes for the default home query, for queries that include publish or any, or for ignore_sticky_posts.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude (Anthropic)
Model(s): Opus 5.5
Used for: writing patch, tests and PR description; final implementation and tests were reviewed and edited by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sawf1y.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub or WordPress.org user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant