Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Trac ticket: https://core.trac.wordpress.org/ticket/55207
Description
When a
WP_Queryis treated as the home query (is_home), sticky posts that aren't already in the results are fetched separately with a hard-coded'post_status' => 'publish'and added to the top of the results. That step runs whateverpost_statuswas requested. So a query such as:returns published sticky posts along with the drafts. This was originally reported in wp-cli/entity-command#278.
This PR takes option (a) from comment #8 on the ticket: a query should only return posts with the requested status.
Changes
WP_Query::get_posts(): published sticky posts are only fetched when published posts were requested. That meanspost_statusis empty (the default), includespublish, or includesany. The check reuses the already-normalized$q_status, so arrays and comma-separated strings both work.publishorany, or forignore_sticky_posts.Use of AI Tools
AI assistance: Yes
Tool(s): Claude (Anthropic)
Model(s): Opus 5.5
Used for: writing patch, tests and PR description; final implementation and tests were reviewed and edited by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.