Skip to content

Add unset for height and min-height when aspect ratio is defined - #14126

Closed
tellthemachines wants to merge 6 commits into
WordPress:trunkfrom
tellthemachines:fix/height-unset-for-aspect-ratio
Closed

tellthemachines wants to merge 6 commits into
WordPress:trunkfrom
tellthemachines:fix/height-unset-for-aspect-ratio

Conversation

@tellthemachines

Copy link
Copy Markdown
Contributor

Trac ticket: https://core.trac.wordpress.org/ticket/66275

Missed line from a gutenberg sync of WordPress/gutenberg#79135.

Adding test to make sure it doesn't happen again 😅

Use of AI Tools

Test added with copilot/sonnet 5.5


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props isabel_brison, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@tellthemachines tellthemachines self-assigned this Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Comment on lines +909 to +915
preg_match( '/wp-states-[a-f0-9]{8}/', $actual, $matches );
$actual_stylesheet = wp_style_engine_get_stylesheet_from_context( 'block-supports', array( 'prettify' => false ) );

$this->assertStringContainsString(
'@media (width <= 480px){.' . $matches[0] . '{',
$actual_stylesheet
);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something like this would be more robust:

Suggested change
preg_match( '/wp-states-[a-f0-9]{8}/', $actual, $matches );
$actual_stylesheet = wp_style_engine_get_stylesheet_from_context( 'block-supports', array( 'prettify' => false ) );
$this->assertStringContainsString(
'@media (width <= 480px){.' . $matches[0] . '{',
$actual_stylesheet
);
$processor = new WP_HTML_Tag_Processor( $actual );
$this->assertTrue( $processor->next_tag( 'DIV' ) );
$states_class = array_find(
iterator_to_array( $this->class_list() ),
fn ( $class ) => preg_match( '/^wp-states-[a-f0-9]{8}$/', $class )
);
$this->assertIsString( $states_class );
$actual_stylesheet = wp_style_engine_get_stylesheet_from_context( 'block-supports', array( 'prettify' => false ) );
$this->assertStringContainsString(
'@media (width <= 480px){.' . $states_class . '{',
$actual_stylesheet
);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I've updated to use the tag processor instead of relying on matches[0]. There's a bunch of other tests in this file that could be likewise refactored, but that's probably best left to a follow-up.

/**
* Adds a compiled state style rule to a rule list.
*
* @since 7.1.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add a @since to mention the fallback dimension styles added in 7.2.0?

tellthemachines and others added 2 commits October 13, 2026 14:36
Co-authored-by: Weston Ruter <westonruter@gmail.com>
@github-actions

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 64322
GitHub commit: ccf582a

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants