Repository navigation
wp-now: improve php tests and comment failing tests - #43
Merged
Merged
Conversation
Collaborator
|
@sejas I've tried tests locally and they went successfully. I tried uncommenting those from |
wojtekn
self-requested a review
June 1, 2023 10:06
…ectory conflict on Mac Os tests
…ound-tools into update/wp-now-php-tests
…e-use wordpress instance
…date/wp-now-php-tests
Collaborator
Author
|
@wojtekn Thanks for reviewing it! I moved some php tests to The issue we had was that after the |
johnhooks
pushed a commit
to johnhooks/playground-tools
that referenced
this pull request
Oct 11, 2024
Define 'CONCATENATE_SCRIPTS' as false in `wp-config.php` and removes most static assets from the `wp.data` build script. This makes for an incredible size decrease from 44M to 13M. See WordPress#39 and WordPress#2 for more details. Co-authored-by: Adam Zieliński <adam@adamziel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix tests.
Fix Mac Os wp-cli path error.
Fix php tests after playground mode was introduced.
Testing instrucitons
npx nx test wp-now