Skip to content

wp-now: improve php tests and comment failing tests - #43

Merged
sejas merged 8 commits into
trunkfrom
update/wp-now-php-tests
Jun 1, 2023
Merged

sejas merged 8 commits into
trunkfrom
update/wp-now-php-tests

Conversation

@sejas

@sejas sejas commented Jun 1, 2023 •

Copy link
Copy Markdown
Collaborator

What?

Fix tests.
Fix Mac Os wp-cli path error.
Fix php tests after playground mode was introduced.

Testing instrucitons

  • Run npx nx test wp-now
  • Tests should pass.

@sejas sejas added the wp-now label Jun 1, 2023
@sejas sejas self-assigned this Jun 1, 2023
@wojtekn

wojtekn commented Jun 1, 2023

Copy link
Copy Markdown
Collaborator

@sejas I've tried tests locally and they went successfully.

I tried uncommenting those from execute-php.spec.ts and now they still work fine. It crashes for me only when I uncomment 'wp-cli command' tests.

@wojtekn
wojtekn self-requested a review June 1, 2023 10:06

@wojtekn wojtekn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great finding @sejas ! We may remove two unnecessary imports from packages/wp-now/src/tests/execute-php.spec.ts and should be good to go.

@sejas sejas changed the title WIP: wp-now: improve php tests and comment failing tests wp-now: improve php tests and comment failing tests Jun 1, 2023
@sejas

sejas commented Jun 1, 2023 •

Copy link
Copy Markdown
Collaborator Author

@wojtekn Thanks for reviewing it!

I moved some php tests to wp-now.spec.ts and deleted the unnecessary imports.

The issue we had was that after the playground mode was introduced, the php tests competed with wp-now.spec.ts tests to download WordPress returning random errors.

@sejas
sejas merged commit fa50062 into trunk Jun 1, 2023
@sejas
sejas deleted the update/wp-now-php-tests branch June 1, 2023 12:11
johnhooks pushed a commit to johnhooks/playground-tools that referenced this pull request Oct 11, 2024
Define 'CONCATENATE_SCRIPTS' as false in `wp-config.php` and removes most static assets from the `wp.data` build script. This makes for an incredible size decrease from 44M to 13M. See WordPress#39 and WordPress#2 for more details.

Co-authored-by: Adam Zieliński <adam@adamziel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants