Repository navigation
Format existing code files and exclude playground/vendor - #163
Conversation
danielbachhuber
left a comment
There was a problem hiding this comment.
I was running into this when working on #161 this morning.
Is there a reason we don't run a linter in CI?
|
@sejas should we move the packages/playground/phpcs.xml file to the root folder? |
Yes, I think it makes sense to have a unique phpcs.xml at the root directory. I moved it here 7073a53
The project is not 100% well configured and the linter doesn't throw any error, but prettier format the files. I also added |
What?
On #154 we added the playground plugin with multiple vendor files that
npx nx formatwas formatting after each push.This PR format existing code files and excludes those in vendor.
.nx/cahcefrom gitpackage/playground/phpcs.xmlto the root directoryWhy?
It's better to keep consistency with formatting tools.
How?
I executed
npx nx format.Testing Instructions