Skip to content

Picture element: The accurate sizes improvement for images not working #1349

Closed

Description

@mukeshpanchal27

Bug Description

The accurate sizes improvement done in #1329 not working for Picture elements.

Steps to reproduce

  1. Activate the Modern Image Formats plugin and enable picture support from the Media Settings screen.
  2. Install and activate Enhanced Responsive Images (formally known as auto-sizes)
  3. Add image block with none alignment
  4. The image tag get proper sizes value but source didn't.

Screenshots

Screenshot 2024-07-16 at 5 19 19 PM

Activity

  1. moved this to Definition ✏️ in WP Performance Ongoingon Jul 16, 2024
  2. mukeshpanchal27 commented on Jul 17, 2024

    @mukeshpanchal27
    MemberAuthor

    @adamsilverstein @westonruter @joemcgill Seems like it's an issue from the Enhanced Responsive Images (auto-sizes) plugin as we update sizes only for the IMG tag, and it is working fine (check description screenshot). For the <picture> element, we have to update the logic to account for it.

    Self assign.

  3. moved this from Definition ✏️ to Code Review 👀 in WP Performance Ongoingon Jul 17, 2024
  4. moved this from Code Review 👀 to In Progress 🚧 in WP Performance Ongoingon Jul 18, 2024
  5. moved this from In Progress 🚧 to Code Review 👀 in WP Performance Ongoingon Jul 19, 2024
  6. moved this from Code Review 👀 to In Progress 🚧 in WP Performance Ongoingon Jul 23, 2024
  7. moved this from In Progress 🚧 to Code Review 👀 in WP Performance Ongoingon Jul 24, 2024
  8. moved this from Code Review 👀 to Done 😃 in WP Performance Ongoingon Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions