Skip to content

Fix: Prepublish text for scheduled posts - #9986

Merged
sarahmonster merged 1 commit into
WordPress:masterfrom
cristian-raiber:fix/prepublish-text-for-scheduled-posts
Sep 19, 2018
Merged

sarahmonster merged 1 commit into
WordPress:masterfrom
cristian-raiber:fix/prepublish-text-for-scheduled-posts

Conversation

@cristian-raiber

@cristian-raiber cristian-raiber commented Sep 18, 2018 •

Copy link
Copy Markdown
Contributor

Description

Fixes #9960.
When scheduling a new post, the text displayed in the prepublish panel was a little misleading to the user:
1

This fix adds a more appropriate message:
2

How has this been tested?

I created a new post, scheduled it at a later date and clicked the 'Schedule' button: the above message appears.

Types of changes

It introduces two variables prePublishTitle and prePublishBodyText which get assigned depending on the publish date or if the user is a contributor.

@Soean Soean added [Type] Copy Issues or PRs that need copy editing assistance Needs Copy Review Needs review of user-facing copy (language, phrasing) labels Sep 18, 2018
@michelleweber

Copy link
Copy Markdown

You could just change "publish" to "schedule" in the original message and it would be accurate, no?

@sarahmonster

Copy link
Copy Markdown
Member

+1 for this change overall, but "ready to schedule" feels a bit awkward. We may want to reconsider this in a larger context. This text currently shows one of three variants:

"(Are you) ready to publish?"
"(Are you) ready to schedule?"
"(Are you) ready to submit for review?"

One option would be to nix the differentiation altogether, and opt for something generic, like "Are you ready?" or "Ready to go?", or even just "Pre-publish check" to reinforce the language we're using for this panel and its associated setting.

Another option might be to nix the question bit altogether, so the title becomes an instruction: "Publish", "Schedule", "Submit for review". It's a bit simpler and clearer this way, and avoids some of the awkwardness that pops up in the latter two instances.

See also minor copy changes here to be introduced in #9398 ("Are you ready to publish?" -> "Ready to publish?")

@michelleweber

Copy link
Copy Markdown

FWIW, I'd vote for something that keeps the differentiation, because I think the specificity in the headline helps create confidence in the user that they're doing the thing the intended to do. (I also don't find "ready to schedule" terribly awkward, but that's just me.)

@jorgefilipecosta jorgefilipecosta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good from the code point of view 👍

@sarahmonster sarahmonster left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@sarahmonster

Copy link
Copy Markdown
Member

Let's go ahead and merge this in then, and we can iterate as/if needed in #9398. I could be overthinking things. 🧐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Copy Review Needs review of user-facing copy (language, phrasing) [Type] Copy Issues or PRs that need copy editing assistance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When scheduling a post, misleading copy related to publishing is displayed

5 participants