Skip to content

feat: Save data offline (close #7367) - #9383

Closed
tofumatt wants to merge 1 commit into
masterfrom
try/save-data-offline-7367
Closed

tofumatt wants to merge 1 commit into
masterfrom
try/save-data-offline-7367

Conversation

@tofumatt

Copy link
Copy Markdown
Member

Experimental and still a work-in-progress.

Description

Experiment to save data offline for autosaves and saves when there is no network connection.

That part works and the UI doesn't complain about failures, but we'll likely want to:

  • Allow a restore from local content
  • Hook the data storage into WP Data instead of just accessing localForage directly

How has this been tested?

Locally in Firefox only so far; it may not work in other browsers as the off-line check relies on the error message in the Fetch API… and I'm not sure they're consistent across browsers.

Screenshots

Coming later...

Types of changes

This is a new feature and part of #6322.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@tofumatt tofumatt added the [Status] In Progress Tracking issues with work in progress label Aug 28, 2018
@tofumatt tofumatt self-assigned this Aug 28, 2018

describe( 'storage', () => {
it( 'should work', () => {
expect( true ).toEqual( true );

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs more love 😺

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I mean, it passes! 🤪

@tofumatt
tofumatt force-pushed the try/save-data-offline-7367 branch from 0dcdba8 to 0ce9063 Compare November 20, 2018 15:16
@mtias mtias added the [Feature] Offline Related to offline editing label Nov 20, 2018
@gziolo gziolo added [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. and removed [Status] In Progress Tracking issues with work in progress labels Apr 24, 2019
@gziolo

gziolo commented Apr 24, 2019

Copy link
Copy Markdown
Member

I don't think @tofumatt still works on this PR. @mtias and @youknowriad what's the plan for this feature?

@aduth

aduth commented Apr 24, 2019

Copy link
Copy Markdown
Member

I think it'll be something to revisit and this could serve as prior art, but the specific implementation will need considerable revisions to account for more recent refactorings to eliminate post effects (#13716).

I'd suggest it be closed with continued discussion to take place at the associated issue #6322.

@aduth aduth closed this Apr 24, 2019
@aduth
aduth deleted the try/save-data-offline-7367 branch April 24, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Offline Related to offline editing [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants