Skip to content

Button: Align pressed colors and simplify Toolbar overrides - #86684

Merged
ciampo merged 3 commits into
trunkfrom
codex/button-pressed-colors
Nov 13, 2026
Merged

ciampo merged 3 commits into
trunkfrom
codex/button-pressed-colors

Conversation

@ciampo

@ciampo ciampo commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Follows #86683 and continues the Button color changes from #85073. The busy spinner is tracked in #85960.

What?

Use paired WPDS colors for pressed Buttons and their Toolbar, editor and Widgets compositions.

Why?

Fixed foreground and fill overrides can produce unreadable pressed controls in dark or custom themes.

How?

Use paired neutral WPDS colors for pressed Buttons. Numbered Toolbar icons inherit the Button foreground. The block toolbar paints its fill behind the icon, while the editor, Widgets, and Customizer headers fill the whole button. Disabled pressed Buttons keep their busy stripes.

Pressed colors now follow ThemeProvider, like the ordinary colors in the preceding PR.

Testing Instructions

  1. Run npm run storybook:e2e:dev and open Button → Variant States. Compare all variants with pressed, destructive, busy and disabled props in light, dark and custom orange themes.
  2. Hover pressed controls and check that foreground and fill stay paired. Repeat with native and focusable disabled controls.
  3. In the post editor, select a paragraph, toggle Bold and open the Block Inserter. The block-toolbar fill should remain inset; the header inserter should keep its full fill.
  4. With Twenty Twenty-One, open Widgets and the Customizer’s Widgets → Footer panel. Toggle their inserters and check the pressed fill and icon color.
  5. With forced colors enabled, check that pressed controls retain system selection colors and disabled controls use the system disabled colors.

Testing Instructions for Keyboard

Tab to a pressed control, move the pointer away, and hold Space. Its foreground and fill should remain paired. Repeat with busy controls. Focusable disabled controls should retain their disabled appearance and remain unavailable for activation.

Screenshots or screencast

Compared trunk 16bb8f905d2 with 2961c9a81d7 in Chromium.

Pressed controls in a dark theme

The post editor and Widgets inserter icons become visible against their new fill. The numbered icon and its subscript share a foreground. The primary Button keeps its text readable on hover, and disabled busy Buttons retain their stripes. These examples use the production components inside a dark ThemeProvider.

Control Before After
Post editor, Widgets, and Customizer inserters Post editor, Widgets, and Customizer inserters on trunk Post editor, Widgets, and Customizer inserters in this PR
Numbered Toolbar icon Numbered Toolbar icon on trunk Numbered Toolbar icon in this PR
Primary and secondary Buttons · hover, disabled, and disabled busy Primary and secondary Buttons · hover, disabled, and disabled busy on trunk Primary and secondary Buttons · hover, disabled, and disabled busy in this PR

Controls in the running editors

Bold is active in the paragraph toolbar. Each inserter is open. The header buttons keep their full fill and Bold keeps its inset fill. All four crops use the same default editor colors and scale.

Control Before After
Block toolbar · Bold Block toolbar · Bold on trunk Block toolbar · Bold in this PR
Post editor · Block Inserter Post editor · Block Inserter on trunk Post editor · Block Inserter in this PR
Widgets · Block Inserter Widgets · Block Inserter on trunk Widgets · Block Inserter in this PR
Customizer · Add block Customizer · Add block on trunk Customizer · Add block in this PR
Full editor views

The post editor, Widgets screen, and Customizer use the same Twenty Twenty-One test site at 1280 × 900. Each view loads the compiled styles from its revision.

Control Before After
Post editor Post editor on trunk Post editor in this PR
Widgets Widgets on trunk Widgets in this PR
Customizer Customizer on trunk Customizer in this PR
Light theme · pressed Button variants and interactions

Each row combines the pressed state with destructive, busy, native disabled, or focusable disabled props. Columns show all five Button variants. Hover, focus, and active are browser-forced CSS states. The keyboard check uses a real Space keypress.

State Trunk (left) and PR (right)
Rest Light theme, rest, trunk on the left and PR on the right
Hover Light theme, hover, trunk on the left and PR on the right
Focus Light theme, focus, trunk on the left and PR on the right
Active Light theme, active, trunk on the left and PR on the right
Dark theme · pressed Button variants and interactions

Each row combines the pressed state with destructive, busy, native disabled, or focusable disabled props. Columns show all five Button variants. Hover, focus, and active are browser-forced CSS states. The keyboard check uses a real Space keypress.

State Trunk (left) and PR (right)
Rest Dark theme, rest, trunk on the left and PR on the right
Hover Dark theme, hover, trunk on the left and PR on the right
Focus Dark theme, focus, trunk on the left and PR on the right
Active Dark theme, active, trunk on the left and PR on the right
Custom cream and orange theme · pressed Button variants and interactions

Each row combines the pressed state with destructive, busy, native disabled, or focusable disabled props. Columns show all five Button variants. Hover, focus, and active are browser-forced CSS states. The keyboard check uses a real Space keypress.

State Trunk (left) and PR (right)
Rest Custom cream and orange theme, rest, trunk on the left and PR on the right
Hover Custom cream and orange theme, hover, trunk on the left and PR on the right
Focus Custom cream and orange theme, focus, trunk on the left and PR on the right
Active Custom cream and orange theme, active, trunk on the left and PR on the right
Chromium forced-colors emulation · pressed Button variants and interactions

Each row combines the pressed state with destructive, busy, native disabled, or focusable disabled props. Columns show all five Button variants. Hover, focus, and active are browser-forced CSS states. The keyboard check uses a real Space keypress.

State Trunk (left) and PR (right)
Rest Chromium forced-colors emulation, rest, trunk on the left and PR on the right
Hover Chromium forced-colors emulation, hover, trunk on the left and PR on the right
Focus Chromium forced-colors emulation, focus, trunk on the left and PR on the right
Active Chromium forced-colors emulation, active, trunk on the left and PR on the right

Use of AI Tools

Implemented with Codex, including independent local agent review and one-off browser checks. No tests were added.

@ciampo ciampo added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Nov 11, 2026
@github-actions github-actions Bot added [Package] Editor /packages/editor [Package] Edit Widgets /packages/edit-widgets labels Nov 11, 2026
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

🤖 PR meta 🤖

Preview in WordPress Playground Preview in Storybook

🎉 Props

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Updated as activity occurs, without notifying anyone named here. Add the props-bot label to refresh.

📦 Bundle size

Size Change: +872 B (+0.01%)

Total Size: 8.65 MB

📦 View Changed
Filename Size Change
build/styles/components/style-rtl.css 18.1 kB +27 B (+0.15%)
build/styles/components/style-rtl.min.css 15.2 kB +23 B (+0.15%)
build/styles/components/style.css 18.2 kB +17 B (+0.09%)
build/styles/components/style.min.css 15.2 kB +14 B (+0.09%)
build/styles/customize-widgets/style-rtl.css 3.07 kB +107 B (+3.61%)
build/styles/customize-widgets/style-rtl.min.css 2.04 kB +101 B (+5.21%) 🔍
build/styles/customize-widgets/style.css 3.06 kB +105 B (+3.55%)
build/styles/customize-widgets/style.min.css 2.04 kB +101 B (+5.21%) 🔍
build/styles/edit-widgets/style-rtl.css 5.38 kB +53 B (+0.99%)
build/styles/edit-widgets/style-rtl.min.css 3.97 kB +54 B (+1.38%)
build/styles/edit-widgets/style.css 5.38 kB +54 B (+1.01%)
build/styles/edit-widgets/style.min.css 3.97 kB +54 B (+1.38%)
build/styles/editor/style-rtl.css 31.7 kB +41 B (+0.13%)
build/styles/editor/style-rtl.min.css 27.5 kB +40 B (+0.15%)
build/styles/editor/style.css 31.7 kB +41 B (+0.13%)
build/styles/editor/style.min.css 27.5 kB +40 B (+0.15%)

d6c6970 Run

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric f3370af trunk % Change
timeToFirstByte 56.6 ms +3.89% -7.16% 55.6 ms +3.51% -3.87% 1.8%
largestContentfulPaint 92 ms +4.35% -6.52% 88 ms +4.55% -4.55% 4.55%
lcpMinusTtfb 31.55 ms +26.78% -6.81% 29.45 ms +26.15% -6.28% 7.13%
wpBeforeTemplate 29.12 ms +4.7% -3.06% 29.04 ms +5.89% -3.48% 0.28%
wpTemplate 21.91 ms +5.71% -5.25% 21.92 ms +3.7% -3.06% -0.05%
wpTotal 52.19 ms +5.29% -6.28% 51.62 ms +4.3% -3.64% 1.1%
wpMemoryUsage 7.75 MB +0% -0% 7.71 MB +0% -0% 0.45%
wpDbQueries 16 +0% -0% 16 +0% -0% 0%

front-end-classic-theme

Metric f3370af trunk % Change
timeToFirstByte 47.75 ms +8.38% -5.86% 45.4 ms +8.26% -1.54% 5.18%
largestContentfulPaint 84 ms +4.76% -4.76% 80 ms +5% -2.5% 5%
lcpMinusTtfb 35.35 ms +4.67% -1.7% 34.3 ms +3.06% -6.27% 3.06%
wpBeforeTemplate 26.65 ms +11.48% -2.14% 25.99 ms +8.04% -1.19% 2.54%
wpTemplate 16.65 ms +6.55% -3.96% 16.02 ms +6.62% -2.31% 3.93%
wpTotal 44.07 ms +9.21% -4.47% 42.06 ms +8.87% -1.5% 4.78%
wpMemoryUsage 6.44 MB +0% -0% 6.40 MB +0% -0% 0.56%
wpDbQueries 13 +0% -0% 13 +0% -0% 0%

media-processing

Metric f3370af trunk % Change
mediaProcessingJpeg 400.02 ms +1.33% -0.36% 401.04 ms +1.25% -0.76% -0.25%
mediaProcessingAvif 6137.3 ms +0.58% -0.37% 6158.8 ms +0.59% -0.57% -0.35%
mediaProcessingJpegToAvif 4234.89 ms +0.61% -0.35% 4233.47 ms +0.04% -0.05% 0.03%

media-upload

Metric f3370af trunk % Change
jpegUploadProcessing 1976.93 ms +2.95% -22.82% 1510.17 ms +30.87% -0.6% 30.91%
pngUploadProcessing 280.09 ms +1.6% -2.83% 270.93 ms +4.58% -1.18% 3.38%
largeJpegUploadProcessing 1507.25 ms +30.41% -1.33% 1519.37 ms +28.65% -0.6% -0.8%
multipleImageUploadProcessing 2093.11 ms +0.53% -1.58% 2088.69 ms +2.07% -6.73% 0.21%

post-editor

Metric f3370af trunk % Change
serverResponse 476.36 ms +6.75% -7.82% 461.31 ms +4.93% -6.6% 3.26%
firstPaint 458.45 ms +10.69% -2.54% 402.18 ms +11.9% -3.73% 13.99%
domContentLoaded 832.4 ms +10.19% -2.81% 800.83 ms +1.56% -0.81% 3.94%
loaded 833.57 ms +10.17% -2.84% 801.85 ms +1.56% -0.83% 3.96%
firstContentfulPaint 480.58 ms +14.82% -3.4% 457.82 ms +1.45% -1.7% 4.97%
firstBlock 2213.55 ms +5.05% -1.44% 2150.73 ms +2.95% -1.88% 2.92%
type 21.86 ms +13.27% -5.63% 15.99 ms +5.75% -7.63% 36.71%
typeWithoutInspector 24.3 ms +8.72% -19.96% 16.11 ms +4.97% -7.39% 50.84%
typeWithTopToolbar 21.57 ms +11.27% -12.15% 21 ms +7.38% -4.24% 2.71%
typeContainer 8.18 ms +13.69% -9.54% 7.56 ms +8.2% -8.6% 8.2%
focus 122.49 ms +2.35% -6.19% 115.42 ms +2.8% -5.16% 6.13%
firstFocus 264.64 ms +0% -0% 259.56 ms +0% -0% 1.96%
selectAll 406.77 ms +4.68% -3.84% 421.71 ms +0.84% -2.32% -3.54%
undo 27.09 ms +5.46% -5.13% 28.51 ms +3.3% -6.91% -4.98%
listViewOpen 79.28 ms +20.32% -8.64% 74.4 ms +11.8% -14.33% 6.56%
inserterOpen 42.65 ms +6.82% -14.87% 40.93 ms +3.69% -6.11% 4.2%
inserterHover 10.53 ms +16.33% -9.21% 10.78 ms +5.1% -3.53% -2.32%
inserterSearch 8.38 ms +9.07% -12.53% 8.42 ms +5.34% -12.23% -0.48%
loadPatterns 638.63 ms +6.59% -7.06% 627.94 ms +3.43% -4.26% 1.7%
wpTotal 466.42 ms +6.93% -7.99% 451.67 ms +5.03% -6.73% 3.27%
wpMemoryUsage 14.81 MB +0% -0% 14.77 MB +0% -0% 0.25%
wpDbQueries 55 +0% -0% 55 +0% -0% 0%

site-editor

Metric f3370af trunk % Change
serverResponse 479.67 ms +0.27% -9.56% 477.88 ms +0.73% -6.63% 0.37%
firstPaint 437.54 ms +16.51% -10.55% 389.13 ms +3.42% -4.89% 12.44%
domContentLoaded 842.56 ms +3.2% -0.67% 838.73 ms +2.46% -0.11% 0.46%
loaded 843.73 ms +3.21% -0.67% 840.05 ms +2.42% -0.16% 0.44%
firstContentfulPaint 475.74 ms +7.15% -1.2% 468.37 ms +1.77% -1.84% 1.57%
firstBlock 2606.61 ms +6.77% -0.58% 2602.47 ms +1.36% -2.34% 0.16%
type 17.4 ms +3.97% -8.39% 17.39 ms +12.88% -6.33% 0.06%
navigate 131.26 ms +7.09% -4.94% 118.58 ms +9.82% -5.55% 10.69%
loadPatterns 1466.07 ms +8.76% -10.54% 1348.58 ms +9.67% -18.27% 8.71%
loadPages 988.71 ms +2.55% -0.96% 967.32 ms +2.18% -2.01% 2.21%
wpTotal 469.77 ms +0.36% -9.68% 468.33 ms +0.66% -6.8% 0.31%
wpMemoryUsage 12.82 MB +0% -0% 12.79 MB +0% -0% 0.25%
wpDbQueries 45 +0% -0% 45 +0% -0% 0%

d6c6970 Run

🏁 Flaky tests

Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

Navigates the list via UP/DOWN arrow keys from action buttons in /test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js, passed after 1 failed attempt.
Error: expect(locator).toBeFocused() failed

Locator:  getByRole('row', { name: 'Page Two Edit Actions' }).getByRole('button', { name: 'Edit' })
Expected: focused
Received: inactive
Timeout:  5000ms

Call log:
  - Expect "toBeFocused" getByRole('row', { name: 'Page Two Edit Actions' }).getByRole('button', { name: 'Edit' }) with timeout 5000ms
  - waiting for getByRole('row', { name: 'Page Two Edit Actions' }).getByRole('button', { name: 'Edit' })
    14 × locator resolved to <button type="button" tabindex="-1" class="components-button is-small" id="view-list-0-172-primary-action-edit-post">Edit</button>
       - unexpected value "inactive"

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js:243:5
Overlay menu interactions in Safari (@WebKit) in /test/e2e/specs/editor/blocks/navigation-frontend-interactivity.spec.js, passed after 1 failed attempt.
TimeoutError: locator.click: Timeout 10000ms exceeded.
Call log:
  - waiting for getByRole('region', { name: 'Editor top bar' }).getByRole('button', { name: 'Save', exact: true })
    - locator resolved to <button type="button" aria-disabled="true" class="components-button editor-post-publish-button editor-post-publish-button__button is-primary is-compact">Save</button>
  - attempting click action
    2 × waiting for element to be visible, enabled and stable
      - element is not enabled
    - retrying click action
    - waiting 20ms
    2 × waiting for element to be visible, enabled and stable
      - element is not enabled
    - retrying click action
      - waiting 100ms
    15 × waiting for element to be visible, enabled and stable
       - element is not enabled
     - retrying click action
       - waiting 500ms

    at Editor.saveSiteEditorEntities (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/editor/site-editor.ts:39:22)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation-frontend-interactivity.spec.js:39:4
Undo restores the post selection when another synced entity is loaded (RTC WebSocket) in /test/e2e/specs/editor/collaboration/collaboration-undo-redo.spec.ts, passed after 1 failed attempt.
Error: expect(received).toMatchObject(expected)

- Expected  - 2
+ Received  + 2

  Object {
    "attributeKey": "content",
    "blockIndex": 0,
    "content": "abcdef",
-   "endOffset": 3,
-   "offset": 3,
+   "endOffset": 6,
+   "offset": 6,
  }

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/collaboration/collaboration-undo-redo.spec.ts:363:5
can apply custom colors in /test/e2e/specs/editor/blocks/buttons.spec.js, passed after 1 failed attempt.
Error: expect(received).toBe(expected) // Object.is equality

- Expected  - 2
+ Received  + 2

  <!-- wp:buttons -->
- <div class="wp-block-buttons"><!-- wp:button {"style":{"color":{"text":"#ff0000","background":"#00ff00"},"elements":{"link":{"color":{"text":"#ff0000"}}}}} -->
+ <div class="wp-block-buttons"><!-- wp:button {"style":{"color":{"text":"#ff0000","background":"#0000ff"},"elements":{"link":{"color":{"text":"#ff0000"}}}}} -->
- <div class="wp-block-button"><a class="wp-block-button__link has-text-color has-background has-link-color wp-element-button" style="color:#ff0000;background-color:#00ff00">Content</a></div>
+ <div class="wp-block-button"><a class="wp-block-button__link has-text-color has-background has-link-color wp-element-button" style="color:#ff0000;background-color:#0000ff">Content</a></div>
  <!-- /wp:button --></div>
  <!-- /wp:buttons -->
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/buttons.spec.js:374:21
does not select blocks in the canvas preview when editing from the sidebar (Site Editor v2) in /test/e2e/specs/site-editor/navigation-sidebar-list-view.spec.js, passed after 1 failed attempt.
Error: expect(locator).toBeFocused() failed

Locator: getByRole('combobox', { name: 'Search or type URL' })
Expected: focused
Timeout: 5000ms
Error: element(s) not found

Call log:
  - Expect "toBeFocused" getByRole('combobox', { name: 'Search or type URL' }) with timeout 5000ms
  - waiting for getByRole('combobox', { name: 'Search or type URL' })

    at LinkControl.useLinkControlSearch (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/navigation-sidebar-list-view.spec.js:416:47)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/navigation-sidebar-list-view.spec.js:179:21
keeps the default tab on the moved tab in /test/e2e/specs/editor/blocks/tabs.spec.js, passed after 1 failed attempt.
Error: expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/tabs.spec.js:359:60
page-list submenu user interactions in /test/e2e/specs/editor/blocks/navigation-frontend-interactivity.spec.js, passed after 1 failed attempt.
TimeoutError: locator.click: Timeout 10000ms exceeded.
Call log:
  - waiting for getByRole('region', { name: 'Editor top bar' }).getByRole('button', { name: 'Save', exact: true })
    - locator resolved to <button type="button" aria-disabled="true" class="components-button editor-post-publish-button editor-post-publish-button__button is-primary is-compact">Save</button>
  - attempting click action
    2 × waiting for element to be visible, enabled and stable
      - element is not enabled
    - retrying click action
    - waiting 20ms
    2 × waiting for element to be visible, enabled and stable
      - element is not enabled
    - retrying click action
      - waiting 100ms
    16 × waiting for element to be visible, enabled and stable
       - element is not enabled
     - retrying click action
       - waiting 500ms

    at Editor.saveSiteEditorEntities (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/editor/site-editor.ts:39:22)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation-frontend-interactivity.spec.js:598:4
should apply a named font size using the font size buttons in /test/e2e/specs/editor/various/font-size-picker.spec.js, passed after 1 failed attempt.
Error: expect(received).toBe(expected) // Object.is equality

- Expected  - 2
+ Received  + 2

- <!-- wp:paragraph {"fontSize":"large"} -->
+ <!-- wp:paragraph {"fontSize":"medium"} -->
- <p class="has-large-font-size">Paragraph to be made "large"</p>
+ <p class="has-medium-font-size">Paragraph to be made "large"</p>
  <!-- /wp:paragraph -->

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/font-size-picker.spec.js:153:6
should reset a named font size using the tools panel menu in /test/e2e/specs/editor/various/font-size-picker.spec.js, passed after 1 failed attempt.
Error: expect(received).toBe(expected) // Object.is equality

- Expected  - 2
+ Received  + 2

- <!-- wp:paragraph {"fontSize":"medium"} -->
+ <!-- wp:paragraph {"fontSize":"small"} -->
- <p class="has-medium-font-size">Paragraph with font size reset using tools panel menu</p>
+ <p class="has-small-font-size">Paragraph with font size reset using tools panel menu</p>
  <!-- /wp:paragraph -->

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/font-size-picker.spec.js:178:6

d6c6970 Run

@ciampo ciampo self-assigned this Nov 11, 2026
@ciampo
ciampo force-pushed the codex/button-semantic-colors branch 2 times, most recently from 03bff48 to 7477255 Compare November 12, 2026 17:12
Base automatically changed from codex/button-semantic-colors to trunk November 12, 2026 17:42
@ciampo
ciampo force-pushed the codex/button-pressed-colors branch from 3e176a7 to 2961c9a Compare November 12, 2026 18:10
@ciampo
ciampo requested a review from a team November 12, 2026 18:33
@ciampo
ciampo marked this pull request as ready for review November 12, 2026 18:33
@ciampo
ciampo requested a review from a team as a code owner November 12, 2026 18:33
@ciampo
ciampo requested a balanced review from Copilot November 12, 2026 18:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the pressed-control color alignment changes.

No open issues 🎉

What changed in this PR

Continues the Button color alignment work by using paired WordPress Design System colors for pressed controls and their Toolbar and header compositions.

Changes:

  • Align pressed Button foregrounds and fills across themes and interaction states, including disabled busy controls.
  • Preserve inset Toolbar fills and let numbered icons inherit the Button foreground.
  • Update editor, Widgets, and Customizer header colors and package changelogs.
File Description
packages/​editor/​src/​components/​document-tools/​style.scss Uses theme-aware pressed and disabled header fills.
packages/​editor/​CHANGELOG.md Records the document-tool color fix.
packages/​edit-widgets/​src/​components/​header/​style.scss Aligns pressed and disabled Widgets header fills.
packages/​edit-widgets/​CHANGELOG.md Records the Widgets header color fix.
packages/​customize-widgets/​src/​components/​header/​style.scss Aligns header colors and adds disabled forced-colors styling.
packages/​customize-widgets/​CHANGELOG.md Records the Customizer header color fixes.
packages/​components/​src/​toolbar/​toolbar/​style.scss Uses the Button’s pressed background for inset fills.
packages/​components/​src/​toolbar/​toolbar-button/​style.scss Removes the fixed white subscript color.
packages/​components/​src/​button/​style.scss Pairs pressed colors and preserves disabled busy stripes.
packages/​components/​CHANGELOG.md Records the Button and Toolbar color fixes.

Review effort: Balanced

@jasmussen

Copy link
Copy Markdown
Contributor

Seems fine from just a glance, though it also seems like the numbered toolbar item either needs deprecation or a revisit. Separate, sure.

@ciampo

ciampo commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

For sure Toolbar needs separate attention - from deprecations (as you mentioned), to a potential new coat of paint (as @jameskoster explored), and technically we'll need to create a new Toolbar equivalent in @wordpress/ui.

@jameskoster jameskoster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
github-actions Bot requested a review from aduth November 13, 2026 15:03
@ciampo
ciampo enabled auto-merge (squash) November 13, 2026 15:14
@ciampo
ciampo merged commit dc604c1 into trunk Nov 13, 2026
85 checks passed
@ciampo
ciampo deleted the codex/button-pressed-colors branch November 13, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Components /packages/components [Package] Edit Widgets /packages/edit-widgets [Package] Editor /packages/editor [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants