Skip to content

Cover: Update incorrect icon footprint. - #86420

Merged
jasmussen merged 2 commits into
trunkfrom
update/cover-icon
Nov 6, 2026
Merged

jasmussen merged 2 commits into
trunkfrom
update/cover-icon

Conversation

@jasmussen

Copy link
Copy Markdown
Contributor

What?

I randomly realised the Cover icon had the wrong square icon footprint:

Skærmbillede 2026-11-06 kl  08 44 59 Skærmbillede 2026-11-06 kl  08 45 37 Skærmbillede 2026-11-06 kl  08 49 25

All the square shapes should be the same size. This PR fixes that.

This change also adds a stroke to the ribbon, so when stroke size changes, so does the emphasis of the ribbon.

Testing Instructions

npm run storybook:dev

Use of AI Tools

Only for normalisation, and only until #85272 lands—in case you'd like to review that one.

@jasmussen
jasmussen requested a review from a team November 6, 2026 08:10
@jasmussen jasmussen self-assigned this Nov 6, 2026
@jasmussen jasmussen added [Type] Enhancement A suggestion for improvement. [Package] Icons /packages/icons labels Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

🤖 PR meta 🤖

Preview in WordPress Playground Preview in Storybook

🎉 Props

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Updated as activity occurs, without notifying anyone named here. Add the props-bot label to refresh.

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric 656fed9 trunk % Change
timeToFirstByte 49.9 ms +4.61% -3.11% 50.95 ms +2.26% -5.2% -2.06%
largestContentfulPaint 84 ms +7.14% -4.76% 84 ms +7.14% -4.76% 0%
lcpMinusTtfb 34.15 ms +5.27% -6.15% 32.45 ms +13.71% -3.24% 5.24%
wpBeforeTemplate 24.87 ms +4.7% -1.97% 25.04 ms +2.6% -1.72% -0.68%
wpTemplate 20.45 ms +5.13% -2.93% 21.17 ms +4.39% -7.09% -3.4%
wpTotal 45.79 ms +5.28% -3.19% 46.96 ms +2.43% -5.34% -2.49%
wpMemoryUsage 7.72 MB +0% -0% 7.68 MB +0% -0% 0.42%
wpDbQueries 16 +0% -0% 16 +0% -0% 0%

front-end-classic-theme

Metric 656fed9 trunk % Change
timeToFirstByte 41.15 ms +1.58% -3.04% 41.5 ms +5.78% -1.45% -0.84%
largestContentfulPaint 92 ms +4.35% -0% 92 ms +4.35% -0% 0%
lcpMinusTtfb 52.7 ms +3.32% -3.51% 51.4 ms +0.78% -1.75% 2.53%
wpBeforeTemplate 21.7 ms +2.44% -1.24% 21.76 ms +5.06% -1.88% -0.28%
wpTemplate 15.63 ms +5.05% -4.29% 16.38 ms +2.63% -2.75% -4.58%
wpTotal 37.75 ms +2.07% -3.79% 38.37 ms +5.53% -2.14% -1.62%
wpMemoryUsage 6.41 MB +0% -0% 6.37 MB +0% -0% 0.52%
wpDbQueries 13 +0% -0% 13 +0% -0% 0%

media-processing

Metric 656fed9 trunk % Change
mediaProcessingJpeg 402.87 ms +0.55% -0.69% 401.35 ms +2.2% -0.44% 0.38%
mediaProcessingAvif 5871.68 ms +0.65% -0.2% 5871.87 ms +0.28% -0.26% 0%
mediaProcessingJpegToAvif 4006.85 ms +0.38% -0.1% 3986.76 ms +0.71% -0.06% 0.5%

media-upload

Metric 656fed9 trunk % Change
jpegUploadProcessing 1503.36 ms +31.73% -2.07% 1480.75 ms +0.41% -0.92% 1.53%
pngUploadProcessing 246.11 ms +2.49% -3.31% 252.15 ms +1.13% -6.85% -2.4%
largeJpegUploadProcessing 1466.69 ms +0.43% -0.6% 1464.14 ms +0.97% -0.17% 0.17%
multipleImageUploadProcessing 2043.5 ms +0.51% -6.46% 2033.64 ms +1.33% -0.81% 0.48%

post-editor

Metric 656fed9 trunk % Change
serverResponse 336.68 ms +4.74% -8.14% 335.07 ms +2.85% -7.67% 0.48%
firstPaint 368.07 ms +4.86% -27.86% 368.48 ms +9.35% -13.38% -0.11%
domContentLoaded 688.26 ms +4% -1.01% 699.19 ms +2.12% -1.02% -1.56%
loaded 689.04 ms +3.98% -1% 699.94 ms +2.13% -1% -1.56%
firstContentfulPaint 402.16 ms +8.21% -2.62% 406.25 ms +5.61% -1.19% -1.01%
firstBlock 1686.99 ms +2.69% -0.66% 1733.46 ms +1.2% -0.91% -2.68%
type 15.9 ms +4.91% -9.43% 16 ms +7.13% -12.56% -0.62%
typeWithoutInspector 16.16 ms +6.06% -8.48% 15.47 ms +5.24% -9.76% 4.46%
typeWithTopToolbar 19.79 ms +3.18% -4.35% 20.69 ms +1.26% -4.88% -4.35%
typeContainer 7.26 ms +11.16% -7.58% 7.32 ms +27.6% -1.23% -0.82%
focus 95.03 ms +5.27% -5.85% 92.58 ms +5.89% -1.97% 2.65%
firstFocus 204.52 ms +0% -0% 222.72 ms +0% -0% -8.17%
selectAll 287.1 ms +1.45% -3.91% 283.83 ms +4.38% -0.32% 1.15%
undo 25.87 ms +4.17% -7.42% 25.01 ms +3% -5% 3.44%
listViewOpen 63.45 ms +10.18% -8.18% 64.73 ms +10.68% -4.68% -1.98%
inserterOpen 33.65 ms +15.78% -3.06% 33.67 ms +5.35% -5.02% -0.06%
inserterHover 9.79 ms +7.97% -5.92% 9.45 ms +13.02% -5.4% 3.6%
inserterSearch 7.86 ms +6.11% -8.65% 7.83 ms +4.09% -7.02% 0.38%
loadPatterns 527.9 ms +6.15% -1.95% 518.44 ms +6.08% -3.83% 1.82%
wpTotal 328.38 ms +4.7% -8.34% 326.75 ms +2.3% -7.89% 0.5%
wpMemoryUsage 14.76 MB +0% -0% 14.73 MB +0% -0% 0.24%
wpDbQueries 55 +0% -0% 55 +0% -0% 0%

site-editor

Metric 656fed9 trunk % Change
serverResponse 278.39 ms +1.28% -7.4% 279.77 ms +0.55% -8.15% -0.49%
firstPaint 265.1 ms +8% -8.9% 275.23 ms +4.21% -5.76% -3.68%
domContentLoaded 589.92 ms +0.77% -0.29% 588.46 ms +3.49% -1.57% 0.25%
loaded 590.44 ms +0.77% -0.29% 588.99 ms +3.48% -1.57% 0.25%
firstContentfulPaint 345.99 ms +1.17% -0.14% 350.67 ms +0.63% -1.49% -1.33%
firstBlock 1698.34 ms +0.4% -1.2% 1690.96 ms +1.24% -1.08% 0.44%
type 10.26 ms +5.65% -7.89% 10.23 ms +16.91% -4.69% 0.29%
navigate 84.5 ms +2.58% -8.43% 82.88 ms +3.89% -4.72% 1.95%
loadPatterns 882.13 ms +15.22% -14.28% 969.1 ms +3.05% -6.01% -8.97%
loadPages 949.39 ms +1.23% -1.39% 959.48 ms +1.39% -1.92% -1.05%
wpTotal 271.29 ms +1.31% -7.56% 272.6 ms +0.54% -8.35% -0.48%
wpMemoryUsage 12.78 MB +0% -0% 12.74 MB +0% -0% 0.27%
wpDbQueries 45 +0% -0% 45 +0% -0% 0%

9a222d0 Run

🏁 Flaky tests

Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

Navigates the items list via UP/DOWN arrow keys (Site Editor v2) in /test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js, passed after 1 failed attempt.
Error: expect(locator).toBeFocused() failed

Locator:  getByLabel('Page One')
Expected: focused
Received: inactive
Timeout:  5000ms

Call log:
  - Expect "toBeFocused" getByLabel('Page One') with timeout 5000ms
  - waiting for getByLabel('Page One')
    14 × locator resolved to <button type="button" aria-pressed="true" data-active-item="true" id="view-list-0-12-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-12-label" aria-describedby="view-list-0-12-description"></button>
       - unexpected value "inactive"

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js:149:49
Page List converts to Navigation Links with entity bindings in /test/e2e/specs/editor/blocks/navigation.spec.js, passed after 1 failed attempt.
Error: expect(locator).toContainText(expected) failed

Locator: getByRole('region', { name: 'Editor settings' }).getByRole('tabpanel', { name: 'Content' }).getByRole('button', { name: /Link to:/ })
Expected substring: "test-page-1"
Received string:    "Link to:Cat/catPagePublished"
Timeout: 5000ms

Call log:
  - Expect "toContainText" getByRole('region', { name: 'Editor settings' }).getByRole('tabpanel', { name: 'Content' }).getByRole('button', { name: /Link to:/ }) with timeout 5000ms
  - waiting for getByRole('region', { name: 'Editor settings' }).getByRole('tabpanel', { name: 'Content' }).getByRole('button', { name: /Link to:/ })
    14 × locator resolved to <button type="button" aria-expanded="false" aria-haspopup="dialog" class="components-button link-preview-button is-next-40px-default-size is-secondary">…</button>
       - unexpected value "Link to:Cat/catPagePublished"

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:1949:31
Undo restores the post selection when another synced entity is loaded (RTC WebSocket) in /test/e2e/specs/editor/collaboration/collaboration-undo-redo.spec.ts, passed after 1 failed attempt.
Error: expect(received).toMatchObject(expected)

- Expected  - 2
+ Received  + 2

  Object {
    "attributeKey": "content",
    "blockIndex": 0,
    "content": "abcdef",
-   "endOffset": 3,
-   "offset": 3,
+   "endOffset": 1,
+   "offset": 1,
  }

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/collaboration/collaboration-undo-redo.spec.ts:363:5
a navigation superseded by the traversal discharges to idle in /test/e2e/specs/interactivity/router-navigation-lifecycle.spec.ts, passed after 1 failed attempt.
SyntaxError: Unexpected token 'o', "not hydrated" is not valid JSON
    at readLog (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/interactivity/router-navigation-lifecycle.spec.ts:28:14)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/interactivity/router-navigation-lifecycle.spec.ts:47:24
    at waitForLogLength (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/interactivity/router-navigation-lifecycle.spec.ts:46:2)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/interactivity/router-navigation-lifecycle.spec.ts:693:5
should place the caret at the click position when clicking a block that is not selected in /test/e2e/specs/editor/various/writing-flow.spec.js, passed after 1 failed attempt.
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

@@ -1,9 +1,9 @@
  Array [
    Object {
      "attributes": Object {
-       "content": "First!",
+       "content": "First",
      },
      "name": "core/paragraph",
    },
    Object {
      "attributes": Object {

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/writing-flow.spec.js:952:41
should preserve dragged selection on move in /test/e2e/specs/editor/various/multi-block-selection.spec.js, passed after 1 failed attempt.
TimeoutError: locator.hover: Timeout 10000ms exceeded.
Call log:
  - waiting for locator('[name="editor-canvas"]').contentFrame().getByRole('document', { name: 'Block: Paragraph' }).nth(1)
    - locator resolved to <p role="document" data-empty="false" aria-multiline="true" aria-readonly="false" data-title="Paragraph" contenteditable="true" data-type="core/paragraph" aria-label="Block: Paragraph" data-wp-block-attribute-key="content" id="block-ca7aa53f-101f-438f-9d68-627d78b6f150" data-block="ca7aa53f-101f-438f-9d68-627d78b6f150" class="block-editor-rich-text__editable block-editor-block-list__block wp-block wp-block-paragraph rich-text">2</p>
  - attempting hover action
    2 × waiting for element to be visible and stable
      - element is visible and stable
      - scrolling into view if needed
      - done scrolling
      - <button id="_r_5u_" type="button" tabindex="-1" aria-label="Link" aria-pressed="false" aria-haspopup="true" aria-expanded="false" data-toolbar-item="true" class="components-button components-toolbar-button is-compact has-icon">…</button> from <div tabindex="-1" data-wp-c16t="true" data-wp-component="Popover" class="components-popover block-editor-block-popover block-editor-block-list__block-popover is-positioned is-unstyled">…</div> subtree intercepts pointer events
    - retrying hover action
    - waiting 20ms
    2 × waiting for element to be visible and stable
      - element is visible and stable
      - scrolling into view if needed
      - done scrolling
      - <button id="_r_5u_" type="button" tabindex="-1" aria-label="Link" aria-pressed="false" aria-haspopup="true" aria-expanded="false" data-toolbar-item="true" class="components-button components-toolbar-button is-compact has-icon">…</button> from <div tabindex="-1" data-wp-c16t="true" data-wp-component="Popover" class="components-popover block-editor-block-popover block-editor-block-list__block-popover is-positioned is-unstyled">…</div> subtree intercepts pointer events
    - retrying hover action
      - waiting 100ms
    14 × waiting for element to be visible and stable
       - element is visible and stable
       - scrolling into view if needed
       - done scrolling
       - <button id="_r_5u_" type="button" tabindex="-1" aria-label="Link" aria-pressed="false" aria-haspopup="true" aria-expanded="false" data-toolbar-item="true" class="components-button components-toolbar-button is-compact has-icon">…</button> from <div tabindex="-1" data-wp-c16t="true" data-wp-component="Popover" class="components-popover block-editor-block-popover block-editor-block-list__block-popover is-positioned is-unstyled">…</div> subtree intercepts pointer events
     - retrying hover action
       - waiting 500ms
    - waiting for element to be visible and stable

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/multi-block-selection.spec.js:817:20

9a222d0 Run

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Image

@jasmussen
jasmussen merged commit 1e6b96a into trunk Nov 6, 2026
83 checks passed
@jasmussen
jasmussen deleted the update/cover-icon branch November 6, 2026 11:37
@jasmussen

Copy link
Copy Markdown
Contributor Author

Thank you!

@github-actions github-actions Bot added this to the Gutenberg 24.5 milestone Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Icons /packages/icons [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants