Repository navigation
Font Library: Paginate installed fonts - #86063
Open
Mustafabharmal wants to merge 3 commits into
Open
Mustafabharmal wants to merge 3 commits into
Mustafabharmal wants to merge 3 commits into
Conversation
🤖 PR meta 🤖🎉 PropsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
Updated as activity occurs, without notifying anyone named here. Add the 🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #84688
Paginates the installed fonts in the Font Library's Library tab, the same way as the Install tab.
Why?
Since #84684, all installed font families are loaded and listed at once, so a site with many custom fonts gets a very long list. See #84684 (review).
How?
Paginationcomponent, so both tabs look and behave the same. The standalone Appearance > Fonts page uses the same component.per_page: -1query from Font Library: Load all installed font families #84684 is kept, like the template and pattern lists, which fetch all items and paginate on the client. This keeps fonts sorted alphabetically, and the installed variants check from Font Library: Mark installed font variants in font collections #84023 keeps working. Paginating the request itself would needorderby: titlesupport in the font families REST endpoint, and can be done in a follow-up.Testing Instructions
Screenshots or screencast
Use of AI Tools
Claude Code (Claude Opus 5.5) was used to investigate the issue, draft the fix, and draft this description. I reviewed all changes, ran the tests and verified the behaviour manually.