Skip to content

Theme Build Tools: Declare @wordpress/theme as a peer dependency - #85388

Merged
simison merged 6 commits into
trunkfrom
simison/theme-build-tools-theme-peer
Oct 26, 2026
Merged

simison merged 6 commits into
trunkfrom
simison/theme-build-tools-theme-peer

Conversation

@simison

@simison simison commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Follow-up to #83568

What?

Closes

Declares @wordpress/theme as a peer dependency of @wordpress/theme-build-tools (^3.0.0 || ^4.0.0) instead of a regular dependency, so consumers use the version of @wordpress/theme they've chosen, rather than getting a second pinned copy.

The plugins already do nothing when theme can't be loaded, so no code changes are needed.

In #83568 I pinned the version to make CI and initial merge easier. We're between package release cycle with this (#83568) so NPM consumers never got the direct dependency version yet.

Why?

How?

Testing Instructions

Using it without @wordpress/theme in a sample project would fail to add fallbacks silently, and using different versions of @wordpress/theme works.

The ranges would need to be updated manually, which is why I'm also looking at linting peer ranges:

Use of AI Tools

yes

@simison simison added the [Package] wp-build /packages/wp-build label Oct 22, 2026
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

🤖 PR meta 🤖

Preview in WordPress Playground

🎉 Props

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: simison <simison@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Updated as activity occurs, without notifying anyone named here. Add the props-bot label to refresh.

📦 Bundle size

Size Change: 0 B

Total Size: 8.56 MB

0b81f9c Run

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric 1bea13a trunk % Change
timeToFirstByte 57 ms +6.32% -2.37% 56.9 ms +7.91% -1.41% 0.18%
largestContentfulPaint 98 ms +6.12% -6.12% 94 ms +8.51% -2.13% 4.26%
lcpMinusTtfb 40.85 ms +9.79% -11.38% 36.35 ms +17.61% -4.95% 12.38%
wpBeforeTemplate 29.88 ms +7.33% -1.27% 30.26 ms +3.14% -1.02% -1.26%
wpTemplate 22.32 ms +4.66% -3.49% 22.89 ms +6.9% -2.58% -2.49%
wpTotal 52.91 ms +6.41% -2.19% 53.04 ms +8.14% -1.26% -0.25%
wpMemoryUsage 7.68 MB +0% -0% 7.65 MB +0% -0% 0.43%
wpDbQueries 16 +0% -0% 16 +0% -0% 0%

front-end-classic-theme

Metric 1bea13a trunk % Change
timeToFirstByte 48.65 ms +9.04% -2.06% 49.4 ms +8.1% -1.72% -1.52%
largestContentfulPaint 108 ms +1.85% -3.7% 108 ms +3.7% -3.7% 0%
lcpMinusTtfb 56.5 ms +4.6% -1.5% 58.2 ms +1.12% -3.87% -2.92%
wpBeforeTemplate 28.04 ms +5.99% -1.57% 28.4 ms +10.56% -2.32% -1.27%
wpTemplate 17.15 ms +6.06% -0.82% 17.95 ms +2.9% -3.4% -4.46%
wpTotal 45.43 ms +9.07% -1.96% 46.12 ms +8.93% -1.76% -1.5%
wpMemoryUsage 6.37 MB +0% -0% 6.34 MB +0% -0% 0.54%
wpDbQueries 13 +0% -0% 13 +0% -0% 0%

media-processing

Metric 1bea13a trunk % Change
mediaProcessingJpeg 410.38 ms +0.38% -0.73% 398.6 ms +2.36% -0.6% 2.96%
mediaProcessingAvif 6095.61 ms +0.15% -0.17% 6117.51 ms +0.2% -0.22% -0.36%
mediaProcessingJpegToAvif 4197.8 ms +0.45% -0.2% 4219.45 ms +0.05% -0.35% -0.51%

media-upload

Metric 1bea13a trunk % Change
jpegUploadProcessing 1485.69 ms +1.34% -3.1% 1435.37 ms +1.7% -0.9% 3.51%
pngUploadProcessing 208.76 ms +39.14% -13.66% 236.92 ms +3.45% -25.6% -11.89%
largeJpegUploadProcessing 1435.16 ms +2.66% -0.53% 1432.4 ms +0.5% -0.34% 0.19%
multipleImageUploadProcessing 1569.53 ms +1% -1.2% 1514.17 ms +0.5% -0.67% 3.66%

post-editor

Metric 1bea13a trunk % Change
serverResponse 517.72 ms +2.59% -1.66% 529.11 ms +1.9% -10.52% -2.15%
firstPaint 279.87 ms +18.44% -20.81% 307.91 ms +55.26% -25.4% -9.11%
domContentLoaded 906.8 ms +0.43% -3.46% 898.8 ms +2.34% -2.5% 0.89%
loaded 907.95 ms +0.46% -3.45% 899.83 ms +2.32% -2.48% 0.9%
firstContentfulPaint 516.47 ms +1.12% -5.08% 510.75 ms +4.5% -9.04% 1.12%
firstBlock 3120.48 ms +1.27% -0.91% 3090.02 ms +0.44% -1.39% 0.99%
type 18.28 ms +3.34% -10.34% 17.59 ms +4.72% -4.49% 3.92%
typeWithoutInspector 17.06 ms +4.28% -3.81% 16.54 ms +5.8% -7.68% 3.14%
typeWithTopToolbar 24.12 ms +6.09% -6.8% 23.35 ms +1.16% -10.58% 3.3%
typeContainer 8.76 ms +5.82% -13.7% 8.23 ms +6.44% -13.12% 6.44%
focus 123.57 ms +2.32% -11.35% 118.57 ms +8.83% -8.86% 4.22%
firstFocus 239.2 ms +0% -0% 227.98 ms +0% -0% 4.92%
selectAll 497.04 ms +0.57% -0.37% 467.1 ms +5% -0.79% 6.41%
listViewOpen 79.82 ms +10.06% -8.67% 78.13 ms +9.73% -4.26% 2.16%
inserterOpen 41.67 ms +4.7% -7.8% 41.16 ms +7.17% -5.61% 1.24%
inserterHover 10.82 ms +10.54% -4.34% 11.05 ms +8.51% -9.23% -2.08%
inserterSearch 8.5 ms +13.41% -9.29% 8.69 ms +1.61% -9.44% -2.19%
loadPatterns 660.15 ms +2.39% -5.63% 644.07 ms +2.74% -4.41% 2.5%
wpTotal 508.17 ms +2.39% -1.77% 518.59 ms +2.12% -10.45% -2.01%
wpMemoryUsage 14.71 MB +0% -0% 14.68 MB +0% -0% 0.24%
wpDbQueries 55 +0% -1.82% 55 +0% -1.82% 0%

site-editor

Metric 1bea13a trunk % Change
serverResponse 421.56 ms +3.55% -5.17% 420.73 ms +2.18% -9.5% 0.2%
firstPaint 286.31 ms +15.9% -28.8% 240.97 ms +27.67% -18.04% 18.82%
domContentLoaded 857.85 ms +5.43% -1.37% 863.89 ms +0.9% -2.22% -0.7%
loaded 859.01 ms +5.41% -1.4% 864.83 ms +0.91% -2.21% -0.67%
firstContentfulPaint 475.76 ms +9.27% -0.72% 478.09 ms +0.73% -16.9% -0.49%
firstBlock 3805.66 ms +0.75% -0.69% 3782.68 ms +0.98% -0.71% 0.61%
type 18.9 ms +4.71% -4.71% 17.95 ms +6.07% -2.17% 5.29%
navigate 118.84 ms +5.76% -0.81% 118.55 ms +8.05% -2.44% 0.24%
loadPatterns 1186.53 ms +14.37% -6.23% 1347.5 ms +8.17% -6.07% -11.95%
loadPages 962.43 ms +2.33% -0.74% 987.16 ms +0.49% -1.54% -2.51%
wpTotal 412.06 ms +3.6% -5.25% 411.23 ms +2.23% -9.68% 0.2%
wpMemoryUsage 12.73 MB +0% -0% 12.70 MB +0% -0% 0.24%
wpDbQueries 44 +2.27% -0% 44 +2.27% -0% 0%

0b81f9c Run

🏁 Flaky tests

Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

Custom Completer: should allow newlines after multiple option completions in /test/e2e/specs/editor/various/autocomplete-and-mentions.spec.js, passed after 1 failed attempt.
Error: expect(received).toBe(expected) // Object.is equality

- Expected  - 1
+ Received  + 1

@@ -9,11 +9,11 @@
  <!-- wp:paragraph -->
  <p>🫐 test</p>
  <!-- /wp:paragraph -->

  <!-- wp:paragraph -->
- <p>🫐 test</p>
+ <p>🍎 test</p>
  <!-- /wp:paragraph -->

  <!-- wp:paragraph -->
  <p></p>
  <!-- /wp:paragraph -->

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/autocomplete-and-mentions.spec.js:466:6
Navigates the list via UP/DOWN arrow keys from action buttons (Site Editor v2) in /test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js, passed after 1 failed attempt.
Error: expect(locator).toBeFocused() failed

Locator:  getByRole('row', { name: 'Page Two View Actions' }).getByLabel('Actions')
Expected: focused
Received: inactive
Timeout:  5000ms

Call log:
  - Expect "toBeFocused" getByRole('row', { name: 'Page Two View Actions' }).getByLabel('Actions') with timeout 5000ms
  - waiting for getByRole('row', { name: 'Page Two View Actions' }).getByLabel('Actions')
    14 × locator resolved to <button type="button" tabindex="-1" aria-haspopup="menu" aria-label="Actions" aria-expanded="false" id="view-list-0-13-dropdown" class="components-button is-small has-icon">…</button>
       - unexpected value "inactive"

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js:263:5
The navigation text color should apply to all navigation links including submenu and overlay text in /test/e2e/specs/editor/blocks/navigation-colors.spec.js, passed after 1 failed attempt.
Error: apiRequestContext.fetch: socket hang up
Call log:
  - → GET http://localhost:8889/wp-json/wp/v2/pages?per_page=100&status=publish%2Cfuture%2Cdraft%2Cpending%2Cprivate%2Ctrash
    - user-agent: Playwright/1.63.0 (x64; ubuntu 24.04) node/24.20 CI/1
    - accept: */*
    - accept-encoding: gzip,deflate,br
    - X-WP-Nonce: a446c535c4
    - cookie: wordpress_test_cookie=WP%20Cookie%20check; wordpress_logged_in_23778236db82f19306f247e20a353a99=admin%7C1793207789%7Ct6sUCpNpwHj14Z1TiKwwdwDc1fPjGTYZHGrBiWDjRi5%7C8ab4866eeb4c805c3b717727be65b25b7c28532e1bd7dc388581cb3b2de385f6; wp-settings-time-1=1793035061

    at RequestUtils.rest (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/request-utils/rest.ts:111:39)
    at RequestUtils.deleteAllPages (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/request-utils/pages.ts:44:27)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation-colors.spec.js:38:17
Undo restores the post selection when another synced entity is loaded (RTC WebSocket) in /test/e2e/specs/editor/collaboration/collaboration-undo-redo.spec.ts, passed after 1 failed attempt.
Error: expect(received).toMatchObject(expected)

- Expected  - 2
+ Received  + 2

  Object {
    "attributeKey": "content",
    "blockIndex": 0,
    "content": "abcdef",
-   "endOffset": 3,
-   "offset": 3,
+   "endOffset": 6,
+   "offset": 6,
  }

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/collaboration/collaboration-undo-redo.spec.ts:363:5
displays edits to the post title and content in the preview in /test/e2e/specs/editor/various/preview.spec.js, passed after 1 failed attempt.
Error: apiRequestContext.fetch: socket hang up
Call log:
  - → PUT http://localhost:8891/wp-json/wp/v2/plugins/gutenberg-test-plugins/disable-client-side-media-processing
    - user-agent: Playwright/1.63.0 (x64; ubuntu 24.04) node/24.20 CI/1
    - accept: */*
    - accept-encoding: gzip,deflate,br
    - X-WP-Nonce: 851b583e11
    - content-type: application/json
    - content-length: 21
    - cookie: wordpress_test_cookie=WP%20Cookie%20check; wordpress_logged_in_da433b7faafd8180ebeb1624ceeeab7e=admin%7C1793207790%7CIh1DnXqBmHj0nxfiYYazjOhKoskj76s5TwUHXK5HOZA%7C0bd23d380b84b75eb4bf7ce6752bff15a8631aebbbe0abe9799327d2fb913a32; wp-settings-time-1=1793035190

    at RequestUtils.rest (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/request-utils/rest.ts:111:39)
    at RequestUtils.deactivatePlugin (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/request-utils/plugins.ts:89:13)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/preview.spec.js:364:3
does not select blocks in the canvas preview when editing from the sidebar (Site Editor v2) in /test/e2e/specs/site-editor/navigation-sidebar-list-view.spec.js, passed after 1 failed attempt.
Error: expect(locator).toBeVisible() failed

Locator: getByRole('listbox', { name: 'Search results' })
Expected: visible
Timeout: 5000ms
Error: element(s) not found

Call log:
  - Expect "toBeVisible" getByRole('listbox', { name: 'Search results' }) with timeout 5000ms
  - waiting for getByRole('listbox', { name: 'Search results' })

    at LinkControl.useLinkControlSearch (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/navigation-sidebar-list-view.spec.js:423:33)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/navigation-sidebar-list-view.spec.js:179:3
inserts a block should show a blue line indicator in /test/e2e/specs/editor/various/inserting-blocks.spec.js, passed after 1 failed attempt.
Error: expect(locator).toBeVisible() failed

Locator: locator('data-testid=block-list-insertion-point-indicator')
Expected: visible
Timeout: 5000ms
Error: element(s) not found

Call log:
  - Expect "toBeVisible" locator('data-testid=block-list-insertion-point-indicator') with timeout 5000ms
  - waiting for locator('data-testid=block-list-insertion-point-indicator')

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/inserting-blocks.spec.js:674:50
should change the indented list type in /test/e2e/specs/editor/blocks/list.spec.js, passed after 1 failed attempt.
TimeoutError: locator.click: Timeout 10000ms exceeded.
Call log:
  - waiting for locator('role=toolbar[name="Block tools"i]').locator('role=button[name="Indent"]')

    at Editor.clickBlockToolbarButton (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/editor/click-block-toolbar-button.ts:17:15)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/list.spec.js:727:3
should create paragraph on Enter in quote block in /test/e2e/specs/editor/blocks/list.spec.js, passed after 1 failed attempt.
TimeoutError: locator.click: Timeout 10000ms exceeded.
Call log:
  - waiting for getByRole('option', { name: 'List', exact: true })

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/list.spec.js:751:67
should create paragraph on split at end and merge back with content in /test/e2e/specs/editor/blocks/list.spec.js, passed after 1 failed attempt.
Error: expect(received).toBe(expected) // Object.is equality

- Expected  - 1
+ Received  + 1

@@ -1,8 +1,8 @@
  <!-- wp:list -->
  <ul class="wp-block-list"><!-- wp:list-item -->
- <li>one</li>
+ <li>e</li>
  <!-- /wp:list-item --></ul>
  <!-- /wp:list -->

  <!-- wp:paragraph -->
  <p></p>

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/list.spec.js:461:52
should cut and paste individual blocks with collapsed selection in /test/e2e/specs/editor/various/copy-cut-paste.spec.js, passed after 1 failed attempt.
Error: expect(string).toMatchSnapshot(expected) failed

  @@ -1,3 +1,3 @@
   <!-- wp:paragraph -->
  -<p>2Cut - collapsed selection</p>
  +<p>2</p>
   <!-- /wp:paragraph -->


    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/copy-cut-paste.spec.js:45:49
should indent and outdent a list item when its content is fully selected in /test/e2e/specs/editor/blocks/list.spec.js, passed after 1 failed attempt.
Error: expect(received).toBe(expected) // Object.is equality

- Expected  - 7
+ Received  + 7

  <!-- wp:list -->
  <ul class="wp-block-list"><!-- wp:list-item -->
- <li>a<!-- wp:list -->
- <ul class="wp-block-list"><!-- wp:list-item -->
- <li>b</li>
+ <li></li>
+ <!-- /wp:list-item --></ul>
- <!-- /wp:list-item --></ul>
+ <!-- /wp:list -->
+
- <!-- /wp:list --></li>
- <!-- /wp:list-item --></ul>
+ <!-- wp:paragraph -->
+ <p>b</p>
- <!-- /wp:list -->
+ <!-- /wp:paragraph -->

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/list.spec.js:819:52
should indent and outdent multi-selected items with Tab in /test/e2e/specs/editor/blocks/list.spec.js, passed after 1 failed attempt.
Error: expect(received).toBe(expected) // Object.is equality

- Expected  - 1
+ Received  + 1

@@ -1,8 +1,8 @@
  <!-- wp:list -->
  <ul class="wp-block-list"><!-- wp:list-item -->
- <li>one<!-- wp:list -->
+ <li>ne<!-- wp:list -->
  <ul class="wp-block-list"><!-- wp:list-item -->
  <li>two</li>
  <!-- /wp:list-item -->

  <!-- wp:list-item -->

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/list.spec.js:1118:52
should leave nested list intact when deleting the parent item in /test/e2e/specs/editor/blocks/list.spec.js, passed after 1 failed attempt.
Error: expect(received).toMatchObject(expected)

- Expected  -  1
+ Received  + 19

@@ -1,19 +1,36 @@
  Array [
    Object {
+     "attributes": Object {
+       "content": "1",
+       "dropCap": false,
+     },
+     "innerBlocks": Array [],
+     "name": "core/paragraph",
+   },
+   Object {
+     "attributes": Object {
+       "ordered": false,
+       "values": "",
+     },
      "innerBlocks": Array [
        Object {
          "attributes": Object {
-           "content": "1",
+           "content": "",
          },
          "innerBlocks": Array [
            Object {
+             "attributes": Object {
+               "ordered": false,
+               "values": "",
+             },
              "innerBlocks": Array [
                Object {
                  "attributes": Object {
                    "content": "a",
                  },
+                 "innerBlocks": Array [],
                  "name": "core/list-item",
                },
              ],
              "name": "core/list",
            },
@@ -22,10 +39,11 @@
        },
        Object {
          "attributes": Object {
            "content": "3",
          },
+         "innerBlocks": Array [],
          "name": "core/list-item",
        },
      ],
      "name": "core/list",
    },
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/list.spec.js:3017:38
should merge a following sibling list into the outermost list with Delete from a nested item (#77245) in /test/e2e/specs/editor/blocks/list.spec.js, passed after 1 failed attempt.
Error: expect(received).toMatchObject(expected)

- Expected  - 2
+ Received  + 2

@@ -8,11 +8,11 @@
          "innerBlocks": Array [
            Object {
              "innerBlocks": Array [
                Object {
                  "attributes": Object {
-                   "content": "b‸",
+                   "content": "b",
                  },
                  "name": "core/list-item",
                },
              ],
              "name": "core/list",
@@ -25,11 +25,11 @@
    },
    Object {
      "innerBlocks": Array [
        Object {
          "attributes": Object {
-           "content": "1",
+           "content": "‸1",
          },
          "innerBlocks": Array [
            Object {
              "innerBlocks": Array [
                Object {

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/list.spec.js:2854:41
should not have a dead zone above an aligned block in /test/e2e/specs/editor/various/writing-flow.spec.js, passed after 1 failed attempt.
TypeError: Cannot read properties of null (reading 'y')
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/writing-flow.spec.js:1053:39
should outdent with children in /test/e2e/specs/editor/blocks/list.spec.js, passed after 1 failed attempt.

Truncated. See the full report.

0b81f9c Run

@simison
simison force-pushed the simison/theme-build-tools-theme-peer branch from f8bfc4b to a40b66e Compare October 22, 2026 15:02
@simison
simison force-pushed the simison/theme-build-tools-theme-peer branch from a40b66e to 307f106 Compare October 22, 2026 15:02
"vitest": "^5.0.3"
},
"peerDependencies": {
"@wordpress/theme": "^3.0.0 || ^4.0.0",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simison simison added the [Package] Theme /packages/theme label Oct 22, 2026
@simison
simison force-pushed the simison/theme-build-tools-theme-peer branch from 307f106 to f973420 Compare October 22, 2026 15:14
@github-actions github-actions Bot removed the [Package] Theme /packages/theme label Oct 22, 2026
@simison
simison force-pushed the simison/theme-build-tools-theme-peer branch from f973420 to 48a851e Compare October 22, 2026 15:15
Comment thread packages/theme-build-tools/CHANGELOG.md Resolved
@simison
simison marked this pull request as ready for review October 22, 2026 15:17
@simison
simison requested a review from a team as a code owner October 22, 2026 15:17
@simison simison added the [Type] Build Tooling Issues or PRs related to build tooling label Oct 22, 2026
@github-actions github-actions Bot added [Tool] stylelint config /packages/stylelint-config [Package] wp-build /packages/wp-build labels Oct 22, 2026
"vitest": "^5.0.3"
},
"peerDependencies": {
"@wordpress/theme": "^3.0.0 || ^4.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like npm still auto-installs the theme through this package, despite the optional declarations in build and stylelint-config.

One way to fix that would be to add @wordpress/theme to peerDependenciesMeta with optional: true, WDYT ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think so. It's a bit annoying how many places now have this so we'll definetely need linting/automation to catch incomplete ranges in future.

@simison
simison force-pushed the simison/theme-build-tools-theme-peer branch 2 times, most recently from e2d569d to 4158615 Compare October 23, 2026 17:04
@simison
simison requested a review from a team October 23, 2026 17:05

@ciampo ciampo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Comment thread packages/theme-build-tools/README.md Resolved
Comment thread packages/theme-build-tools/CHANGELOG.md Resolved
@simison
simison force-pushed the simison/theme-build-tools-theme-peer branch 2 times, most recently from 71f7643 to 7cbdce2 Compare October 26, 2026 16:47
@simison
simison enabled auto-merge (squash) October 26, 2026 16:56
@simison
simison force-pushed the simison/theme-build-tools-theme-peer branch from a9e5a74 to 0b81f9c Compare October 26, 2026 17:09
@simison
simison merged commit b90b4e3 into trunk Oct 26, 2026
92 of 101 checks passed
@simison
simison deleted the simison/theme-build-tools-theme-peer branch October 26, 2026 17:31
@github-actions github-actions Bot added this to the Gutenberg 24.4 milestone Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Theme Build Tools [Package] wp-build /packages/wp-build [Tool] stylelint config /packages/stylelint-config [Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants