Repository navigation
Style revisions: Compare the selected revision with the current version side by side - #85288
Conversation
🤖 PR meta 🤖🎉 PropsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
Updated as activity occurs, without notifying anyone named here. Add the 📦 Bundle sizeSize Change: +4.35 kB (+0.05%) Total Size: 8.62 MB 📦 View Changed
⚡ PerformanceShow the resultsClient side metrics exclude the server response time. front-end-block-theme
front-end-classic-theme
media-processing
media-upload
post-editor
site-editor
🏁 Flaky testsSome tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information. Page List converts to Navigation Links with entity bindings in
|
|
@coderabbitai review |
|
✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. ℹ️ Recent review info
📝 Summary
Merge Risk:
|
|
cc @ramonjd, since this builds on your side-by-side proof of concept. Still in draft pending the design questions above; I'll request review once those are settled. |
|
@jasmussen @mattmiklic could you take a look at the design when you get a chance? It adds the side-by-side comparison for Style revisions from #53484. I have added the screencasts in the description. I'll open it for code review once the design is settled. |
Thanks for testing! Easy to mix up, but this one is for Style revisions, not page revisions. Go to Site Editor → Styles → Revisions, then pick an older revision, and you'll see the side-by-side comparison. You'll need at least two saved style changes first. |
|
thanks, @jasmussen! I agree that scrolling should be synchronized across both screens to make comparisons easier. Here's a video reference for the proposed change, let me know what you think. feedbacks welcome! Screen.Recording.2026-10-29.at.11.16.52.AM.mov |
|
Looks good to me. Absent any other feedback we receive, probably this can move into the code review portion. E.g. right now it's two scrollbars in sync, if for some reason that's complex, can it be one canvas with two page instances, very very tall, and then a single scrollbar? I have no strong opinion, only offering what-ifs. |
Thanks, @jasmussen! @ellatrix, would you mind taking a look when you get a chance? |
ramonjd
left a comment
There was a problem hiding this comment.
I took this for a spin, this is great UX change, thanks for carrying the idea forward. Comparing visual changes by default makes sense for global styles, and the option to see the theme.json values would be valuable for theme devs.
I tested with some pretty crazy padding (2000px) and the scroll sync holds.
If there are no blockers I think we could get it in front of users.
I would like a second opinion though! cc @tellthemachines for confidence check
Was there anything specific you wanted me to look at? From a quick test run it seems to be working pretty well, and it's a nice improvement. It's a shame we don't have access to style revisions from the left hand side styles sidebar! But that's definitely something for another time :) |
Not really, just a confidence check. 🙇🏻 I guess also any UX or a11y things that stand out to you. I think once the Thanks for checking it out!! |
|
Thanks both! @ramonjd, both of your comments are addressed. Mind another look? @tellthemachines, I'll open a follow-up issue for the sidebar entry point. |
6c4c429 to
be58dba
Compare
ramonjd
left a comment
There was a problem hiding this comment.
Just gave this PR a rebase. Thanks for the efforts on this feature.
|
Thank you to everyone who contributed to this PR. I really appreciate all the effort that went into getting this shipped! As @tellthemachines suggested, the Site Editor should have a Revisions button in the left-hand sidebar, allowing users to quickly check revisions without having to leave the editor. I've opened a follow-up PR to address this: #86411 This is already available in the V2 Site Editor, so we're not introducing anything new here; we're simply bringing the same functionality to V1 as well. IMO, this is a valuable addition. Thanks again to everyone who was involved in the review process for this PR. I would really appreciate your feedback and inputs on the follow-up PR (#86411) as well. Thanks, everyone! |


What?
Part of #53484
Compares the selected style revision with the current version side by side, as a visual preview or as a code diff of the styles and settings, under a header naming each.
Why?
How?
areGlobalStylesEqual, the same check as the sidebar's Apply button.Notes for review
Testing Instructions
Testing Instructions for Keyboard
Screenshots
Screen.Recording.2026-10-21.at.5.49.05.PM.mov
Use of AI Tools
Written with Claude Code; reviewed and tested manually in the site editor, with e2e runs in both site editors.