Repository navigation
Repair wp/7.0 branch Actions: Fix flaky Openverse image drag-and-drop e2e test - #84038
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
|
Size Change: 0 B Total Size: 7.61 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
ae6c718 to
b64a0b0
Compare
b64a0b0 to
3673f0f
Compare
3673f0f to
7c6b22d
Compare
7c6b22d to
308a382
Compare
308a382 to
0a44cff
Compare
0a44cff to
5b05b2f
Compare
tellthemachines
left a comment
There was a problem hiding this comment.
LGTM!
#75483 only made it into 7.1 so makes sense to add the image asset on all earlier branches.
5b05b2f to
bb64da6
Compare
bb64da6 to
b640c8d
Compare
Part of #82782.
What?
Mocks Openverse in
test/e2e/specs/editor/blocks/image.spec.js's "can be replaced by dragging-and-dropping images from the inserter" test.page.route()answers the search request toapi.openverse.orgwith two results on a fakeopenverse.testhost, and serves those two images fromtest/e2e/assets. It also addstest/e2e/assets/10x10_e2e_test_image_green.png, one of the two images, which this branch doesn't have yet.Why?
The test dragged real Openverse search results onto an image block. When a result is dropped, the editor downloads the full-size image with
fetch()and uploads it to the media library. The first result is currently a NASA image hosted onlive.staticflickr.com, and on GitHub-hosted runners that download can fail withnet::ERR_FAILED(the same URL loads outside CI). Nothing is uploaded, and the image block stays empty.On this branch it failed
Playwright - 1on #83832 at 04:16 UTC on 2026-09-30, on every retry. The same failure broke the test ontrunk, which #83842 fixed. Mocking the search and the images removes the test's dependency on both services.How?
Ports #83842 from
trunk. The test code is identical. The green image is copied fromtrunk, where #75483 added it.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code