Repository navigation
Repair wp/6.9 branch Actions: Fix flaky interactivity router navigate e2e test - #83648
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
c6b4cc5 to
bc078f5
Compare
bc078f5 to
3c7f873
Compare
3c7f873 to
cf04726
Compare
|
Size Change: 0 B Total Size: 2.12 MB ℹ️ View Unchanged
|
cf04726 to
f3a3362
Compare
f3a3362 to
58bd2f3
Compare
58bd2f3 to
5549d31
Compare
5549d31 to
c37b54e
Compare
c37b54e to
166fb9c
Compare
Part of #82785.
What?
Makes the "should update the HTML only for the latest navigation" test in
test/e2e/specs/interactivity/router-navigate.spec.tswait until the browser has requested both linked pages before letting either request through.Why?
The test holds each page request in a
page.route()handler, and the functions that let a request through (resolveLink1andresolveLink2) are only assigned once those handlers run. The test only waited for the page's own navigation counter, which can reach 2 before Playwright has run the handlers, so callingresolveLink2()could fail withTypeError: resolveLink2 is not a function. It failed this way on #83639, on all retries.Upstream
A straight cherry-pick of
e693c18(#80178) fromtrunk.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code