Repository navigation
Conversation
🤖 PR meta 🤖📦 Bundle sizeSize Change: +68.7 kB (+0.83%) Total Size: 8.3 MB 📦 View Changed
⚡ PerformanceShow the resultsClient side metrics exclude the server response time. front-end-block-theme
front-end-classic-theme
media-processing
media-upload
post-editor
site-editor
🏁 Flaky testsShow the failuresSome tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information. two users concurrently move list items (RTC WebSocket) in
|
c6c6fa4 to
ea2be71
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Cross-document focus, extension fallback, and Customizer overlay behavior require final interactive human verification.
Review effort: Balanced
Findings: None
What changed in this PR
Migrates Widgets and Customizer Options menus to @wordpress/ui while preserving extension compatibility, preferences, dialogs, and focus behavior.
Changes:
- Adds package-local UI Menu implementations and preference controls.
- Preserves the legacy Widgets menu when extension fills exist.
- Handles Customizer overlays and toolbar focus guards, with browser coverage.
| File | Description |
|---|---|
packages/edit-widgets/src/components/more-menu/ui-menu.tsx |
Adds the new Widgets Options menu. |
packages/edit-widgets/src/components/more-menu/more-menu-preference-item.tsx |
Adds UI Menu preference toggles. |
packages/edit-widgets/src/components/more-menu/index.jsx |
Selects the new or extension-compatible legacy menu. |
packages/edit-widgets/CHANGELOG.md |
Records the migration. |
packages/customize-widgets/src/style.scss |
Removes obsolete menu styling. |
packages/customize-widgets/src/components/more-menu/style.scss |
Deletes the legacy z-index override. |
packages/customize-widgets/src/components/more-menu/more-menu-preference-item.tsx |
Adds Customizer preference toggles. |
packages/customize-widgets/src/components/more-menu/index.jsx |
Migrates the Customizer Options menu. |
packages/customize-widgets/src/components/customize-widgets/use-clear-selected-block.js |
Preserves selection during UI overlay interaction. |
packages/customize-widgets/CHANGELOG.md |
Records the migration. |
packages/block-editor/src/components/navigable-toolbar/test/index.browser.test.js |
Tests portaled-menu toolbar stability. |
packages/block-editor/src/components/navigable-toolbar/index.jsx |
Excludes focus guards from toolbar controls. |
packages/block-editor/CHANGELOG.md |
Records the toolbar fix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Both (probably) separate issues, but:
|
Re. toolbar variant, see reply in #82966 (comment)
The What we can do here is to add a custom max width for this specific case. (also cc @mirka who recently worked on width presets for some popups; at the time, we decided explicitly not to add such presents to the menu's popup) |
| const toolsFills = useSlotFills( 'EditWidgetsToolsMoreMenuGroup' ); | ||
| // Existing fills may contain arbitrary legacy controls. Preserve their menu | ||
| // context and keyboard navigation. | ||
| return toolsFills?.length ? <LegacyMoreMenu /> : <MoreMenuWithUI />; |
There was a problem hiding this comment.
Why not use the same migration method we've used for the editor menu?
Part of #61094.
What?
Use
@wordpress/uiMenu for the Widgets and Customizer Options menus.Why?
Migrate these menus while keeping preferences, announcements, and help dialogs working as before.
How?
Each package renders its own menu parts so they share the same bundled context. The Widgets screen keeps its legacy menu when extensions fill the existing Tools slot; arbitrary legacy items cannot participate in the new Menu's keyboard navigation.
Includes the same toolbar and Customizer overlay compatibility fixes as #82966 so this PR can be tested and merged independently.
Testing Instructions
Activate a classic theme (ie TwentyTwentySeventeen)
Open Appearance → Widgets and its Options menu. Toggle Top toolbar, Contain text cursor inside block, Use theme styles, and Display block breadcrumbs. Check that their selected states and behavior update, and that preference changes are announced. Open Keyboard shortcuts and Welcome Guide; each dialog should remain open after the menu closes. Check the Help link.
Repeat the available controls in the Widgets Customizer, including with a block selected. Extensions using
EditWidgetsToolsMoreMenuGroupshould retain their existing actions and navigation.Testing Instructions for Keyboard
Open Options with Enter. Navigate with arrow keys and toggle a preference with Space. Escape should close the menu and return focus to Options. After opening and dismissing Keyboard shortcuts, focus should return to Options. In the Customizer, verify the Options trigger remains part of the Document tools toolbar navigation.
Screenshots
Use of AI Tools
Implemented and verified with OpenAI Codex.