Repository navigation
Repair wp/6.9 branch Actions: Remove obsolete and trunk-only workflows - #82864
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
There was a problem hiding this comment.
🔵 Needs a closer look
Gradle wrapper validation is removed despite active Android tooling, and orphaned Dependabot ignores remain.
Pull request overview
This PR removes obsolete, disabled, and trunk-only GitHub Actions workflows from wp/6.9.
Changes:
- Removes disabled React Native runners and Gradle validation.
- Removes trunk-only release, deployment, changelog, synchronization, cherry-pick, and stale-issue workflows.
File summaries
| File | Change |
|---|---|
.github/workflows/upload-release-to-plugin-repo.yml |
Removes plugin release upload automation. |
.github/workflows/sync-backport-changelog.yml |
Removes trunk backport synchronization. |
.github/workflows/sync-assets-to-plugin-repo.yml |
Removes trunk asset synchronization. |
.github/workflows/storybook-pages.yml |
Removes trunk Storybook deployment. |
.github/workflows/stale-issue-gardening.yml |
Removes scheduled issue maintenance. |
.github/workflows/rnmobile-ios-runner.yml |
Removes disabled iOS E2E workflow. |
.github/workflows/rnmobile-android-runner.yml |
Removes disabled Android E2E workflow. |
.github/workflows/gradle-wrapper-validation.yml |
Removes Gradle wrapper validation. |
.github/workflows/cherry-pick-wp-release.yml |
Removes trunk cherry-pick automation. |
.github/workflows/check-dataviews-changelog.yml |
Removes trunk-only DataViews changelog checks. |
.github/workflows/check-components-changelog.yml |
Removes trunk-only Components changelog checks. |
.github/workflows/check-backport-changelog.yml |
Removes trunk-only Core backport changelog checks. |
Review details
Suppressed comments (2)
.github/workflows/gradle-wrapper-validation.yml:1
- This cleanup leaves the
ignoreentries foractions/setup-java,gradle/*,reactivecircus/*, andruby/setup-rubyin.github/dependabot.yml:16-20, even though no remaining workflow uses them. Please remove those orphaned ignores in the same change so Dependabot configuration matches the workflows still present.
.github/workflows/gradle-wrapper-validation.yml:1 - Unlike trunk, this branch still contains Gradle wrappers (
packages/react-native-editor/android/gradle/wrapper/gradle-wrapper.jarandgradlew), andpackages/react-native-editor/package.json:118invokes./gradlew. Removing the onlygradle/actions/wrapper-validationcheck therefore drops integrity validation for an active Android toolchain; please retain this workflow or replace it with an equivalent path-scoped check rather than treating it as orphaned.
- Files reviewed: 12/12 changed files
- Comments generated: 0
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
98538ba to
3396f59
Compare
3396f59 to
54fa424
Compare
…ll_request_target` runs always use the workflow file from trunk, so this branch's copies never run.
16f8b13 to
ce155ae
Compare
lucatume
left a comment
There was a problem hiding this comment.
Keeping the wrappers following comment on 6.2 PR.
Part of #82785.
What?
This removes several GitHub Actions workflows from the
wp/6.9branch.rnmobile-ios-runner.ymlif: false; hasn't executed since before this branch existedrnmobile-android-runner.ymlif: false; hasn't executed since before this branch existedgradle-wrapper-validation.ymlstorybook-pages.ymlpush: branches: [trunk]only — a single deploy target, not per-branchcheck-components-changelog.ymlpackages/componentspull_request: branches: [trunk]onlycheck-backport-changelog.ymllib//phpunit/pull_request: branches: [trunk]onlycheck-dataviews-changelog.ymlpackages/dataviewspull_request: branches: [trunk]onlyupload-release-to-plugin-repo.ymlwp/X.Ybranchessync-assets-to-plugin-repo.ymlpush: branches: [trunk], paths: [assets/**]onlycherry-pick-wp-release.ymlwp/X.Ybrancheswp/X.Ybranches are its destination, never its triggersync-backport-changelog.ymlpush: branches: [trunk], plus anissues: labeledtrigger that isn't tied to any git ref, so GitHub always runs it from the default branch's copystale-issue-gardening.ymlschedule-triggered workflows only ever run using the default branch's copyperformance.ymlpull-request-automation.ymlpull_request_targetruns always use trunk's copy of the file, and itspush-triggered tasks return immediately outsidetrunk, so this branch's copy never does anythingenforce-pr-labels.yml[Type]label on each pull requestpull_request_targetonly, and those runs always use trunk's copy of the file, so this branch's copy never runsbuild-plugin-zip.ymllatestpublish)trunkor arelease/*branch, so they never run fromwp/X.YWhy?
These workflows are not relevant to the branch, mostly due to the fact that they only run from
trunk, or are not meant for running with non-latest code, or are only maintained for the current WordPress release (performance testing). Removing them also cuts down on the long-term maintenance burden, and avoids causing confusion.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.