Skip to content

Redo "Framework: Update Node.js to v24 LTS and npm to v11" - #82370

Merged
manzoorwanijk merged 1 commit into
trunkfrom
update/redo-node-24-upgrade
Sep 8, 2026
Merged

manzoorwanijk merged 1 commit into
trunkfrom
update/redo-node-24-upgrade

Conversation

@manzoorwanijk

@manzoorwanijk manzoorwanijk commented Sep 3, 2026 •

Copy link
Copy Markdown
Member

What?

We tried to upgrade to Node 24 in #80395 but had to revert it in #82355 due to some build failures in wordpress-develop. This PR makes the change ready to be redone.

Why?

See #80395

How?

See #80395

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Before After

Use of AI Tools

@manzoorwanijk manzoorwanijk self-assigned this Sep 3, 2026
@manzoorwanijk manzoorwanijk added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Build Tooling Issues or PRs related to build tooling Require PR update Forces open PRs to update from trunk labels Sep 3, 2026
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

🤖 PR meta 🤖

📦 Bundle size

Size Change: 0 B

Total Size: 8 MB

fbd8563 Run

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric cab63aa trunk % Change
timeToFirstByte 71.5 ms +6.57% -12.87% 62.4 ms +15.46% -5.05% 14.58%
largestContentfulPaint 104 ms +7.69% -5.77% 98 ms +10.2% -6.12% 6.12%
lcpMinusTtfb 33.7 ms +10.24% -3.41% 32.95 ms +15.17% -3.95% 2.28%
wpBeforeTemplate 37.59 ms +2.87% -17.53% 30.13 ms +23.73% -2.49% 24.76%
wpTemplate 27.76 ms +6.7% -4.43% 26.85 ms +6.85% -3.61% 3.39%
wpTotal 66.01 ms +7.07% -11.47% 58.55 ms +13.99% -5.38% 12.74%
wpMemoryUsage 7.52 MB +0% -0% 7.48 MB +0% -0% 0.46%
wpDbQueries 17 +0% -0% 17 +0% -0% 0%

front-end-classic-theme

Metric cab63aa trunk % Change
timeToFirstByte 47.35 ms +8.66% -2.22% 48.9 ms +6.13% -5.42% -3.17%
largestContentfulPaint 96 ms +4.17% -0% 96 ms +6.25% -0% 0%
lcpMinusTtfb 48.5 ms +2.27% -4.74% 48.6 ms +2.78% -4.22% -0.21%
wpBeforeTemplate 27.92 ms +1.86% -1% 28.7 ms +11.18% -4.84% -2.72%
wpTemplate 16.26 ms +7.07% -4% 16.09 ms +5.84% -4.16% 1.06%
wpTotal 44.16 ms +8.56% -2.29% 45.74 ms +5.38% -5.57% -3.45%
wpMemoryUsage 5.51 MB +0% -0% 5.47 MB +0% -0% 0.64%
wpDbQueries 14 +0% -0% 14 +0% -0% 0%

media-processing

Metric cab63aa trunk % Change
mediaProcessingJpeg 415.01 ms +0.44% -1.63% 408.36 ms +0.52% -1.16% 1.63%
mediaProcessingAvif 6135.33 ms +0.51% -0.19% 6103.03 ms +0.14% -0.31% 0.53%
mediaProcessingJpegToAvif 4232.06 ms +0.92% -0.1% 4228.22 ms +0.43% -0.46% 0.09%

media-upload

Metric cab63aa trunk % Change
jpegUploadProcessing 1701.48 ms +16.04% -16.25% 1435.24 ms +0.78% -0.24% 18.55%
pngUploadProcessing 227.95 ms +4.33% -3.9% 230.47 ms +14.44% -3.66% -1.09%
largeJpegUploadProcessing 1422.12 ms +0.95% -0.46% 1461.13 ms +0.75% -1.91% -2.67%
multipleImageUploadProcessing 1609.89 ms +1.38% -0.25% 2087.62 ms +0.81% -22.18% -22.88%

post-editor

Metric cab63aa trunk % Change
serverResponse 509.95 ms +9.46% -5.5% 551.26 ms +1.52% -5.85% -7.49%
firstPaint 249.62 ms +23.75% -15.62% 288.3 ms +57.33% -25.54% -13.42%
domContentLoaded 1354.56 ms +0.77% -0.46% 1395.8 ms +0.89% -0.97% -2.95%
loaded 1356.08 ms +0.76% -0.46% 1397.31 ms +0.88% -0.97% -2.95%
firstContentfulPaint 445.05 ms +1.6% -1.91% 453.57 ms +4.26% -0.18% -1.88%
firstBlock 3760.43 ms +1.19% -0.8% 3784.76 ms +0.21% -0.77% -0.64%
type 17.57 ms +3.93% -6.03% 17.53 ms +3.31% -4.39% 0.23%
typeWithoutInspector 16.36 ms +8.13% -7.95% 17.26 ms +8.86% -2.95% -5.21%
typeWithTopToolbar 20.19 ms +2.48% -7.23% 20.66 ms +7.07% -6.78% -2.27%
typeContainer 10.2 ms +8.04% -5.69% 10.01 ms +5.99% -7.89% 1.9%
focus 86.56 ms +10.92% -8.5% 83.29 ms +20.96% -6.29% 3.93%
firstFocus 185.39 ms +0% -0% 187.37 ms +0% -0% -1.06%
selectAll 644.61 ms +1.79% -4.33% 631.35 ms +1.23% -0.23% 2.1%
listViewOpen 74.31 ms +8.57% -7.81% 77.03 ms +16.34% -7.93% -3.53%
inserterOpen 27.34 ms +2.82% -15.95% 24.83 ms +5.16% -8.7% 10.11%
inserterHover 4.3 ms +8.37% -12.79% 4.35 ms +21.38% -8.05% -1.15%
inserterSearch 8.83 ms +20.16% -7.47% 8.58 ms +8.74% -5.94% 2.91%
loadPatterns 664.9 ms +6.54% -4.11% 654.97 ms +3.27% -0.61% 1.52%
wpTotal 499.6 ms +9.59% -5.52% 540.15 ms +1.66% -5.7% -7.51%
wpMemoryUsage 13.06 MB +0% -0% 13.02 MB +0% -0% 0.28%
wpDbQueries 54 +0% -1.85% 54 +0% -1.85% 0%

site-editor

Metric cab63aa trunk % Change
serverResponse 426.28 ms +2.31% -9.27% 423.76 ms +4.81% -8% 0.59%
firstPaint 225.03 ms +27.28% -5.7% 249.29 ms +16.21% -17.33% -9.73%
domContentLoaded 1413.08 ms +2.41% -1.2% 1436.58 ms +0.95% -1.46% -1.64%
loaded 1414.37 ms +2.4% -1.19% 1437.93 ms +0.94% -1.47% -1.64%
firstContentfulPaint 439.83 ms +2.41% -1.02% 458.73 ms +0.97% -3.31% -4.12%
firstBlock 4409.71 ms +0.75% -1.49% 4422.51 ms +1.89% -0.52% -0.29%
type 16.31 ms +4.6% -10.73% 16.08 ms +5.6% -3.54% 1.43%
navigate 102.71 ms +2.16% -3.33% 109.02 ms +26.77% -1.3% -5.79%
loadPatterns 1424.35 ms +5.55% -9.25% 1510 ms +7.8% -13.93% -5.67%
loadPages 1176.42 ms +4.24% -3.34% 1138.21 ms +4.85% -2.01% 3.36%
wpTotal 414.57 ms +2.56% -9.27% 412.71 ms +5.04% -8.26% 0.45%
wpMemoryUsage 12.07 MB +0% -0% 12.03 MB +0% -0% 0.27%
wpDbQueries 43 +2.33% -0% 43 +2.33% -0% 0%

fbd8563 Run

@manzoorwanijk
manzoorwanijk force-pushed the update/redo-node-24-upgrade branch from 4afe20c to fbd8563 Compare September 8, 2026 12:45
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review September 8, 2026 16:27
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org>
Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@manzoorwanijk
manzoorwanijk merged commit 5715a61 into trunk Sep 8, 2026
77 checks passed
@manzoorwanijk
manzoorwanijk deleted the update/redo-node-24-upgrade branch September 8, 2026 16:39
@github-actions github-actions Bot added this to the Gutenberg 24.0 milestone Sep 8, 2026
manzoorwanijk added a commit that referenced this pull request Sep 9, 2026
Node.js was updated to v24 LTS in #82370, so align the type definitions
with the runtime the repository builds and tests against.

Bumps every workspace's `@types/node` devDependency to ^24.13.3 and
relaxes the `@wordpress/e2e-test-utils-playwright` peerDependency to
^24.0.0.
manzoorwanijk added a commit that referenced this pull request Sep 9, 2026
Node.js was updated to v24 LTS in #82370, so align the type definitions
with the runtime the repository builds and tests against.

Bumps every workspace's `@types/node` devDependency to ^24.13.3 and
relaxes the `@wordpress/e2e-test-utils-playwright` peerDependency to
^24.0.0.
manzoorwanijk added a commit that referenced this pull request Sep 9, 2026
* Framework: Update @types/node to v24

Node.js was updated to v24 LTS in #82370, so align the type definitions
with the runtime the repository builds and tests against.

Bumps every workspace's `@types/node` devDependency to ^24.13.3 and
relaxes the `@wordpress/e2e-test-utils-playwright` peerDependency to
^24.0.0.

* Add the PR reference to the changelog entry

* Widen the e2e-test-utils-playwright `@types/node` peer range to >=20

The package's own `engines.node` is still >=18.12.0 and its public types
only touch long-stable Node APIs, so pinning the peer to a single major
would break consumers on older type definitions for no gain.

Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Framework Issues related to broader framework topics, especially as it relates to javascript Require PR update Forces open PRs to update from trunk [Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants