Skip to content

Packages: Complete the tsconfig build and dev project split - #81517

Merged
manzoorwanijk merged 6 commits into
update/split-tsconfigs-story-packagesfrom
update/split-tsconfigs-completion
Aug 19, 2026
Merged

manzoorwanijk merged 6 commits into
update/split-tsconfigs-story-packagesfrom
update/split-tsconfigs-completion

Conversation

@manzoorwanijk

Copy link
Copy Markdown
Member

What?

Part of #81473. Built on top of #81516.

Completes the tsconfig split: migrates the last two packages, abilities and interactivity-router, and moves the root noEmit projects out of the build solution.

Why?

With every package migrated, the build solution should compile only what emits; storybook, e2e, performance, and widgets projects only need checking.

How?

  • abilities and interactivity-router gain the split layout; the latter's package solution becomes its dev project over the existing tsconfig.main.json and tsconfig.full-page.json build projects.
  • storybook, test/e2e, test/performance, test/storybook-playwright, and widgets move from the build solution to the root dev solution.
  • Build projects that override exclude repeat the dev paths, which custom excludes had been dropping; no test or story declarations remain in build-types anywhere.

Testing Instructions

npm install
npm run clean:package-types && npm run typecheck
npm run clean:package-types && npm run build
npm run lint:tsconfig

Confirm no dev declarations are emitted anywhere:

find packages/*/build-types \( -path '*stories*' -o -path '*test*' -o -name '*.story.*' \) -name '*.d.ts' | wc -l

@manzoorwanijk
manzoorwanijk force-pushed the update/split-tsconfigs-completion branch from fd5f105 to 21aca6b Compare August 12, 2026 14:14
@github-actions github-actions Bot added [Package] Core data /packages/core-data [Package] Block library /packages/block-library [Package] Edit Site /packages/edit-site [Package] Interactivity Router /packages/interactivity-router [Package] Sync /packages/sync labels Aug 12, 2026
@manzoorwanijk manzoorwanijk self-assigned this Aug 12, 2026
@manzoorwanijk manzoorwanijk added the [Type] Build Tooling Issues or PRs related to build tooling label Aug 12, 2026
@github-actions

github-actions Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

Size Change: +1 B (0%)

Total Size: 7.73 MB

📦 View Changed
Filename Size Change
build/modules/interactivity-router/index.min.js 11.9 kB +1 B (+0.01%)

compressed-size-action

@manzoorwanijk
manzoorwanijk force-pushed the update/split-tsconfigs-completion branch from 21aca6b to 944b573 Compare August 12, 2026 14:42
@manzoorwanijk
manzoorwanijk force-pushed the update/split-tsconfigs-completion branch 2 times, most recently from d40083b to 4ae1ac0 Compare August 12, 2026 15:00
@manzoorwanijk
manzoorwanijk force-pushed the update/split-tsconfigs-completion branch 2 times, most recently from 46210a1 to 48ecc9b Compare August 12, 2026 15:21
@github-actions

github-actions Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

Flaky tests detected in 7e885ba.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/32205302816
📝 Reported tests:

two users concurrently move list items (RTC WebSocket) in /test/e2e/specs/editor/collaboration/collaboration-stress.spec.ts, passed after 1 failed attempt.
Error: expect(received).toBeGreaterThan(expected)

Expected: > 2
Received:   1

Call Log:
- Timeout 10000ms exceeded while waiting on the predicate
    at assertMovedOrder (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/collaboration/collaboration-stress.spec.ts:646:8)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/collaboration/collaboration-stress.spec.ts:650:10

@manzoorwanijk
manzoorwanijk force-pushed the update/split-tsconfigs-completion branch from 48ecc9b to 4092638 Compare August 13, 2026 13:34
@manzoorwanijk
manzoorwanijk force-pushed the update/split-tsconfigs-completion branch from 4092638 to e180abd Compare August 13, 2026 13:59
@manzoorwanijk
manzoorwanijk force-pushed the update/split-tsconfigs-completion branch from e180abd to 62242e8 Compare August 14, 2026 11:55
@manzoorwanijk
manzoorwanijk force-pushed the update/split-tsconfigs-completion branch from 62242e8 to cac8c5c Compare August 14, 2026 12:22
@manzoorwanijk
manzoorwanijk force-pushed the update/split-tsconfigs-completion branch from cac8c5c to 8aa4a09 Compare August 14, 2026 14:51
@manzoorwanijk
manzoorwanijk force-pushed the update/split-tsconfigs-completion branch from 2bf35ae to a4396ee Compare August 17, 2026 08:50
Comment thread packages/abilities/tsconfig.json Resolved
Comment thread packages/abilities/tsconfig.build.json Resolved
@manzoorwanijk
manzoorwanijk force-pushed the update/split-tsconfigs-completion branch from 5801bd4 to 96e29a6 Compare August 18, 2026 01:02
@manzoorwanijk
manzoorwanijk force-pushed the update/split-tsconfigs-completion branch 2 times, most recently from 1884f71 to cffc9e4 Compare August 18, 2026 01:25
@manzoorwanijk
manzoorwanijk force-pushed the update/split-tsconfigs-completion branch from cffc9e4 to 053d330 Compare August 18, 2026 02:26
@manzoorwanijk
manzoorwanijk force-pushed the update/split-tsconfigs-completion branch from 053d330 to a9f3dad Compare August 18, 2026 02:37
Migrates the last two packages, abilities and interactivity-router, and
moves the root noEmit projects (storybook, e2e, performance, widgets)
from the build solution to the dev solution so the build stops checking
them. Build projects that override exclude now repeat the dev paths,
which custom excludes had been dropping; no test or story declarations
remain in build-types anywhere.
report-flaky-tests kept its jest tests unchecked behind an exclude; they
move to a dev project. media-fields' build project carried jest and
test-env ambient types, which belong to its dev project.
Add the shared dev-file patterns while keeping the package-specific
entries.
The abilities dev project narrowed its include to one test directory
and .ts files, dropping the other shapes and every .tsx; its build
project listed a file that no longer exists and a pattern the shared
exclude covers. The interactivity-router dev project turned strict off
for every test; two comparators get their parameter types instead.

@tyxla tyxla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me now 👍 Thanks @manzoorwanijk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Block library /packages/block-library [Package] Edit Site /packages/edit-site [Package] Interactivity Router /packages/interactivity-router [Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants