Skip to content

Site Editor: Decode HTML entities in Identity fields (#81269) - #81320

Merged
ntsekouras merged 1 commit into
WordPress:wp/7.1from
drewmt:backport/81269-wp-7-1
Aug 7, 2026
Merged

ntsekouras merged 1 commit into
WordPress:wp/7.1from
drewmt:backport/81269-wp-7-1

Conversation

@drewmt

@drewmt drewmt commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

What?

Manual backport of #81269 to wp/7.1 after the automatic cherry-pick encountered changelog conflicts.

The two source changes match the merged commit 8323351f. The manual resolution only keeps the wp/7.1 package history while adding both bug-fix entries under Unreleased.

Why?

Identity REST values can contain strings such as Jordan's Test or Logo & Mark. Without local display-time decoding, the WordPress 7.1 Identity screen shows those entities literally.

How?

  • Decode Site Title and Site Tagline values in their local Identity field getters.
  • Decode media attachment titles in the compact filename and accessible replacement label used by Site Logo and Site Icon.
  • Leave source records, URLs, alt text, validation, and unrelated DataForm fields unchanged.

Testing Instructions

Automated checks run locally:

  • Cherry-picked only the final merged commit from Site Editor: Decode HTML entities in Identity fields #81269.
  • The complete pre-commit hook passed.
  • Targeted JavaScript/TypeScript lint passed for both source files.
  • Focused source formatting checks passed; both added changelog entries match
    the repository format.
  • git diff --check passed; the backport changes exactly four files.

No new tests or dependencies are introduced, following the review guidance on the original PR.

Manual verification:

  1. Open the Site Editor and go to Design → Identity.
  2. Save a Site Title and Site Tagline containing &, ', or angle brackets.
  3. Reload Identity and confirm both text fields show readable characters rather than HTML entities.
  4. Select a Site Logo and Site Icon whose attachment title contains &.
  5. Confirm the selected media filename shows & rather than &.
  6. Save and reload, then confirm all four values remain readable and editable.

Testing Instructions for Keyboard

  1. Tab through the Site Title and Site Tagline inputs and edit the values.
  2. Use the keyboard to choose or replace the Site Logo and Site Icon.
  3. Confirm the media replacement control has a readable accessible name and the form remains fully operable.

Screenshots or screencast

The verified before/after comparison is available in the original approved PR.

Use of AI Tools

OpenAI Codex assisted with the conflict review and validation. I reviewed the final four-file diff and take responsibility for the contribution.

Co-authored-by: drewmt <linewebdigital@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: jordesign <jordesign@git.wordpress.org>
@github-actions github-actions Bot added [Package] Edit Site /packages/edit-site [Package] Fields /packages/fields labels Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: drewmt <linewebdigital@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ntsekouras ntsekouras left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up!

Unfortunately, automatic cherry-picking can fail due to conflicts in the CHANGELOG file, which may require manual backporting 😅

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Aug 7, 2026
@ntsekouras
ntsekouras merged commit d3f5d0b into WordPress:wp/7.1 Aug 7, 2026
50 checks passed
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Aug 12, 2026
This updates the pinned commit hash of the Gutenberg repository from `ea285b45692aed6c4f95353671393402f97f0aa7` to `b9743a015526ac8fd79298fd4e96cf002cee333b`.

A full list of changes included in this commit can be found on GitHub: 
WordPress/gutenberg@ea285b4...b9743a0

- Style states: fix state deselection when selecting the already selected block (WordPress/gutenberg#81277)
- Global styles: render element styles set only inside a breakpoint (WordPress/gutenberg#81265)
- Style states: Fix phantom pseudo element style output (WordPress/gutenberg#81291)
- Docs: remove breakpoint-only element style example from global styles guide (WordPress/gutenberg#81308)
- theme.json schema: responsive states belong to blocks (WordPress/gutenberg#81253)
- theme.json schema: allow responsive states on block style variations (WordPress/gutenberg#81309)
- Render viewport state element styles in the editor (WordPress/gutenberg#81307) (WordPress/gutenberg#81311)
- Site Editor: Decode HTML entities in Identity fields (WordPress/gutenberg#81269) (WordPress/gutenberg#81320)
- Editor: Keep the canvas height stable while resizing the canvas (WordPress/gutenberg#81374)
- Playlist: Normalize Waveform Player configuration handling (WordPress/gutenberg#81375)
- Playlist: Improve audio conversion and track selection (WordPress/gutenberg#80926) (WordPress/gutenberg#81385)
- fix: order site identity changes predictably (WordPress/gutenberg#81283)
- Cover: Avoid passing null as the featured image size (WordPress/gutenberg#81444)
- components/Menu: Restore Modal focus return when menu items close (WordPress/gutenberg#81446)
- Notes: Fix text wrapping for long usernames in collaboration sidebar (WordPress/gutenberg#81406)
- Site Editor: Use inverted ThemeProvider seed for portaled UI (WordPress/gutenberg#81296)

Props wildworks.
See #65529.

git-svn-id: https://develop.svn.wordpress.org/branches/7.1@63209 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Aug 12, 2026
This updates the pinned commit hash of the Gutenberg repository from `ea285b45692aed6c4f95353671393402f97f0aa7` to `b9743a015526ac8fd79298fd4e96cf002cee333b`.

A full list of changes included in this commit can be found on GitHub: 
WordPress/gutenberg@ea285b4...b9743a0

- Style states: fix state deselection when selecting the already selected block (WordPress/gutenberg#81277)
- Global styles: render element styles set only inside a breakpoint (WordPress/gutenberg#81265)
- Style states: Fix phantom pseudo element style output (WordPress/gutenberg#81291)
- Docs: remove breakpoint-only element style example from global styles guide (WordPress/gutenberg#81308)
- theme.json schema: responsive states belong to blocks (WordPress/gutenberg#81253)
- theme.json schema: allow responsive states on block style variations (WordPress/gutenberg#81309)
- Render viewport state element styles in the editor (WordPress/gutenberg#81307) (WordPress/gutenberg#81311)
- Site Editor: Decode HTML entities in Identity fields (WordPress/gutenberg#81269) (WordPress/gutenberg#81320)
- Editor: Keep the canvas height stable while resizing the canvas (WordPress/gutenberg#81374)
- Playlist: Normalize Waveform Player configuration handling (WordPress/gutenberg#81375)
- Playlist: Improve audio conversion and track selection (WordPress/gutenberg#80926) (WordPress/gutenberg#81385)
- fix: order site identity changes predictably (WordPress/gutenberg#81283)
- Cover: Avoid passing null as the featured image size (WordPress/gutenberg#81444)
- components/Menu: Restore Modal focus return when menu items close (WordPress/gutenberg#81446)
- Notes: Fix text wrapping for long usernames in collaboration sidebar (WordPress/gutenberg#81406)
- Site Editor: Use inverted ThemeProvider seed for portaled UI (WordPress/gutenberg#81296)

Props wildworks.
See #65529.
Built from https://develop.svn.wordpress.org/branches/7.1@63209


git-svn-id: http://core.svn.wordpress.org/branches/7.1@62402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Package] Edit Site /packages/edit-site [Package] Fields /packages/fields [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants