Repository navigation
Conversation
|
Size Change: +1 B (0%) Total Size: 7.81 MB 📦 View Changed
|
Member
Author
|
Closing in favor of wrapping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Marks the Site Editor's root
ThemeProviderasisRoot.Follow up to #81112
Why?
The Site Editor already wraps its layout in a root
ThemeProviderseeded with admin theme colors, but it was missingisRoot. Without it, design tokens are scoped to the provider's wrapper div and are not forwarded to the document element. Portaled UI (modals, popovers, tooltips) rendered outside the React subtree cannot inherit those tokens.The post editor and widgets editors already use
isRooton their root providers. This brings the Site Editor in line with them.Testing Instructions
npm start)./wp-admin/site-editor.php).