Repository navigation
Conversation
…rtion order, setting both via `Heading` props.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +17 B (0%) Total Size: 7.75 MB 📦 View Changed
|
|
This issue appears to be related to #79443. Let's fix it in the 7.1 release cycle. |
| return ( | ||
| <HStack { ...headerProps } ref={ forwardedRef }> | ||
| <Heading level={ headingLevel } className={ headingClassName }> | ||
| <Heading |
There was a problem hiding this comment.
Can this be replaced with a Text component from wp-ui?
|
Would this actually be fixed by the migration of ToolsPanel to CSS modules in #80445 ? I believe that is supposed to be the accepted approach to fixing components that were broken by moving View away from Emotion. |
Oh there it is. I could've sworn we fixed this somewhere but I somehow couldn't find that 🙈 |
|
I'd vote for closing this in favour of the CSS modules approach in #80445, then. Just my two cents though |
|
Closing this in favour of #80445 |
|
Thank you all for reviewing! Makes sense, I wasn't aware of that initiative 🫡 |

What?
The ToolsPanel header sometimes renders much bigger than it should. Right now it's visible if you go to Global Styles > Layout and you see the "Dimensions" title
Why?
ToolsPanelHeadingis settingfont-size: inheritto override the size heading sets on itself. Those two end up as separate emotion classes with the same specificity, and they don't get merged. So whichever one is inserted into the stylesheet last wins. The order isn't guaranteed, so you could get 13px or 25px depending on that.I also noticed
line-height: normalin the same block has exactly the same problem, and it was already losing toline-height: 1.4fromText. So that one was silently broken too. Leftfont-weightalone since it wasn't part of the problem, but we could also do it with it for consistency.How?
Setting the values through props rather than trying to win the specificity.
Testing Instructions
Screenshots or screencast