Skip to content

Packages: Extract @wordpress/nux package - #8016

Merged
gziolo merged 4 commits into
masterfrom
update/nux-package
Jul 20, 2018
Merged

gziolo merged 4 commits into
masterfrom
update/nux-package

Conversation

@gziolo

@gziolo gziolo commented Jul 18, 2018

Copy link
Copy Markdown
Member

Description

Part of #3955.

This PR extracts new @wordpress/nux package.

How has this been tested?

npm test and make sure there are no regressions.

Make sure you can see the tips when you load new post (make sure you have localstorage cleared before).

@gziolo gziolo added the npm Packages Related to npm packages label Jul 18, 2018
@gziolo gziolo added this to the 3.3 milestone Jul 18, 2018
@gziolo gziolo self-assigned this Jul 18, 2018
@gziolo
gziolo requested review from a team, ntwb and youknowriad July 18, 2018 11:14
Comment thread packages/nux/README.md
# @wordpress/nux

The NUX module exposes components, and `wp.data` methods useful for onboarding a new user to the WordPress admin interface. Specifically, it exposes _tips_ and _guides_.
The NUX (New User eXperience) module exposes components, and `wp.data` methods useful for onboarding a new user to the WordPress admin interface. Specifically, it exposes _tips_ and _guides_.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@tofumatt tofumatt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add an eslint rule to the .eslintrc that forbids imports from 'nux' and 'nux/*', similar to the other package import rules.

@aduth aduth modified the milestones: 3.3, 3.4 Jul 18, 2018
@gziolo

gziolo commented Jul 19, 2018 •

Copy link
Copy Markdown
Member Author

@tofumatt, an eslint rule added with 5236de7.

Edit: There was a similar rule already, I updated to use the more common pattern.

@gziolo
gziolo force-pushed the update/nux-package branch from f6829aa to 5236de7 Compare July 19, 2018 07:49
@gziolo
gziolo force-pushed the update/nux-package branch from 5236de7 to 1e2cee8 Compare July 19, 2018 09:39
@tofumatt

Copy link
Copy Markdown
Member

Edit: There was a similar rule already, I updated to use the more common pattern.

Oops, I didn't realise!

@gziolo

gziolo commented Jul 19, 2018

Copy link
Copy Markdown
Member Author

Thre is still some issue with loading CSS file with this config. I'm looking into it.

@gziolo

gziolo commented Jul 19, 2018

Copy link
Copy Markdown
Member Author

663f9d1 fixes the issue with missing CSS files. It's not great but should help us move forward with this one. It's exactly the same approach we took when moving components folder in #7640:
https://github.com/WordPress/gutenberg/blob/330a4cf23b3fba073038e4bab041ff612bef09c4/components/index.js

Let's open a follow up PR where we tackle copying CSS files generated by packages build step and add RTL support there, too.

@gziolo
gziolo requested a review from gwwar July 19, 2018 14:10

@youknowriad youknowriad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gziolo gziolo modified the milestones: 3.4, 3.3 Jul 20, 2018
@gziolo
gziolo merged commit f7a7e6b into master Jul 20, 2018
@gziolo
gziolo deleted the update/nux-package branch July 20, 2018 04:45
@gziolo

gziolo commented Jul 20, 2018

Copy link
Copy Markdown
Member Author

Opened #8067 to keep track of CSS workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

npm Packages Related to npm packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants