Repository navigation
DataViews: Make grid and table item preview aspect ratio configurable - #79329
ntsekouras merged 6 commits into
Conversation
0a12995 to
3ce3734
Compare
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @vianasw! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
3ce3734 to
54c2fd0
Compare
cb8fbd8 to
ef4af68
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @vianasw. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks for the PR! Let's also get some design feedback (@WordPress/gutenberg-design) and maybe @oandregal has thoughts too. |
|
At a glance, this seems valid enough to me, assuming it looks good with image-less placeholders too. It also addresses a point raised by Jay, who has worked with DataViews long enough that I trust his previously asserted instincts. 👍 |
b997531 to
21d6390
Compare
|
We'd need to update view-config schema to include this new prop. I think it's fine to handle as a follow-up, as there's no functional impact in the meantime. It also involves a couple of extra small changes, because the PHP layout schemas are shared between |
The grid layout's media preview is hard-coded to a `1/1` (square) aspect ratio. Some consumers need a different shape — e.g. a video library wants `16/9` to match how the media actually appears when embedded. Add an `aspectRatio` option to the grid `layout` config. It is applied uniformly to every item via a `--dataviews-grid-media-aspect-ratio` CSS custom property and defaults to `1/1`, so existing consumers are unaffected. This implements the uniform, consumer-set case from WordPress#60891 and leaves the user-facing toggle (and `auto`/variable per-item ratios) out of scope — that was the part that stalled the earlier attempt in WordPress#63487. Part of WordPress#60891 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add the aspectRatio layout option to ViewTable as well: the value is surfaced on the table element and read by the primary column's media styles, which switch from a fixed square (width/height) to height + aspect-ratio so row heights are unchanged and the preview widens instead. A 16/9 preview at the default height still fits the wrapper's existing max-width. Since the CSS custom property is now read by more than one layout, rename it from --dataviews-grid-media-aspect-ratio to --dataviews-media-aspect-ratio (safe pre-release: the original commit is part of this unmerged PR). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Constrain the aspectRatio layout option from a free-form string to a MediaAspectRatio union of preset ratios (1/1, 4/3, 3/4, 3/2, 2/3, 16/9, 9/16 — mirroring Core's default aspect-ratio presets), following the same pattern as the density option. Starting narrow is the safe API direction: widening the union later is backward compatible, while narrowing a shipped free-form string would be a breaking change. Runtime behavior is unchanged — the value still reaches CSS as a custom property. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The trunk merge landed while three @wordpress/dataviews releases had shipped since this branch was cut, so the entry's original surroundings (the old Unreleased section) had become the 17.0.0 section — taking the entry with them. Restore 17.0.0 to its released contents and list the entry under Unreleased, where the changelog CI check expects it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Rename the custom property to --wp-dataviews-media-aspect-ratio, matching the existing --wp-dataviews-color-background convention. - Always set the property (with the 1/1 default) on the grid and table roots, so an identically-named variable set by a consumer on an ancestor can't leak into previews when the view doesn't configure a ratio. - Gate the table media sizing behind a has-media-aspect-ratio modifier (same pattern as has-*-density): the base .dataviews-column-primary__media rules are restored to exactly what trunk ships, and the fixed-height + ratio sizing (with the img filling the box) only applies when the view sets layout.aspectRatio. Views without it see no change, including media renders taller than the 32px default. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…x sub-square table previews Address the second round of review feedback: - Add a shared MEDIA_ASPECT_RATIOS constant and derive the MediaAspectRatio type from it, so the runtime list and the type can't drift apart. Both layouts now validate layout.aspectRatio against the presets (like density) and fall back to the square default; the table only applies the has-media-aspect-ratio modifier for a valid preset. - Drop the redundant CSSProperties annotation in favor of the single cast, in both layouts. - Release the base rule's min-width under the has-media-aspect-ratio modifier: it equals the fixed height, so sub-square presets (3/4, 2/3, 9/16) derived a width below it and rendered square. - Widen the table's srcset sizes hint from the validated ratio: with a ratio configured the preview box is width-variable (up to the 60px max-width), and the hardcoded 32px hint made consumers that honor it pick an undersized, blurry source for wide ratios. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014CG2FSyrhQ581KmpSmjcco
f5cd7c4 to
bca4649
Compare
ntsekouras
left a comment
There was a problem hiding this comment.
This LGTM. Thanks for effort and the iterations! Great work!
|
👍 to prepare a follow-up with the schema changes. Heads up that I'm working on generating the docs and the PHP schema from the JSON schema at #81168 so, depending on timing, one of them will need rebase. |
Sounds good. I can open the follow up after your changes have landed. |
|
Congratulations on your first merged pull request, @vianasw! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
…#79329) Unlinked contributors: vianasw. Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org>
This updates the pinned commit hash of the Gutenberg repository from `5a0417990a9404cc2562cdd35e3054cb0d3e546e` (version `23.7.0`) to `ae8b34d78e1abc6d1c866fdc00080a1452de82ad` (version `23.8.0`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v23.7.0..v23.8.0. - Fix: New route-based admin pages are empty when no JS (WordPress/gutenberg#80628) - Report flaky tests: declare @types/node (WordPress/gutenberg#80838) - Storybook e2e: add small, compact and icon examples to button matrix (WordPress/gutenberg#80793) - ESLint: Drop @eslint/compat fixup for jest-dom and testing-library (WordPress/gutenberg#80842) - Storybook: Use SelectControl in Motion tokens story (WordPress/gutenberg#80790) - Writing flow: forward delete an empty paragraph without breaking apart the next block (WordPress/gutenberg#80813) - ToggleControl: Add "With Visual" Storybook story (WordPress/gutenberg#80803) - Bump the github-actions group across 1 directory with 5 updates (WordPress/gutenberg#80684) - Update Ariakit packages (WordPress/gutenberg#80765) - Components: Update Floating UI to 2.1.9 (WordPress/gutenberg#80761) - Improve pre-flight npm access checks (WordPress/gutenberg#80334) - Ensure static checks can run for private mirrors (WordPress/gutenberg#80817) - Components: Update react-day-picker to 9.14.0 (WordPress/gutenberg#80792) - Testing: Remove the jest-puppeteer-axe package (WordPress/gutenberg#80775) - Tools: Use native agent skill discovery (WordPress/gutenberg#80811) - Table of Contents: Replace "Convert to static list" with confirmed "Detach" action (WordPress/gutenberg#80844) - Page List: Rename the Edit action to Detach and confirm it in a dialog (WordPress/gutenberg#80847) - URLInput: Simplify keyboard handling and fix arrow keys with a text selection (WordPress/gutenberg#80780) - Upload Media: Fail the item when the /finalize request fails (WordPress/gutenberg#80725) - Jest preset: support self-referencing via exports (WordPress/gutenberg#80837) - Fix template `modified` and `date` return value for file templates (WordPress/gutenberg#80733) - Element: Make the package importable in React 19 (WordPress/gutenberg#80053) - Add CheckboxControl with-visual Storybook story. (WordPress/gutenberg#80849) - UI: Add Combobox.InputGroup primitive (WordPress/gutenberg#80869) - Block Editor: Clear the moving animation's z-index when it finishes (WordPress/gutenberg#80824) - SearchableChipSelect: Add form primitive to @wordpress/ui (WordPress/gutenberg#80779) - Playlist: Add track icon (WordPress/gutenberg#80959) - Flaky tests: fix router navigate latest HTML (WordPress/gutenberg#80178) - Components: Update polymorphism types to allow all attributes when specifying `as` (WordPress/gutenberg#80705) - Block JSON schema & PHP-only blocks: Add `autoRegister` support (WordPress/gutenberg#80173) - Boot: Adjust specificity of the image reset styles so components can size their own images (WordPress/gutenberg#80845) - Components: Opt-in ConfirmDialog for auto-documentation (WordPress/gutenberg#80866) - RichText: don't apply input transform when there's no onReplace (WordPress/gutenberg#80978) - Quote: Ensure paragraph placeholder appears after deleting nested blocks (WordPress/gutenberg#77151) - Block editor: make the Group action wrap blocks with a group transform (WordPress/gutenberg#80891) - Copy: preserve the block when its entire text is selected (WordPress/gutenberg#80994) - Add opt-out for block style state controls (WordPress/gutenberg#80956) - Upgrade Playwright to v1.62 (WordPress/gutenberg#81001) - List View: Speed up opening by removing a forced style recalculation (WordPress/gutenberg#80929) - Widget Dashboard: preserve widget chrome flex layout (WordPress/gutenberg#80570) - Widget Primitives: document actions as verbs, not links (WordPress/gutenberg#80974) - Core Data: add missing @wordpress/base-styles dependency (WordPress/gutenberg#81012) - Ignore node_modules in schema integration test globs (WordPress/gutenberg#81013) - RichText: fix paste handler crash when pasting files (WordPress/gutenberg#81010) - Docs: Add VS Code setup guidance (WordPress/gutenberg#77913) - Perf Tests: Merge selection event windows instead of summing durations (WordPress/gutenberg#81002) - Storybook: move smoke-test deps into the storybook workspace (WordPress/gutenberg#81017) - Unit Tests: Reorganise the jest config file. (WordPress/gutenberg#80940) - Performance Tests: Ignore the locally generated artifacts directory (WordPress/gutenberg#81024) - Editor: Remove sidebar tabs focus sync effect (WordPress/gutenberg#81020) - Widgets: carry a declarative `icon` through the widget pipeline (WordPress/gutenberg#80969) - RTC: Remove excess autosave notices (when not useful) (WordPress/gutenberg#80539) - UI: Use focus styles from base-styles (WordPress/gutenberg#80635) - Automated Testing: Add Storybook component documentation regression testing (WordPress/gutenberg#80655) - Pass Playlist controls to track blocks (WordPress/gutenberg#80368) - Components: Deprecate Surface (WordPress/gutenberg#80943) - Tabs: Support Home and End keys for keyboard navigation (WordPress/gutenberg#80912) - Fix typos in code `comments` and `JSDoc` (WordPress/gutenberg#81045) - Interface: Remove incorrect aria-expanded from pin-to-toolbar button (WordPress/gutenberg#79874) - List View: Speed up opening by removing a second render pass (WordPress/gutenberg#80935) - Docs: Use `gutenberg` instead of `Gutenberg` in package name (WordPress/gutenberg#81051) - Fix ESLint warnings for 'navigateRegionsProps' spread (WordPress/gutenberg#81052) - Tests: Replace page-level selectors with locators in e2e specs (WordPress/gutenberg#81053) - RTC: Disable custom autosave controller when RTC is disabled (WordPress/gutenberg#80769) - Background: Fix the legacy gradient UI where a gradient cannot be selected (WordPress/gutenberg#81056) - Rename blockStatesEnabled setting to blockStatesEditingEnabled (WordPress/gutenberg#81058) - Background: Fix the legacy gradient UI where a gradient cannot be selected - Add missing change log (WordPress/gutenberg#81060) - Declare missing prettier and stylelint workspace dependencies (WordPress/gutenberg#81065) - Notes: Display shortcut for form action buttons (WordPress/gutenberg#81064) - View config: lowercase dynamic filter names (WordPress/gutenberg#81068) - CI: cache the system packages Playwright dowloads for WebKit (WordPress/gutenberg#80846) - List View: Collapse off-window placeholder rows into a single spacer row (WordPress/gutenberg#80953) - devops: balance Playwright shards by duration (WordPress/gutenberg#79479) - Views: honor developer-defined view config overrides (WordPress/gutenberg#80832) - Components: Migrate ItemGroup to SCSS module (WordPress/gutenberg#80797) - Test: Add Vitest migration routing guardrails (WordPress/gutenberg#81036) - Visual revisions: Add a code diff view inside the editor (WordPress/gutenberg#80314) - Bump actions/labeler from 6.1.0 to 7.0.0 in /.github/workflows (WordPress/gutenberg#80966) - Visual revisions: add shareable urls (WordPress/gutenberg#79934) - Fix e2e tests that break when shard rebalancing changes their neighbors (WordPress/gutenberg#81117) - Query: guard non-scalar queryId to avoid fatal in enhanced pagination (WordPress/gutenberg#80724) - Replace deprecated useResizeObserver for useScaleCanvas (WordPress/gutenberg#67508) - CI: Add job timeouts to E2E, static checks, bundle size, and create block (WordPress/gutenberg#80801) - Allow organization or repository variable to dictate the Actions runner (WordPress/gutenberg#81087) - List View: Only subscribe to the block subtree for rows that can show images (WordPress/gutenberg#81076) - Editor: Migrate settings sidebar to Tabs from @wordpress/ui (WordPress/gutenberg#81054) - Notes: Email users mentioned in a note (WordPress/gutenberg#79606) - List View: Narrow the dependants of the memoized List View tree (WordPress/gutenberg#81129) - List View: Pass only minimal required data to sub-tree branches (WordPress/gutenberg#81111) - DataViews: Add `time` field type and control (WordPress/gutenberg#80830) - Post Author Biography: Fix horizontal overflow with long unbroken text (WordPress/gutenberg#81018) - Link Control: Restore the preview title underline (WordPress/gutenberg#81083) - Views: Add React to the package's dev dependencies (WordPress/gutenberg#81139) - feat: Add target param in proxy (WordPress/gutenberg#81141) - Fix: flaky revisions pagination e2e cross-page diff assertion (WordPress/gutenberg#81119) - Button: Suppress UA focus ring when focused and pressed (WordPress/gutenberg#81113) - View config: add reference docs (WordPress/gutenberg#81149) - Editor: Fix document tools button focus ring (WordPress/gutenberg#81115) - List View: Replace expand/collapse callbacks with reducer dispatch (WordPress/gutenberg#81138) - CI: resolve Playwright through the workspace that declares it (WordPress/gutenberg#81137) - CI: build once and reuse the build across e2e tests shards (WordPress/gutenberg#81031) - Fix: Tabs block: Start with empty tab labels with placeholders (WordPress/gutenberg#81009) - Interface: Increase footer breadcrumb height to prevent focus ring clipping (WordPress/gutenberg#81145) - Editor: clarify autosave failure notice (WordPress/gutenberg#76470) - Theme: Omit color properties when neither provided nor inherited (WordPress/gutenberg#80600) - Post editor: Add ThemeProvider for admin color schemes (WordPress/gutenberg#81112) - Core Data: saveDirtyEntities: improve messaging of server errors (WordPress/gutenberg#81151) - Global Styles: kebab-case preset slugs when converting references to custom properties (WordPress/gutenberg#80583) - Revise CODEOWNERS for package ownership (removing nerrad) (WordPress/gutenberg#81175) - Build: Wrap script bundles in an IIFE to contain 'use strict' (WordPress/gutenberg#79792) - Media: Improve the HEIC upload error and keep any upload errors up until dismissed (WordPress/gutenberg#81130) - Block Supports: Guard against non-string attribute values to avoid fatal errors (WordPress/gutenberg#80501) - Video: Hide settings for the GIF variation (WordPress/gutenberg#81142) - Video: clarify the Video variation description (WordPress/gutenberg#81181) - Media Editor: Render sidebar tabs via ComplementaryArea's render prop (WordPress/gutenberg#81133) - Bump docker/login-action (WordPress/gutenberg#80962) - Bump actions/setup-node from 6.4.0 to 7.0.0 in /.github/setup-node (WordPress/gutenberg#80963) - fix(admin-ui): reset the wp-admin li margin that misaligns Breadcrumbs (WordPress/gutenberg#81134) - Bump astral-sh/setup-uv from 8.3.2 to 9.0.0 in /.github/workflows (WordPress/gutenberg#80964) - Fix/79643 rtc awareness mixed block selection (WordPress/gutenberg#79836) - Agents: Add a defensive data design skill and route to the copy guide (WordPress/gutenberg#81131) - ESLint: Ban `@ts-ignore` in favour of `@ts-expect-error` (WordPress/gutenberg#81148) - Types: Replace remaining `@ts-expect-error` suppressions with proper typing (WordPress/gutenberg#81200) - Button: turn on the width setting by default in theme.json (WordPress/gutenberg#81196) - Notes: fix the mention notification email composition (WordPress/gutenberg#81187) - Edit Widgets: Fix header toolbar button focus ring (WordPress/gutenberg#81176) - List View: Reduce per-row store subscriptions (WordPress/gutenberg#81136) - Customizer widgets: Add ThemeProvider for admin color schemes (WordPress/gutenberg#81174) - Blocks: Declare the `@types/react-is` devDependency (WordPress/gutenberg#81203) - Widgets editor: Add ThemeProvider for admin color schemes (WordPress/gutenberg#81173) - PanelColorSettings: Restore the missing space below the panel header (WordPress/gutenberg#81155) - Remove the editableRoot opt-in from the paragraph block (WordPress/gutenberg#81184) - Media Attached to: Fix issue with the popover unexpectedly flipping, tweak wording (WordPress/gutenberg#81206) - Components: Add allowForms prop to SandBox component (WordPress/gutenberg#76471) - Ensure device preview is always accurate when window is zoomed in (WordPress/gutenberg#81193) - DataViews: Pass only eligible items to a bulk action callback (WordPress/gutenberg#81198) - DataViews: Make grid and table item preview aspect ratio configurable (WordPress/gutenberg#79329) - Block Editor: Return false from isBlockSelected when there is no client ID (WordPress/gutenberg#81212) - Blocks: Update hpq to 1.4.0 and drop the ts-expect-error suppressions (WordPress/gutenberg#81199) - DataViews: Fix the between `date` filter losing a manually typed date on blur (WordPress/gutenberg#81150) - Block Editor: Fix Select all freezing on large posts (WordPress/gutenberg#81210) - List View: Split the context and drop dead props to cut re-renders on expand and collapse (WordPress/gutenberg#81159) - Docs: Fix broken Figma links on the design resources page. (WordPress/gutenberg#81166) - Blocks: Support static block templates in block type settings (WordPress/gutenberg#80027) - AGENTS: Update development tips section (WordPress/gutenberg#81224) - URLInput: Skip search requests while an IME composition is in progress (WordPress/gutenberg#80602) - Components: Deprecate Animate (WordPress/gutenberg#80931) - Fix: Trunk e2e failures caused by the navigation spec leaving plain permalinks (WordPress/gutenberg#81238) - Use p elements for callout alerts in components docs (WordPress/gutenberg#81234) - Storybook: Enable design system theme tool globally (WordPress/gutenberg#81116) - Media: Cover client-side big image scaling and orphaned files (WordPress/gutenberg#81061) - Footnotes: guard against invalid post meta values (WordPress/gutenberg#81201) - Block editor: unify what a new sibling block inherits (WordPress/gutenberg#81250) - Global Styles: Remove unused duplicate font family preview utilities (WordPress/gutenberg#81194) - Docs: explain how the theme.json schema fixtures work (WordPress/gutenberg#81263) - theme.json schema: fix block pseudo-classes and custom states (WordPress/gutenberg#81209) - List View: Migrate label wrapper to UI Stack and drop Badge from the anchor (WordPress/gutenberg#81266) - Docs: Remove dependency group import guidance (WordPress/gutenberg#81245) - ESLint: Define dependency import rules (WordPress/gutenberg#81246) - Flaky tests: Report as a PR comment only, stop creating issues (WordPress/gutenberg#81218) - Dashboard Widgets: remove the Hello Dolly download action (WordPress/gutenberg#81272) - Block Directory: Make downloadable block item labels translatable. (WordPress/gutenberg#81237) - Icons: move the inline image icon into the library (WordPress/gutenberg#81271) - Update phpcs, wpcs dependencies (WordPress/gutenberg#81279) - fix: add optional chaining for empty reusable block (WordPress/gutenberg#81165) (WordPress/gutenberg#81177) - DataViews: Inline the kebabCase utility from components (WordPress/gutenberg#81284) - Navigation: Complete the DocBlocks for the responsive container and overlay style helpers (WordPress/gutenberg#80622) - Style states: fix state deselection when selecting the already selected block (WordPress/gutenberg#81277) - Fix missing return value in force_filtered_html_on_import footnotes filter (WordPress/gutenberg#81293) - Packages: Recover July 29 npm release metadata (WordPress/gutenberg#81303) - Global styles: render element styles set only inside a breakpoint (WordPress/gutenberg#81265) - Style states: Fix phantom pseudo element style output (WordPress/gutenberg#81291) - Docs: remove breakpoint-only element style example from global styles guide (WordPress/gutenberg#81308) - Render viewport state element styles in the editor (WordPress/gutenberg#81307) - theme.json schema: responsive states belong to blocks (WordPress/gutenberg#81253) - theme.json schema: allow responsive states on block style variations (WordPress/gutenberg#81309) - Block Inspector: Disable the 'Edit original' button when the entity ID is missing (WordPress/gutenberg#81288) - Site Editor: Decode HTML entities in Identity fields (WordPress/gutenberg#81269) - Document editEntityRecord's options.isCached param (WordPress/gutenberg#81318) - Theme: Colocate plugin tests with implementations (WordPress/gutenberg#81247) - Block Editor: Bail out of hasSelectedInnerBlock when there is no clientId (WordPress/gutenberg#81315) - ESLint: Replace strict config with bulk suppressions (WordPress/gutenberg#81248) - Block Library: Document security patch releases (WordPress/gutenberg#81295) - ESLint: Remove legacy import suppressions (WordPress/gutenberg#81338) - Components: Migrate Spinner styles from Emotion to SCSS module (WordPress/gutenberg#80511) - DataViews: Use the public `@wordpress/ui` Badge instead of the private one (WordPress/gutenberg#81236) - Pert Tests: Avoid inflating interaction metrics with startTracing (WordPress/gutenberg#81264) - Block Editor: Simplify InspectorControlsFill rendering logic (WordPress/gutenberg#81286) - Keycodes: Make `withIgnoreIMEEvents` a public API (WordPress/gutenberg#81343) - Docs: Fix broken links to the removed JavaScript build setup guide. (WordPress/gutenberg#81232) - Markdownlint: disable the MD033 (no-inline-html) rule project-wide (WordPress/gutenberg#81213) - Docs: Fix typo in block file structure guide (WordPress/gutenberg#81348) - Playlist: Normalize Waveform Player configuration handling (WordPress/gutenberg#81342) - Site editor: fix unreadable sidebar hover color (WordPress/gutenberg#81317) - Global Styles: Migrate font size presets to the shared preset layer (WordPress/gutenberg#79811) - Block Editor: Convert useBlockVisibility hook to TypeScript (WordPress/gutenberg#80390) - Scope breakpoint media queries to screen so printing does not look like a resize (WordPress/gutenberg#81367) - New `kebab-case` package: extract utility and migrate private API calls (WordPress/gutenberg#81294) - Remove content types experiment (WordPress/gutenberg#81340) - Editor: Keep the canvas height stable while resizing the canvas (WordPress/gutenberg#81163) - Dashboard Widgets: add icon and relevance to the widget action envelope (WordPress/gutenberg#81275) - Playlist: Improve audio conversion and track selection (WordPress/gutenberg#80926) - Try: Set post navigation link icon to next. (WordPress/gutenberg#81384) - UI: Derive Base UI direction from WordPress i18n (WordPress/gutenberg#80399) - DataViews: Fix `array` field type validation for empty values (WordPress/gutenberg#81378) - Bump github/codeql-action/upload-sarif (WordPress/gutenberg#81287) - Bump actions/stale from 10.4.0 to 11.0.0 in /.github/workflows (WordPress/gutenberg#81219) - Monitor all setup-related composite Actions. (WordPress/gutenberg#81192) - IconButton: Improve keyboard shortcut accessibility (WordPress/gutenberg#80402) - Interface: Stop the secondary sidebar animating into place on page load (WordPress/gutenberg#81362) - Fix: flaky list view paste block styles e2e test (WordPress/gutenberg#81229) - Docs: Add error message guidance. (WordPress/gutenberg#81143) - wp-build: Render the no-JS fallback in the generated page templates (WordPress/gutenberg#81365) - Changed Build Process Link and remove unused tags (WordPress/gutenberg#81360) - Scripts: Prevent a UTF-8 BOM in the middle of extracted CSS (WordPress/gutenberg#81383) - Global Styles: Migrate shadows presets to use the preset management layer. (WordPress/gutenberg#79812) - Global Styles: report border, shadow, outline, filter and dimension changes (WordPress/gutenberg#81407) - Dashboard Widgets: split action icons into wire and resolved forms (WordPress/gutenberg#81381) - Block Editor: Fix Escape from the block toolbar and stop redundant last focus dispatches (WordPress/gutenberg#81319) - Block Mover: Add the keyboard shortcut to the buttons' spoken description (WordPress/gutenberg#81380) - Format Library: Remove unused CSS rule (WordPress/gutenberg#77831) - Core Data: Fix post staying dirty after saving edited post meta with RTC enabled (WordPress/gutenberg#81392) - Widget Dashboard: host-tunable tile spacing via public custom properties (WordPress/gutenberg#81352) - DataForm: Fix hidden fields validation (WordPress/gutenberg#81377) - Tools: Make agent setup a workspace (WordPress/gutenberg#81418) - Test: Add private Vitest config and migrate a pilot test (WordPress/gutenberg#81037) - Interface: Let CSS own the ComplementaryArea width and use AnimatePresence custom for exit (WordPress/gutenberg#81363) - Notes: Fix text wrapping for long usernames in collaboration sidebar (WordPress/gutenberg#81406) - DataViews: vendor `ValidatedSelectControl` (WordPress/gutenberg#81391) - UI: Add `Calendar` and `RangeCalendar`, moved from `components` private APIs (WordPress/gutenberg#81337) - Feature: Tabs block: consider using the tab title in the Document Overview instead of a generic "Tab" label (WordPress/gutenberg#81427) - fix: order site identity changes predictably (WordPress/gutenberg#81283) - Docs: Fix broken link to the Node.js debugging guide. (WordPress/gutenberg#81398) - Navigation Overlay Close: Inherit typography and color from the overlay (WordPress/gutenberg#80751) - Fix: Regression: Tabs block: Start with empty tab labels with placeholders (WordPress/gutenberg#81429) - components/Menu: Restore Modal focus return when menu items close (WordPress/gutenberg#81164) - DataViews: Move the rich text control into the editor package (WordPress/gutenberg#81430) - Components: Remove ValidatedTextControl private API (WordPress/gutenberg#80680) - Cover: Avoid passing null as the featured image size (WordPress/gutenberg#81444) - DataViews: vendor `ValidatedNumberControl` (WordPress/gutenberg#81433) - DataViews: vendor ValidatedCheckboxControl (WordPress/gutenberg#81435) - DataViews: vendor ValidatedRadioControl (WordPress/gutenberg#81434) - UI: Upgrade React DayPicker to version 10 (WordPress/gutenberg#81439) - Block editor: render a real default block in place of the default appender (WordPress/gutenberg#81231) - Spacing Sizes Control: Make the control label translatable independently of the input aria label. (WordPress/gutenberg#81240) - Writing flow: stop the caret on containers that do not merge with the text flow (WordPress/gutenberg#81456) - Remove an unmodified wrapper when all its inner blocks are removed (WordPress/gutenberg#42503) - Normalize block gap values in layout (WordPress/gutenberg#81460) - Docs: Add Block Actions Readme (WordPress/gutenberg#69408) - Block editor: disclose the nested block count of a multi selection (WordPress/gutenberg#80745) - Fix: flaky autosave shareable URL revisions e2e test. (WordPress/gutenberg#81455) - Fix empty list block with anchor persisting after backspace deletion (WordPress/gutenberg#77000) - Docs: Add Block List Readme (WordPress/gutenberg#69432) - Docs: Add Block Lock Readme (WordPress/gutenberg#69434) - Backport core fixes for finalize route (WordPress/gutenberg#81465) - ESLint: Rename root eslint.config.cjs to eslint.config.mjs (WordPress/gutenberg#81468) - Update 23.8 release branch (WordPress/gutenberg#81486) - RTC: Couple RTC and polling provider as an opt-in experiment (WordPress/gutenberg#80658) - Align collaboration migration version markers with the 23.8.0 release (WordPress/gutenberg#81789) Fixes #66066. git-svn-id: https://develop.svn.wordpress.org/trunk@63534 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned commit hash of the Gutenberg repository from `5a0417990a9404cc2562cdd35e3054cb0d3e546e` (version `23.7.0`) to `ae8b34d78e1abc6d1c866fdc00080a1452de82ad` (version `23.8.0`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v23.7.0..v23.8.0. - Fix: New route-based admin pages are empty when no JS (WordPress/gutenberg#80628) - Report flaky tests: declare @types/node (WordPress/gutenberg#80838) - Storybook e2e: add small, compact and icon examples to button matrix (WordPress/gutenberg#80793) - ESLint: Drop @eslint/compat fixup for jest-dom and testing-library (WordPress/gutenberg#80842) - Storybook: Use SelectControl in Motion tokens story (WordPress/gutenberg#80790) - Writing flow: forward delete an empty paragraph without breaking apart the next block (WordPress/gutenberg#80813) - ToggleControl: Add "With Visual" Storybook story (WordPress/gutenberg#80803) - Bump the github-actions group across 1 directory with 5 updates (WordPress/gutenberg#80684) - Update Ariakit packages (WordPress/gutenberg#80765) - Components: Update Floating UI to 2.1.9 (WordPress/gutenberg#80761) - Improve pre-flight npm access checks (WordPress/gutenberg#80334) - Ensure static checks can run for private mirrors (WordPress/gutenberg#80817) - Components: Update react-day-picker to 9.14.0 (WordPress/gutenberg#80792) - Testing: Remove the jest-puppeteer-axe package (WordPress/gutenberg#80775) - Tools: Use native agent skill discovery (WordPress/gutenberg#80811) - Table of Contents: Replace "Convert to static list" with confirmed "Detach" action (WordPress/gutenberg#80844) - Page List: Rename the Edit action to Detach and confirm it in a dialog (WordPress/gutenberg#80847) - URLInput: Simplify keyboard handling and fix arrow keys with a text selection (WordPress/gutenberg#80780) - Upload Media: Fail the item when the /finalize request fails (WordPress/gutenberg#80725) - Jest preset: support self-referencing via exports (WordPress/gutenberg#80837) - Fix template `modified` and `date` return value for file templates (WordPress/gutenberg#80733) - Element: Make the package importable in React 19 (WordPress/gutenberg#80053) - Add CheckboxControl with-visual Storybook story. (WordPress/gutenberg#80849) - UI: Add Combobox.InputGroup primitive (WordPress/gutenberg#80869) - Block Editor: Clear the moving animation's z-index when it finishes (WordPress/gutenberg#80824) - SearchableChipSelect: Add form primitive to @wordpress/ui (WordPress/gutenberg#80779) - Playlist: Add track icon (WordPress/gutenberg#80959) - Flaky tests: fix router navigate latest HTML (WordPress/gutenberg#80178) - Components: Update polymorphism types to allow all attributes when specifying `as` (WordPress/gutenberg#80705) - Block JSON schema & PHP-only blocks: Add `autoRegister` support (WordPress/gutenberg#80173) - Boot: Adjust specificity of the image reset styles so components can size their own images (WordPress/gutenberg#80845) - Components: Opt-in ConfirmDialog for auto-documentation (WordPress/gutenberg#80866) - RichText: don't apply input transform when there's no onReplace (WordPress/gutenberg#80978) - Quote: Ensure paragraph placeholder appears after deleting nested blocks (WordPress/gutenberg#77151) - Block editor: make the Group action wrap blocks with a group transform (WordPress/gutenberg#80891) - Copy: preserve the block when its entire text is selected (WordPress/gutenberg#80994) - Add opt-out for block style state controls (WordPress/gutenberg#80956) - Upgrade Playwright to v1.62 (WordPress/gutenberg#81001) - List View: Speed up opening by removing a forced style recalculation (WordPress/gutenberg#80929) - Widget Dashboard: preserve widget chrome flex layout (WordPress/gutenberg#80570) - Widget Primitives: document actions as verbs, not links (WordPress/gutenberg#80974) - Core Data: add missing @wordpress/base-styles dependency (WordPress/gutenberg#81012) - Ignore node_modules in schema integration test globs (WordPress/gutenberg#81013) - RichText: fix paste handler crash when pasting files (WordPress/gutenberg#81010) - Docs: Add VS Code setup guidance (WordPress/gutenberg#77913) - Perf Tests: Merge selection event windows instead of summing durations (WordPress/gutenberg#81002) - Storybook: move smoke-test deps into the storybook workspace (WordPress/gutenberg#81017) - Unit Tests: Reorganise the jest config file. (WordPress/gutenberg#80940) - Performance Tests: Ignore the locally generated artifacts directory (WordPress/gutenberg#81024) - Editor: Remove sidebar tabs focus sync effect (WordPress/gutenberg#81020) - Widgets: carry a declarative `icon` through the widget pipeline (WordPress/gutenberg#80969) - RTC: Remove excess autosave notices (when not useful) (WordPress/gutenberg#80539) - UI: Use focus styles from base-styles (WordPress/gutenberg#80635) - Automated Testing: Add Storybook component documentation regression testing (WordPress/gutenberg#80655) - Pass Playlist controls to track blocks (WordPress/gutenberg#80368) - Components: Deprecate Surface (WordPress/gutenberg#80943) - Tabs: Support Home and End keys for keyboard navigation (WordPress/gutenberg#80912) - Fix typos in code `comments` and `JSDoc` (WordPress/gutenberg#81045) - Interface: Remove incorrect aria-expanded from pin-to-toolbar button (WordPress/gutenberg#79874) - List View: Speed up opening by removing a second render pass (WordPress/gutenberg#80935) - Docs: Use `gutenberg` instead of `Gutenberg` in package name (WordPress/gutenberg#81051) - Fix ESLint warnings for 'navigateRegionsProps' spread (WordPress/gutenberg#81052) - Tests: Replace page-level selectors with locators in e2e specs (WordPress/gutenberg#81053) - RTC: Disable custom autosave controller when RTC is disabled (WordPress/gutenberg#80769) - Background: Fix the legacy gradient UI where a gradient cannot be selected (WordPress/gutenberg#81056) - Rename blockStatesEnabled setting to blockStatesEditingEnabled (WordPress/gutenberg#81058) - Background: Fix the legacy gradient UI where a gradient cannot be selected - Add missing change log (WordPress/gutenberg#81060) - Declare missing prettier and stylelint workspace dependencies (WordPress/gutenberg#81065) - Notes: Display shortcut for form action buttons (WordPress/gutenberg#81064) - View config: lowercase dynamic filter names (WordPress/gutenberg#81068) - CI: cache the system packages Playwright dowloads for WebKit (WordPress/gutenberg#80846) - List View: Collapse off-window placeholder rows into a single spacer row (WordPress/gutenberg#80953) - devops: balance Playwright shards by duration (WordPress/gutenberg#79479) - Views: honor developer-defined view config overrides (WordPress/gutenberg#80832) - Components: Migrate ItemGroup to SCSS module (WordPress/gutenberg#80797) - Test: Add Vitest migration routing guardrails (WordPress/gutenberg#81036) - Visual revisions: Add a code diff view inside the editor (WordPress/gutenberg#80314) - Bump actions/labeler from 6.1.0 to 7.0.0 in /.github/workflows (WordPress/gutenberg#80966) - Visual revisions: add shareable urls (WordPress/gutenberg#79934) - Fix e2e tests that break when shard rebalancing changes their neighbors (WordPress/gutenberg#81117) - Query: guard non-scalar queryId to avoid fatal in enhanced pagination (WordPress/gutenberg#80724) - Replace deprecated useResizeObserver for useScaleCanvas (WordPress/gutenberg#67508) - CI: Add job timeouts to E2E, static checks, bundle size, and create block (WordPress/gutenberg#80801) - Allow organization or repository variable to dictate the Actions runner (WordPress/gutenberg#81087) - List View: Only subscribe to the block subtree for rows that can show images (WordPress/gutenberg#81076) - Editor: Migrate settings sidebar to Tabs from @wordpress/ui (WordPress/gutenberg#81054) - Notes: Email users mentioned in a note (WordPress/gutenberg#79606) - List View: Narrow the dependants of the memoized List View tree (WordPress/gutenberg#81129) - List View: Pass only minimal required data to sub-tree branches (WordPress/gutenberg#81111) - DataViews: Add `time` field type and control (WordPress/gutenberg#80830) - Post Author Biography: Fix horizontal overflow with long unbroken text (WordPress/gutenberg#81018) - Link Control: Restore the preview title underline (WordPress/gutenberg#81083) - Views: Add React to the package's dev dependencies (WordPress/gutenberg#81139) - feat: Add target param in proxy (WordPress/gutenberg#81141) - Fix: flaky revisions pagination e2e cross-page diff assertion (WordPress/gutenberg#81119) - Button: Suppress UA focus ring when focused and pressed (WordPress/gutenberg#81113) - View config: add reference docs (WordPress/gutenberg#81149) - Editor: Fix document tools button focus ring (WordPress/gutenberg#81115) - List View: Replace expand/collapse callbacks with reducer dispatch (WordPress/gutenberg#81138) - CI: resolve Playwright through the workspace that declares it (WordPress/gutenberg#81137) - CI: build once and reuse the build across e2e tests shards (WordPress/gutenberg#81031) - Fix: Tabs block: Start with empty tab labels with placeholders (WordPress/gutenberg#81009) - Interface: Increase footer breadcrumb height to prevent focus ring clipping (WordPress/gutenberg#81145) - Editor: clarify autosave failure notice (WordPress/gutenberg#76470) - Theme: Omit color properties when neither provided nor inherited (WordPress/gutenberg#80600) - Post editor: Add ThemeProvider for admin color schemes (WordPress/gutenberg#81112) - Core Data: saveDirtyEntities: improve messaging of server errors (WordPress/gutenberg#81151) - Global Styles: kebab-case preset slugs when converting references to custom properties (WordPress/gutenberg#80583) - Revise CODEOWNERS for package ownership (removing nerrad) (WordPress/gutenberg#81175) - Build: Wrap script bundles in an IIFE to contain 'use strict' (WordPress/gutenberg#79792) - Media: Improve the HEIC upload error and keep any upload errors up until dismissed (WordPress/gutenberg#81130) - Block Supports: Guard against non-string attribute values to avoid fatal errors (WordPress/gutenberg#80501) - Video: Hide settings for the GIF variation (WordPress/gutenberg#81142) - Video: clarify the Video variation description (WordPress/gutenberg#81181) - Media Editor: Render sidebar tabs via ComplementaryArea's render prop (WordPress/gutenberg#81133) - Bump docker/login-action (WordPress/gutenberg#80962) - Bump actions/setup-node from 6.4.0 to 7.0.0 in /.github/setup-node (WordPress/gutenberg#80963) - fix(admin-ui): reset the wp-admin li margin that misaligns Breadcrumbs (WordPress/gutenberg#81134) - Bump astral-sh/setup-uv from 8.3.2 to 9.0.0 in /.github/workflows (WordPress/gutenberg#80964) - Fix/79643 rtc awareness mixed block selection (WordPress/gutenberg#79836) - Agents: Add a defensive data design skill and route to the copy guide (WordPress/gutenberg#81131) - ESLint: Ban `@ts-ignore` in favour of `@ts-expect-error` (WordPress/gutenberg#81148) - Types: Replace remaining `@ts-expect-error` suppressions with proper typing (WordPress/gutenberg#81200) - Button: turn on the width setting by default in theme.json (WordPress/gutenberg#81196) - Notes: fix the mention notification email composition (WordPress/gutenberg#81187) - Edit Widgets: Fix header toolbar button focus ring (WordPress/gutenberg#81176) - List View: Reduce per-row store subscriptions (WordPress/gutenberg#81136) - Customizer widgets: Add ThemeProvider for admin color schemes (WordPress/gutenberg#81174) - Blocks: Declare the `@types/react-is` devDependency (WordPress/gutenberg#81203) - Widgets editor: Add ThemeProvider for admin color schemes (WordPress/gutenberg#81173) - PanelColorSettings: Restore the missing space below the panel header (WordPress/gutenberg#81155) - Remove the editableRoot opt-in from the paragraph block (WordPress/gutenberg#81184) - Media Attached to: Fix issue with the popover unexpectedly flipping, tweak wording (WordPress/gutenberg#81206) - Components: Add allowForms prop to SandBox component (WordPress/gutenberg#76471) - Ensure device preview is always accurate when window is zoomed in (WordPress/gutenberg#81193) - DataViews: Pass only eligible items to a bulk action callback (WordPress/gutenberg#81198) - DataViews: Make grid and table item preview aspect ratio configurable (WordPress/gutenberg#79329) - Block Editor: Return false from isBlockSelected when there is no client ID (WordPress/gutenberg#81212) - Blocks: Update hpq to 1.4.0 and drop the ts-expect-error suppressions (WordPress/gutenberg#81199) - DataViews: Fix the between `date` filter losing a manually typed date on blur (WordPress/gutenberg#81150) - Block Editor: Fix Select all freezing on large posts (WordPress/gutenberg#81210) - List View: Split the context and drop dead props to cut re-renders on expand and collapse (WordPress/gutenberg#81159) - Docs: Fix broken Figma links on the design resources page. (WordPress/gutenberg#81166) - Blocks: Support static block templates in block type settings (WordPress/gutenberg#80027) - AGENTS: Update development tips section (WordPress/gutenberg#81224) - URLInput: Skip search requests while an IME composition is in progress (WordPress/gutenberg#80602) - Components: Deprecate Animate (WordPress/gutenberg#80931) - Fix: Trunk e2e failures caused by the navigation spec leaving plain permalinks (WordPress/gutenberg#81238) - Use p elements for callout alerts in components docs (WordPress/gutenberg#81234) - Storybook: Enable design system theme tool globally (WordPress/gutenberg#81116) - Media: Cover client-side big image scaling and orphaned files (WordPress/gutenberg#81061) - Footnotes: guard against invalid post meta values (WordPress/gutenberg#81201) - Block editor: unify what a new sibling block inherits (WordPress/gutenberg#81250) - Global Styles: Remove unused duplicate font family preview utilities (WordPress/gutenberg#81194) - Docs: explain how the theme.json schema fixtures work (WordPress/gutenberg#81263) - theme.json schema: fix block pseudo-classes and custom states (WordPress/gutenberg#81209) - List View: Migrate label wrapper to UI Stack and drop Badge from the anchor (WordPress/gutenberg#81266) - Docs: Remove dependency group import guidance (WordPress/gutenberg#81245) - ESLint: Define dependency import rules (WordPress/gutenberg#81246) - Flaky tests: Report as a PR comment only, stop creating issues (WordPress/gutenberg#81218) - Dashboard Widgets: remove the Hello Dolly download action (WordPress/gutenberg#81272) - Block Directory: Make downloadable block item labels translatable. (WordPress/gutenberg#81237) - Icons: move the inline image icon into the library (WordPress/gutenberg#81271) - Update phpcs, wpcs dependencies (WordPress/gutenberg#81279) - fix: add optional chaining for empty reusable block (WordPress/gutenberg#81165) (WordPress/gutenberg#81177) - DataViews: Inline the kebabCase utility from components (WordPress/gutenberg#81284) - Navigation: Complete the DocBlocks for the responsive container and overlay style helpers (WordPress/gutenberg#80622) - Style states: fix state deselection when selecting the already selected block (WordPress/gutenberg#81277) - Fix missing return value in force_filtered_html_on_import footnotes filter (WordPress/gutenberg#81293) - Packages: Recover July 29 npm release metadata (WordPress/gutenberg#81303) - Global styles: render element styles set only inside a breakpoint (WordPress/gutenberg#81265) - Style states: Fix phantom pseudo element style output (WordPress/gutenberg#81291) - Docs: remove breakpoint-only element style example from global styles guide (WordPress/gutenberg#81308) - Render viewport state element styles in the editor (WordPress/gutenberg#81307) - theme.json schema: responsive states belong to blocks (WordPress/gutenberg#81253) - theme.json schema: allow responsive states on block style variations (WordPress/gutenberg#81309) - Block Inspector: Disable the 'Edit original' button when the entity ID is missing (WordPress/gutenberg#81288) - Site Editor: Decode HTML entities in Identity fields (WordPress/gutenberg#81269) - Document editEntityRecord's options.isCached param (WordPress/gutenberg#81318) - Theme: Colocate plugin tests with implementations (WordPress/gutenberg#81247) - Block Editor: Bail out of hasSelectedInnerBlock when there is no clientId (WordPress/gutenberg#81315) - ESLint: Replace strict config with bulk suppressions (WordPress/gutenberg#81248) - Block Library: Document security patch releases (WordPress/gutenberg#81295) - ESLint: Remove legacy import suppressions (WordPress/gutenberg#81338) - Components: Migrate Spinner styles from Emotion to SCSS module (WordPress/gutenberg#80511) - DataViews: Use the public `@wordpress/ui` Badge instead of the private one (WordPress/gutenberg#81236) - Pert Tests: Avoid inflating interaction metrics with startTracing (WordPress/gutenberg#81264) - Block Editor: Simplify InspectorControlsFill rendering logic (WordPress/gutenberg#81286) - Keycodes: Make `withIgnoreIMEEvents` a public API (WordPress/gutenberg#81343) - Docs: Fix broken links to the removed JavaScript build setup guide. (WordPress/gutenberg#81232) - Markdownlint: disable the MD033 (no-inline-html) rule project-wide (WordPress/gutenberg#81213) - Docs: Fix typo in block file structure guide (WordPress/gutenberg#81348) - Playlist: Normalize Waveform Player configuration handling (WordPress/gutenberg#81342) - Site editor: fix unreadable sidebar hover color (WordPress/gutenberg#81317) - Global Styles: Migrate font size presets to the shared preset layer (WordPress/gutenberg#79811) - Block Editor: Convert useBlockVisibility hook to TypeScript (WordPress/gutenberg#80390) - Scope breakpoint media queries to screen so printing does not look like a resize (WordPress/gutenberg#81367) - New `kebab-case` package: extract utility and migrate private API calls (WordPress/gutenberg#81294) - Remove content types experiment (WordPress/gutenberg#81340) - Editor: Keep the canvas height stable while resizing the canvas (WordPress/gutenberg#81163) - Dashboard Widgets: add icon and relevance to the widget action envelope (WordPress/gutenberg#81275) - Playlist: Improve audio conversion and track selection (WordPress/gutenberg#80926) - Try: Set post navigation link icon to next. (WordPress/gutenberg#81384) - UI: Derive Base UI direction from WordPress i18n (WordPress/gutenberg#80399) - DataViews: Fix `array` field type validation for empty values (WordPress/gutenberg#81378) - Bump github/codeql-action/upload-sarif (WordPress/gutenberg#81287) - Bump actions/stale from 10.4.0 to 11.0.0 in /.github/workflows (WordPress/gutenberg#81219) - Monitor all setup-related composite Actions. (WordPress/gutenberg#81192) - IconButton: Improve keyboard shortcut accessibility (WordPress/gutenberg#80402) - Interface: Stop the secondary sidebar animating into place on page load (WordPress/gutenberg#81362) - Fix: flaky list view paste block styles e2e test (WordPress/gutenberg#81229) - Docs: Add error message guidance. (WordPress/gutenberg#81143) - wp-build: Render the no-JS fallback in the generated page templates (WordPress/gutenberg#81365) - Changed Build Process Link and remove unused tags (WordPress/gutenberg#81360) - Scripts: Prevent a UTF-8 BOM in the middle of extracted CSS (WordPress/gutenberg#81383) - Global Styles: Migrate shadows presets to use the preset management layer. (WordPress/gutenberg#79812) - Global Styles: report border, shadow, outline, filter and dimension changes (WordPress/gutenberg#81407) - Dashboard Widgets: split action icons into wire and resolved forms (WordPress/gutenberg#81381) - Block Editor: Fix Escape from the block toolbar and stop redundant last focus dispatches (WordPress/gutenberg#81319) - Block Mover: Add the keyboard shortcut to the buttons' spoken description (WordPress/gutenberg#81380) - Format Library: Remove unused CSS rule (WordPress/gutenberg#77831) - Core Data: Fix post staying dirty after saving edited post meta with RTC enabled (WordPress/gutenberg#81392) - Widget Dashboard: host-tunable tile spacing via public custom properties (WordPress/gutenberg#81352) - DataForm: Fix hidden fields validation (WordPress/gutenberg#81377) - Tools: Make agent setup a workspace (WordPress/gutenberg#81418) - Test: Add private Vitest config and migrate a pilot test (WordPress/gutenberg#81037) - Interface: Let CSS own the ComplementaryArea width and use AnimatePresence custom for exit (WordPress/gutenberg#81363) - Notes: Fix text wrapping for long usernames in collaboration sidebar (WordPress/gutenberg#81406) - DataViews: vendor `ValidatedSelectControl` (WordPress/gutenberg#81391) - UI: Add `Calendar` and `RangeCalendar`, moved from `components` private APIs (WordPress/gutenberg#81337) - Feature: Tabs block: consider using the tab title in the Document Overview instead of a generic "Tab" label (WordPress/gutenberg#81427) - fix: order site identity changes predictably (WordPress/gutenberg#81283) - Docs: Fix broken link to the Node.js debugging guide. (WordPress/gutenberg#81398) - Navigation Overlay Close: Inherit typography and color from the overlay (WordPress/gutenberg#80751) - Fix: Regression: Tabs block: Start with empty tab labels with placeholders (WordPress/gutenberg#81429) - components/Menu: Restore Modal focus return when menu items close (WordPress/gutenberg#81164) - DataViews: Move the rich text control into the editor package (WordPress/gutenberg#81430) - Components: Remove ValidatedTextControl private API (WordPress/gutenberg#80680) - Cover: Avoid passing null as the featured image size (WordPress/gutenberg#81444) - DataViews: vendor `ValidatedNumberControl` (WordPress/gutenberg#81433) - DataViews: vendor ValidatedCheckboxControl (WordPress/gutenberg#81435) - DataViews: vendor ValidatedRadioControl (WordPress/gutenberg#81434) - UI: Upgrade React DayPicker to version 10 (WordPress/gutenberg#81439) - Block editor: render a real default block in place of the default appender (WordPress/gutenberg#81231) - Spacing Sizes Control: Make the control label translatable independently of the input aria label. (WordPress/gutenberg#81240) - Writing flow: stop the caret on containers that do not merge with the text flow (WordPress/gutenberg#81456) - Remove an unmodified wrapper when all its inner blocks are removed (WordPress/gutenberg#42503) - Normalize block gap values in layout (WordPress/gutenberg#81460) - Docs: Add Block Actions Readme (WordPress/gutenberg#69408) - Block editor: disclose the nested block count of a multi selection (WordPress/gutenberg#80745) - Fix: flaky autosave shareable URL revisions e2e test. (WordPress/gutenberg#81455) - Fix empty list block with anchor persisting after backspace deletion (WordPress/gutenberg#77000) - Docs: Add Block List Readme (WordPress/gutenberg#69432) - Docs: Add Block Lock Readme (WordPress/gutenberg#69434) - Backport core fixes for finalize route (WordPress/gutenberg#81465) - ESLint: Rename root eslint.config.cjs to eslint.config.mjs (WordPress/gutenberg#81468) - Update 23.8 release branch (WordPress/gutenberg#81486) - RTC: Couple RTC and polling provider as an opt-in experiment (WordPress/gutenberg#80658) - Align collaboration migration version markers with the 23.8.0 release (WordPress/gutenberg#81789) Fixes #66066. Built from https://develop.svn.wordpress.org/trunk@63534 git-svn-id: http://core.svn.wordpress.org/trunk@62710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
What?
See #60891
The DataViews
gridlayout renders item previews (the media field) at a hard-coded1/1(square) aspect ratio, and thetablelayout does the same for the primary column's media preview. This adds anaspectRatiooption to thegridandtablelayoutconfigs so consumers can choose the shape, defaulting to1/1so nothing changes for existing consumers.Why?
#60891 asks for the grid preview aspect ratio to be consumer configurable — a square crop isn't ideal for every dataset (tall templates, wide media, video thumbnails, etc.). For example, a video library wants
16/9previews so the thumbnail matches how the video actually appears.A previous attempt (#63487) stalled on the UX of a user-facing toggle between
1/1andauto(variable per-item ratios), which raised "visual rivers" / masonry concerns. This PR deliberately sidesteps that debate: it exposes a single consumer-set, uniform aspect ratio, applied identically to every item — the form even the prior reviewers were comfortable with ("it should change the aspect ratio of all previews"). The user-facing toggle andauto/variable per-item ratios are intentionally left as a follow-up.Scope is limited to the
gridandtablelayouts;pickerGrid/pickerTableparity is a straightforward follow-up.How?
aspectRatio?: MediaAspectRatiotoViewGrid['layout']andViewTable['layout'], whereMediaAspectRatiois a union of preset ratios ('1/1' | '4/3' | '3/4' | '3/2' | '2/3' | '16/9' | '9/16', mirroring Core's default aspect-ratio presets) — the same constrained-union pattern asdensity. Starting with presets keeps the API easy to widen later without a breaking change, and avoids consumers setting degenerate ratios.--wp-dataviews-media-aspect-ratioCSS custom property (matching the existing--wp-dataviews-color-backgroundnaming) on the layout root (the grid container — both the standard and infinite-scroll roots — and thetableelement). The property is always set, defaulting to1/1, so a same-named variable set by a consumer on an ancestor can't leak into the previews..dataviews-view-grid__mediarule reads it with a1/1fallback:aspect-ratio: var(--wp-dataviews-media-aspect-ratio, 1/1).has-media-aspect-ratiomodifier (same pattern ashas-*-density) that the table only carries when the view setslayout.aspectRatio. Under the modifier, the.dataviews-column-primary__mediawrapper takesheight+aspect-ratio, with theimgfilling it — sizing the wrapper rather than theimgkeeps custom media field renders (nested elements instead of a bareimg) covered too. Row heights are unchanged; the preview widens instead, and a16/9preview at the default height still fits the wrapper's existingmax-width. WithoutaspectRatio, the base rules are exactly what trunk ships today.1/1default and the table keeps its current sizing until a view opts in.Testing Instructions
gridDataView, set the layout'saspectRatio, e.g.view = { type: 'grid', layout: { aspectRatio: '16/9' }, … }.'4/3','1/1') and confirm they apply uniformly to every item.tableDataView with a media field, setlayout.aspectRatio: '16/9'and confirm the primary column's thumbnail renders 16:9 at the same height — row heights don't change.aspectRatio(or use an existing grid/table consumer such as the Pages/Templates views) and confirm previews stay square (1/1) — no regression.previewSizeanddensitystill work alongside it.Testing Instructions for Keyboard
No interaction changes — the option only affects preview dimensions, so existing keyboard navigation of the grid and table is unaffected.
Screenshots or screencast
1/1)aspectRatio: '16/9')Use of AI Tools
This PR was authored with the assistance of AI tooling (Claude Code). The implementation, scope decisions, and this description were AI-assisted and reviewed by me before submission; I take responsibility for the contents.