Repository navigation
Add .vscode/settings.json to .gitignore - #79106
manzoorwanijk wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Flaky tests detected in f17eef7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/27331990972
|
|
I found some prior discussion about |
Yes, I usually have |
|
I think that I am personally a -1 at the moment for this, mainly for the reasons already stated (historical precedence, and the can of worms that is deciding which editors to add to
As a counter argument, I think that we should consider moving this launch example to the developer documentation instead of remaining in source code. Though, I don't feel strongly, I think we end up with the same situation as the |
|
Closing in favor of #77913 |
What?
See #77913
Adds
/.vscode/settings.jsonto.gitignore.Why?
#77913 proposes a managed VS Code workspace config, but it still needs consensus before it can move forward. In the meantime, contributors who keep personal settings in
.vscode/settings.jsonrisk accidentally committing them, since the file is currently untracked but not ignored. Ignoring it keeps personal editor settings out of accidental commits without taking a position on the managed-config proposal.How?
Adds a
/.vscode/settings.jsonentry to the "Local overrides" section of.gitignore. The leading slash scopes the rule to the repository root, and onlysettings.jsonis ignored so that tracked files like.vscode/launch-example.jsonremain unaffected.Testing Instructions
.vscode/settings.jsonfile at the repository root with any content.git statusand confirm the file does not show up as untracked.git status --ignored -- .vscodeand confirm.vscode/settings.jsonis listed as ignored..vscode/launch-example.jsonis still tracked:git ls-files .vscode/.Use of AI Tools
This PR was created with the assistance of Claude Code; the change and description were reviewed by the author.