Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
close in favor of #77972 |
|
Size Change: 0 B Total Size: 7.94 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes the flaky
Menu › pointer and keyboard interactions › should open and focus the first item when pressing the space key on the triggertest inpackages/components/src/menu/test/index.tsx.The first
Menu.Itemin the test fixture was markeddisabled, and the assertion expected focus to land on it after pressing Space. This passes intermittently depending on Ariakit's internal focus timing for disabled items.Why?
The test has been failing on
trunk(jobJavaScript (Node.js 22) 2/4of the Unit Tests workflow) across multiple recent runs, blocking the green status of every subsequent merge.How?
Removes
disabledfrom the firstMenu.Itemin the fixture for that single test, so the assertion targets a normally-focusable item. Removes the now-stale comment describing the disabled-item rationale.The companion test above (lines 130-157), which exercises
ArrowDownwith the same fixture, is intentionally left untouched because it is not flaky in CI. Coverage of the disabled-item-receives-focus behavior is still provided by that sibling test.Testing
npm run test:unit -- packages/components/src/menu/test/index.tsx— 23/23 pass.npm run test:unit -- packages/components/src/menu/test/index.tsx --testNamePattern="should open and focus the first item when pressing the space key"— passes.Notes
PR #77972 by @0mirka00 is a draft proposing the same fix. Happy to close this one in favor of that, or have it close as duplicate once merged — whichever unblocks
trunkfaster.