Skip to content

EditSite: Use --wpds-cursor-control design token for interactive controls - #77362

Closed
R1shabh-Gupta wants to merge 2 commits into
WordPress:trunkfrom
R1shabh-Gupta:add/edit-site-cursor-control-token
Closed

R1shabh-Gupta wants to merge 2 commits into
WordPress:trunkfrom
R1shabh-Gupta:add/edit-site-cursor-control-token

Conversation

@R1shabh-Gupta

Copy link
Copy Markdown
Contributor

What?

Part of #76221

Replaces a hardcoded cursor: pointer declaration in @wordpress/edit-site with cursor: var(--wpds-cursor-control).

Why?

  • Update instances of cursor: pointer to use the design token for better maintenance.

How?

  • Removed cursor: pointer and used cursor: var(--wpds-cursor-control).

Note: While working on the PR, I noticed that .edit-site-post-list__featured-image-button does not appear to be used anywhere in the codebase and seems to be unused CSS. I still applied the token replacement.

Testing Instructions

Since .edit-site-post-list__featured-image-button appears to be unused in the codebase, there is no frontend element to visually verify.

Use of AI Tools

Use Claude Code to review code and create pull request description.

@github-actions github-actions Bot added the [Package] Edit Site /packages/edit-site label Apr 15, 2026
@R1shabh-Gupta
R1shabh-Gupta marked this pull request as ready for review April 15, 2026 07:07
@github-actions

github-actions Bot commented Apr 15, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: R1shabh-Gupta <rishabhwp@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mirka
mirka self-requested a review April 15, 2026 13:25
@mirka mirka added the [Type] Enhancement A suggestion for improvement. label Apr 15, 2026
@mirka

mirka commented Apr 15, 2026

Copy link
Copy Markdown
Member

I noticed that .edit-site-post-list__featured-image-button does not appear to be used anywhere in the codebase and seems to be unused CSS. I still applied the token replacement.

It would probably be better to clean this up, rather than do a token replacement.

@mirka

mirka commented Apr 15, 2026

Copy link
Copy Markdown
Member

There's still a cursor: pointer in the JS code, but I think we can leave that one for now since it doesn't look very straightforward.

@R1shabh-Gupta

Copy link
Copy Markdown
Contributor Author

I have created a follow-up PR to remove the unused CSS rulesets: #77494. Once the unused CSS rulesets are removed, no token replacement is required for those selectors. Since we are not making any changes to use-site-editor-settings.js (as suggested), I think we can close this PR once the cleanup PR is merged.

cc: @mirka

@mirka

mirka commented Apr 20, 2026

Copy link
Copy Markdown
Member

I think we can close this PR once the cleanup PR is merged

Perfect, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Edit Site /packages/edit-site [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants