Skip to content

Changed createObjectUrl to createBlobURL - #7734

Closed
caxco93 wants to merge 1 commit into
WordPress:masterfrom
caxco93:update/use-createBlobUrl-in-mediaupload-util
Closed

caxco93 wants to merge 1 commit into
WordPress:masterfrom
caxco93:update/use-createBlobUrl-in-mediaupload-util

Conversation

@caxco93

@caxco93 caxco93 commented Jul 5, 2018

Copy link
Copy Markdown
Contributor

Description

Changed createObjectUrl to createBlobURL from the @WordPress package.

How has this been tested?

Included tests and manually

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@caxco93
caxco93 force-pushed the update/use-createBlobUrl-in-mediaupload-util branch from 757b7f9 to b8cf85c Compare July 10, 2018 04:46
@caxco93
caxco93 force-pushed the update/use-createBlobUrl-in-mediaupload-util branch from b8cf85c to b0884f8 Compare July 19, 2018 22:07
@caxco93
caxco93 force-pushed the update/use-createBlobUrl-in-mediaupload-util branch from b0884f8 to 0684542 Compare July 19, 2018 22:42
@gziolo

gziolo commented Jul 20, 2018

Copy link
Copy Markdown
Member

See: #7978, we are moving mediaUpload method and leaving only a copy for deprecated one.
I'm not quite sure what is the best way to proceed :)

@gziolo

gziolo commented Jul 20, 2018

Copy link
Copy Markdown
Member

I think you need to include wp-blob in the list of dependencies for the JS script in PHP file
https://github.com/WordPress/gutenberg/blob/master/lib/client-assets.php#L223
similar to this
https://github.com/WordPress/gutenberg/blob/master/lib/client-assets.php#L300

@aduth

aduth commented Sep 13, 2018

Copy link
Copy Markdown
Member

Is it likely this will be resumed, or can it be closed?

@aduth aduth added [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Package] Blob /packages/blob and removed [Package] Blob /packages/blob labels Sep 13, 2018
@gziolo

gziolo commented Sep 24, 2018

Copy link
Copy Markdown
Member

We no longer have utils folder/module. We should open another PR if it is still the case in editor package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants