Repository navigation
Add emoji reactions to notes ❤️ 🎉 😄 👀 🚀 - #76767
adamsilverstein merged 214 commits into
Conversation
|
Size Change: +2.71 kB (+0.03%) Total Size: 7.92 MB 📦 View Changed
|
|
Flaky tests detected in 4b59106. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/33358611256 As a user I expect my navigation to use the colors I selected for it in
|
|
Regarding unbounded requests & embedding reactions: If embedding all the reactions on a given note is too much, we could think about caching/retrieving only the reaction count (grouped by emoji). This way we can quickly display the different reactions on a note and lazy load the individual reactions (and who gave them) after that. |
|
Two open threads carried over from #75549 worth noting:
All other feedback from #75549 has been addressed — see my comparison for details. |
|
@swissspidy this is what's shipping now - in case you want to double-check it matches what you had in mind:
The unbounded |
|
I'm going to look at leveraging an existing library for the emoji picker itself, something like https://github.com/liveblocks/frimousse that is well maintained, license compatible and designed to be styled/extended. This would provide a much richer experience, and we can still start with the simplified design of a small set of emoji with the full selection "behind" a (+) plus button. |
|
Here is a screencast of the current implementation in action: react.with.emoji.picker.mp4 |
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Match core, which defines get_note_reaction_keys() as a private static method on WP_REST_Comments_Controller. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…om core Co-Authored-By: Claude <noreply@anthropic.com>
|
I think most of the feedback has been addressed. Here's a summary of the commits I pushed:
Here's a summary of the remaining open comments:
Finally, note that these changes haven't been backported to the core PR (#10930) yet. If I have time tomorrow, I plan to backport them to core. I think this is ready for a final round of feedback! |
Mamaduka
left a comment
There was a problem hiding this comment.
Thank you, @t-hamano!
Going to pre-approve this. We often sync changes back from core backport PRs, and I think it's much easier to review PHP code (fewer lines, etc.).
@westonruter, what do you think?
|
Thanks @t-hamano for pushing all the updates here, appreciate the extra effort here to get this over the finish line before Beta 1. 🎉
I will look at this again, but don't think it should be a blocker to merging. The core side will be a little cleaner, but still messy because of the lack of a formal API. |
|
@adamsilverstein, I have just finished syncing the updated PHP code from this PR into the core PR. I believe both PRs are now ready to go. As long as the server-side implementation around comment permissions and security is robust, we should be able to address the client-side logic and UI after Beta 1. |
We can address most paper cuts after in beta cycle; features usually get more testing once they're merged. |
Excellent! I'll give it a review pass. |
|
This tests well for me, since its approved I'm going to go ahead and get it merged so I can commit the core backport PR ahead of beta 1. Thanks everyone for your diligent testing, review and feedback! |
|
Thanks for the work, Adam! |
❤️ 🎉 😄 👀 🚀
Claude reread the current branch and rewrote this description to match it:
Screencast
76767-emoji-reactions-v8.mp4
AI Use
Code and description both came out of a long back and forth with 🤖 Claude Code, with plenty of steering. I will review and test.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DLZNwT2V9zTTQgAD6gF1oe