Repository navigation
Conversation
…ection error modal
…mpatibility. undefined is never invoked.
Member
Author
|
Closing in favour of #76663 |
|
Size Change: +3 B (0%) Total Size: 7.66 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9075cc4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23282054441
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I prepped this PR in case backporting #76554 to
wp/7.0isn't feasible. I guess if folks are using a mix of old packages it's safer to just add the noop value. I don't know 😄Follow up to:
SyncConnectionModal#76554Fixes a TypeScript error in
SyncConnectionErrorModalwhen building onwp/7.0and earlier branches.useCopyToClipboardfrom@wordpress/composeis called with only one argument (the text getter), but onwp/7.0the generated types require bothtextandonSuccess.On trunk, the hook was rewritten in TypeScript (#75723) and
onSuccessis optional, so the single-argument call is valid there.Changes
undefinedas the second argument touseCopyToClipboardto satisfy the type checker on wp/7.0.Testing
npm run buildpasses on wp/7.0