Repository navigation
ToggleGroupControl: Make unselected item color consistent across all variants - #75737
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
|
||
| &:hover { | ||
| color: ${ COLORS.theme.gray[ 900 ] }; | ||
| color: ${ COLORS.theme.foreground }; |
There was a problem hiding this comment.
This is effectively the same color, but the change fixes a deprecation warning.
|
Size Change: +14 B (0%) Total Size: 6.84 MB
ℹ️ View Unchanged
|
commented
Feb 19, 2026
|
Nice, thanks for doing this! At a glance, this looks good, what's the hex code color? I had some problem with my env trying to test this, just want to make sure the gray color is at least the equivalent of gray 600 or around 700, either of those is fine. |
left a comment
There was a problem hiding this comment.
While I still have concerns about differentiation between disabled and unselected, I'd say the changes in this PR are just consistency improvements 👍
Also I noticed a bug. It's subtle, but there's a hover effect on disabled items:
CleanShot.2026-02-20.at.04-39-39.mp4
Probably pre-existing, so your call on whether a fix can be sneaked in here 😄
ToggleGroupControl: tweak deselected item colorToggleGroupControl: Make unselected item color consistent across all variants
b008c15 to
dab82cd
Compare
commented
Feb 20, 2026
Yup, it's
I agree that disabled and unselected items don't look very different, and I also agree that it's something that we should iterate on separately.
👀 🧹 🐛 ❌ I included a fix for that, too. |
commented
Feb 20, 2026
|
Flaky tests detected in 3dccb64. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22214636685
|
commented
Feb 20, 2026
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: 430c8b6 |
What?
Tweak the color of the
ToggleGroupControlitems as per the instructions in #75138 (comment)Why?
Visual polish
How?
Removed dedicated color overrides for icon and deselecteable internal item variants.
These variants now align with the standard, non-icons, non-deselectable version of
ToggleGroupControl.These changes also exposed a little bug about the hover color of disabled items, for which a fix is also included in this PR.
Testing Instructions
Screenshots or screencast