Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +778 B (+0.03%) Total Size: 2.99 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Thanks for working on this.
I noticed one quirk which is that once you "drill down" the state of the sidebar seems to get stuck. I assume this is because it's not taking account of the block editor's selectedBlock state and rather is maintaining it's own state?
Screen.Capture.on.2026-01-29.at.14-02-20.mp4
Testing This Bug
- Open a template part with Navigation block
- Click a navigation item in List View → inspector shows link settings
- Click on a different block in the same template part
- BUG: Sidebar still shows navigation link settings instead of resetting
Good spot. I think I've fixed this in 7fda375, by showing the List View if a different child block is selected in the Navigation block from the canvas. Or if any other block is selected, it should show the Content tab for that block. |
|
The List View tab for patterns can show multiple List Views. That happens if there are multiple blocks that can provide a List View (more than one Navigation, List, Button or Social) with a pattern or template part: Kapture.2026-01-30.at.14.00.38.mp4Because of this I think showing the controls in the Content tab might be a better fit, it's a matter of getting the tab selection working. |
Another option could be to show the Nav Item controls in a popover when one of the blocks is selected in List View. That way the contents in the inspector tab won't reflow and there's less context switching because the List View is still visible. |
getdave
left a comment
There was a problem hiding this comment.
@mikachan This is looking much better thanks.
I noticed that in contentOnly the Page List isn't rendering it's children within the List View.
If you check trunk (or go to isolated template part for Header) you'll notice that it does.
Do you agree we need to show the child blocks here?
|
I'm going to close this in favour of putting these controls in a popover, as done in #75194. |
|
Thanks for all your efforts here. They significantly helped to advance the discussions around this feature 🙇 |

What?
Closes #74895
Alternative to #75042
This PR adds the inspector controls for navigation menu items when they're selected from the List View, enabling users to edit menu items in
contentOnlymode.Why?
With
contentOnlymode enabled, selecting navigation menu items in the Editable List View doesn't display their block controls in the sidebar inspector. This makes it more difficult for users to edit these menu items, as previously, when clicking on a menu item in the List View this would immediately show its inspector controls, allowing users to configure attributes like links, labels, open in new tab settings, etc.How?
This PR implements a solution that mimics the standard block editor pattern for child block selection:
onSelecthandler to thePrivateListViewcomponent that tracks which navigation item is selectedPlease note that this PR does not handle automatically opening the List View for navigation items. This will be handled by #74894, with #75024 as a possible solution.
Testing Instructions
Screenshots or screencast
Screen.Recording.2026-01-29.at.12.44.06.mov