Repository navigation
Color Palette support setup with single array argument (backwards compatible) - #7025
Closed
webmandesign wants to merge 2 commits into
Closed
webmandesign wants to merge 2 commits into
webmandesign wants to merge 2 commits into
Conversation
Contains backwards compatibility code for setting Color Palette support as multiple parameters.
Contributor
Author
|
This code has been discussed in #6437 that was closed due to messy rebase. |
Contributor
|
Would it be possible to refresh this and look at landing it it with 3.2? Happy to do it myself if you aren't available @webmandesign. (cc @jorgefilipecosta, since you reviewed the original PR!) |
Contributor
Author
|
@chrisvanpatten Thanks, I'm OK doing it myself. |
Contributor
Author
|
@chrisvanpatten @jorgefilipecosta |
This was referenced Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allowing
editor-color-palettetheme support setup with a single array of colors parameter/argument. This way only one argument is passed toadd_theme_support( 'editor-color-palette', $arg )instead of multiple arguments for each color.This code is backwards compatible with current implementation (colors are passed as multiple parameters/arguments).
Fising issue #6425