Repository navigation
Adds color panel contrast checker - #69317
Closed
dhruvikpatel18 wants to merge 4 commits into
Closed
dhruvikpatel18 wants to merge 4 commits into
dhruvikpatel18 wants to merge 4 commits into
Conversation
dhruvikpatel18
marked this pull request as ready for review
February 26, 2025 07:07
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
|
The linked issue is now closed, and related work continues in #86186. Considering the code changes are pretty stale, I'm going to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #62213
What?
This PR adds ContrastChecker components to verify contrast ratios between text and background colors for links, captions, buttons, and headings in the color panel.
Why?
This enhancement ensures that users can easily identify when their color choices may create accessibility issues due to poor contrast ratios. By extending the existing text/background contrast checker to include additional elements (links, captions, buttons, and headings), we're providing better feedback to content creators to help them make accessible design choices.
How?
Testing Instructions
Screenshots or screencast
Before
Screen.Recording.2025-02-25.at.4.20.24.PM.mov
After
Screen.Recording.2025-02-26.at.11.05.01.AM.mov