Skip to content

Adds color panel contrast checker - #69317

Closed
dhruvikpatel18 wants to merge 4 commits into
WordPress:trunkfrom
dhruvikpatel18:add/color-panel-contrast-checker
Closed

dhruvikpatel18 wants to merge 4 commits into
WordPress:trunkfrom
dhruvikpatel18:add/color-panel-contrast-checker

Conversation

@dhruvikpatel18

Copy link
Copy Markdown
Member

Closes: #62213

What?

This PR adds ContrastChecker components to verify contrast ratios between text and background colors for links, captions, buttons, and headings in the color panel.

Why?

This enhancement ensures that users can easily identify when their color choices may create accessibility issues due to poor contrast ratios. By extending the existing text/background contrast checker to include additional elements (links, captions, buttons, and headings), we're providing better feedback to content creators to help them make accessible design choices.

How?

  1. Adds contrast checking between link colors (both default and hover states) and page background
  2. Leverages the existing element contrast checking mechanism for captions, buttons, and headings
  3. Displays contrast warnings when color combinations don't meet WCAG accessibility standards
  4. Preserves the existing UI pattern where contrast warnings appear below color controls

Testing Instructions

  • Open the block editor and add a paragraph block
  • Open the sidebar and navigate to the Color panel
  • Set a background color and text color with poor contrast (e.g., light gray text on white background)
  • Verify that a contrast warning appears
  • Now set a link color with poor contrast against the background
  • Verify that a contrast warning appears for the link color

Screenshots or screencast

Before

Screen.Recording.2025-02-25.at.4.20.24.PM.mov

After

Screen.Recording.2025-02-26.at.11.05.01.AM.mov

@dhruvikpatel18 dhruvikpatel18 changed the title Add/color panel contrast checker Adds color panel contrast checker Feb 26, 2025
@dhruvikpatel18
dhruvikpatel18 marked this pull request as ready for review February 26, 2025 07:07
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhruvikpatel18 <dhruvik18@git.wordpress.org>
Co-authored-by: nielslange <nielslange@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Feb 27, 2025
@Mamaduka

Copy link
Copy Markdown
Member

The linked issue is now closed, and related work continues in #86186. Considering the code changes are pretty stale, I'm going to close this PR.

@Mamaduka Mamaduka closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ContrastChecker does not work in site editor

3 participants