Repository navigation
Packages: Extract dom package and make it maintained with Lerna - #6758
Merged
Merged
Conversation
Member
|
Possible merge conflict with #6756 when it comes time to merge |
3 tasks done
gziolo
force-pushed
the
update/extract-dom-package
branch
from
May 15, 2018 14:34
9df1f7d to
2e2e857
Compare
Member
Author
|
Added deprecation for all dom utils in |
Member
Author
|
There are packages which depend on The same applies to |
gziolo
force-pushed
the
update/extract-dom-package
branch
from
May 15, 2018 14:56
c367c49 to
2e2e857
Compare
This was referenced May 16, 2018
This was referenced May 23, 2018
19 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues: #3955, #6594.
This PR extract new
dompackage which contains all DOM utils.Open question
Question is if we should also provide
deprecationmessage for all moved functions from@wordpress/utils?How has this been tested?
Manually:
node_modulesfolder.npm installnpm testnpm run devnpm run buildnpm run package-pluginChecklist: