Repository navigation
Update: Rephrase "Force page reload" and move to Advanced - #65081
Conversation
|
Size Change: +1.29 kB (+0.07%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
eb52dd5 to
d0270d6
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @jarekmorawski, @michaelpick. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 660cd82. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10718895364
|
|
Good note, done! |
| } else if ( hasUnsupportedBlocks ) { | ||
| help = __( | ||
| "Force page reload can't be disabled because there are non-compatible blocks inside the Query block." | ||
| "Reload full page can't be disabled because there are non-compatible blocks inside the Query block." |
There was a problem hiding this comment.
One important note. When there are non-compatible blocks, then the full page navigation, as in older WordPress versions, needs to happen. I think it's what it says but it's still confusing for me. Eventually, we should aim to remove this compatibility check and instead handle everything on the front end using a progressive enhancement approach. For example, when the partial page change withouth full reload is enabled, we try to go to the next page and if Interactivity API detects something went wrong, it should fall back to the usual behavior when someone click a link.
|
I like where it is going. I'd like to explore how to remove the compatibility check and related warning as briefly explained in #65081 (comment). |
…ced-pagination-control.js Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
|
Applied suggestions. |
gziolo
left a comment
There was a problem hiding this comment.
Let's land it as it feels more intuitive with the new phrasing.
…ced-pagination-control.js
| } else if ( enhancedPagination ) { | ||
| help = __( | ||
| "Browsing between pages won't require a full page reload, unless non-compatible blocks are detected." | ||
| 'Reload the full page—instead of just the posts list—when visitors navigate between pages.' |
There was a problem hiding this comment.
I'm not sure this is correct.
| } else if ( hasUnsupportedBlocks ) { | ||
| help = __( | ||
| "Force page reload can't be disabled because there are non-compatible blocks inside the Query block." | ||
| 'Enhancement disabled because there are non-compatible blocks inside the Query block.' |
There was a problem hiding this comment.
The word 'enhancement' is still biased as it assumes one of the two navigation model is, in a way., 'better'. As I mentioned in #63599 (comment), to me WordPress should not make any assumption on what kind of experience is 'better' for users. It should present the feature in a neutral way,
There was a problem hiding this comment.
Agreed on not using words like "enhancement" which are going to be contextual and instead describing how things work in a way people can understand.

What?
Fixes #63599. Updates the phrasing of the force page reload setting, and moves it to the Advanced section.
Before:
After:
Why?
The phrasing is confusing, as is the intricate behavior of the control itself.
Testing Instructions
Insert a query loop, and observe the control in the inspector.