Skip to content

Screen Takeover using custom modal - #6244

Closed
abotteram wants to merge 26 commits into
masterfrom
add/slot-fill-screen-takeover-api-modal
Closed

abotteram wants to merge 26 commits into
masterfrom
add/slot-fill-screen-takeover-api-modal

Conversation

@abotteram

@abotteram abotteram commented Apr 18, 2018 •

Copy link
Copy Markdown
Contributor

Description

This implementation uses a custom modal in components/modal.
I mirrored the react-modal API for all features that I needed to make this work, they will be described in components/modal/README.md soon.

How has this been tested?

Reducers and actions have been unit tested.
Modal has been tested with this plugin.

Screenshots

screen shot 2018-04-18 at 15 01 38

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@atimmer atimmer added this to the Merge Proposal: Plugins milestone Apr 18, 2018
@abotteram abotteram mentioned this pull request Apr 18, 2018
4 tasks done
@aduth

aduth commented Jul 3, 2018

Copy link
Copy Markdown
Member

Should this be closed in favor of #6261 ?

@aduth

aduth commented Jul 4, 2018

Copy link
Copy Markdown
Member

Superseded by #6261

@aduth aduth closed this Jul 4, 2018
@sirreal
sirreal deleted the add/slot-fill-screen-takeover-api-modal branch June 18, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants